From 5e0ae3f0a44c2c8937b8b35e91f007d5a138031b Mon Sep 17 00:00:00 2001
From: Sreelakshmi Konamki <c_skonam@qti.qualcomm.com>
Date: Wed, 7 Dec 2016 15:21:44 +0530
Subject: [PATCH] wlan: Remove PTK/GTK debug logs
Currently host prints PTK and GTK key information in default logs.
Fix to remove the debug logs which prints sensitive key information.
Change-Id: I358b09b77d23eeb5da7d826859ae119a8ea4af8a
CRs-Fixed: 1097857
---
.../staging/prima/CORE/MAC/src/pe/lim/limFT.c | 23 -------------------
.../prima/CORE/SME/src/csr/csrApiRoam.c | 9 --------
.../prima/CORE/SME/src/sme_common/sme_FTApi.c | 21 -----------------
3 files changed, 53 deletions(-)
diff --git a/drivers/staging/prima/CORE/MAC/src/pe/lim/limFT.c b/drivers/staging/prima/CORE/MAC/src/pe/lim/limFT.c
index 8cbe6b81ebf5..972ffab6a483 100644
--- a/drivers/staging/prima/CORE/MAC/src/pe/lim/limFT.c
+++ b/drivers/staging/prima/CORE/MAC/src/pe/lim/limFT.c
@@ -1504,29 +1504,6 @@ tANI_BOOLEAN limProcessFTUpdateKey(tpAniSirGlobal pMac, tANI_U32 *pMsgBuf )
limLog(pMac, LOG1,
FL("BSSID = "MAC_ADDRESS_STR), MAC_ADDR_ARRAY(pKeyInfo->bssId));
- if(pAddBssParams->extSetStaKeyParam.key[0].keyLength == 16)
- {
- limLog(pMac, LOG1,
- FL("BSS key = %02X-%02X-%02X-%02X-%02X-%02X-%02X- "
- "%02X-%02X-%02X-%02X-%02X-%02X-%02X-%02X-%02X"),
- pAddBssParams->extSetStaKeyParam.key[0].key[0],
- pAddBssParams->extSetStaKeyParam.key[0].key[1],
- pAddBssParams->extSetStaKeyParam.key[0].key[2],
- pAddBssParams->extSetStaKeyParam.key[0].key[3],
- pAddBssParams->extSetStaKeyParam.key[0].key[4],
- pAddBssParams->extSetStaKeyParam.key[0].key[5],
- pAddBssParams->extSetStaKeyParam.key[0].key[6],
- pAddBssParams->extSetStaKeyParam.key[0].key[7],
- pAddBssParams->extSetStaKeyParam.key[0].key[8],
- pAddBssParams->extSetStaKeyParam.key[0].key[9],
- pAddBssParams->extSetStaKeyParam.key[0].key[10],
- pAddBssParams->extSetStaKeyParam.key[0].key[11],
- pAddBssParams->extSetStaKeyParam.key[0].key[12],
- pAddBssParams->extSetStaKeyParam.key[0].key[13],
- pAddBssParams->extSetStaKeyParam.key[0].key[14],
- pAddBssParams->extSetStaKeyParam.key[0].key[15]);
- }
-
return TRUE;
}
diff --git a/drivers/staging/prima/CORE/SME/src/csr/csrApiRoam.c b/drivers/staging/prima/CORE/SME/src/csr/csrApiRoam.c
index 29ec845a9ed9..245eb1dc3733 100644
--- a/drivers/staging/prima/CORE/SME/src/csr/csrApiRoam.c
+++ b/drivers/staging/prima/CORE/SME/src/csr/csrApiRoam.c
@@ -14385,16 +14385,7 @@ eHalStatus csrSendMBSetContextReqMsg( tpAniSirGlobal pMac, tANI_U32 sessionId,
// set pSirKey->keyLength = keyLength;
p = pal_set_U16( p, pal_cpu_to_be16(keyLength) );
if ( keyLength && pKey )
- {
vos_mem_copy(p, pKey, keyLength);
- if(keyLength == 16)
- {
- smsLog(pMac, LOG1, " SME Set keyIdx (%d) encType(%d) key = %02X-%02X-%02X-%02X-%02X-%02X-%02X-%02X-%02X-%02X-%02X-%02X-%02X-%02X-%02X-%02X",
- keyId, edType, pKey[0], pKey[1], pKey[2], pKey[3], pKey[4],
- pKey[5], pKey[6], pKey[7], pKey[8],
- pKey[9], pKey[10], pKey[11], pKey[12], pKey[13], pKey[14], pKey[15]);
- }
- }
status = palSendMBMessage(pMac->hHdd, pMsg);
} while( 0 );
return( status );
diff --git a/drivers/staging/prima/CORE/SME/src/sme_common/sme_FTApi.c b/drivers/staging/prima/CORE/SME/src/sme_common/sme_FTApi.c
index cde968833a27..4d988afb85f9 100644
--- a/drivers/staging/prima/CORE/SME/src/sme_common/sme_FTApi.c
+++ b/drivers/staging/prima/CORE/SME/src/sme_common/sme_FTApi.c
@@ -216,12 +216,7 @@ eHalStatus sme_FTSendUpdateKeyInd(tHalHandle hHal, tCsrRoamSetKey * pFTKeyInfo)
tAniEdType edType;
tpAniSirGlobal pMac = PMAC_STRUCT( hHal );
#if defined WLAN_FEATURE_VOWIFI_11R_DEBUG
- int i = 0;
-
smsLog(pMac, LOG1, FL("keyLength %d"), pFTKeyInfo->keyLength);
-
- for (i=0; i<pFTKeyInfo->keyLength; i++)
- smsLog(pMac, LOG1, FL("%02x"), pFTKeyInfo->Key[i]);
#endif
msgLen = sizeof(tSirFTUpdateKeyInfo);
@@ -262,23 +257,7 @@ eHalStatus sme_FTSendUpdateKeyInd(tHalHandle hHal, tCsrRoamSetKey * pFTKeyInfo)
keymaterial->key[ 0 ].keyLength = pFTKeyInfo->keyLength;
if ( pFTKeyInfo->keyLength && pFTKeyInfo->Key )
- {
vos_mem_copy(&keymaterial->key[ 0 ].key, pFTKeyInfo->Key, pFTKeyInfo->keyLength);
- if(pFTKeyInfo->keyLength == 16)
- {
- smsLog(pMac, LOG1, "SME Set Update Ind keyIdx (%d) encType(%d) key = "
- "%02X-%02X-%02X-%02X-%02X-%02X-%02X-%02X-%02X-%02X-%02X-%02X-%02X-%02X-%02X-%02X",
- pMsg->keyMaterial.key[0].keyId, (tAniEdType)pMsg->keyMaterial.edType,
- pMsg->keyMaterial.key[0].key[0], pMsg->keyMaterial.key[0].key[1],
- pMsg->keyMaterial.key[0].key[2], pMsg->keyMaterial.key[0].key[3],
- pMsg->keyMaterial.key[0].key[4], pMsg->keyMaterial.key[0].key[5],
- pMsg->keyMaterial.key[0].key[6], pMsg->keyMaterial.key[0].key[7],
- pMsg->keyMaterial.key[0].key[8], pMsg->keyMaterial.key[0].key[9],
- pMsg->keyMaterial.key[0].key[10], pMsg->keyMaterial.key[0].key[11],
- pMsg->keyMaterial.key[0].key[12], pMsg->keyMaterial.key[0].key[13],
- pMsg->keyMaterial.key[0].key[14], pMsg->keyMaterial.key[0].key[15]);
- }
- }
vos_mem_copy( &pMsg->bssId[ 0 ],
&pFTKeyInfo->peerMac[ 0 ],
--
GitLab