From 9fa1b1dc9923a7b5892df4feadef4bd953c8665b Mon Sep 17 00:00:00 2001 From: William Clark <wclark@codeaurora.org> Date: Thu, 9 Apr 2015 17:58:56 -0700 Subject: [PATCH] qseecom: Fix NULL pointer dereference Application name passed from the user space might be NULL or corrupted, which if accessed later on might end up in NULL pointer dereference. Change-Id: I3c91c19a60cee209436218dd9ea370ef53c8c8b6 Signed-off-by: William Clark <wclark@codeaurora.org> --- drivers/misc/qseecom.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/misc/qseecom.c b/drivers/misc/qseecom.c index ec2733d1c520..76afe3c7f3ba 100644 --- a/drivers/misc/qseecom.c +++ b/drivers/misc/qseecom.c @@ -2359,7 +2359,11 @@ int qseecom_start_app(struct qseecom_handle **handle, size_t len; ion_phys_addr_t pa; - if (!app_name || strlen(app_name) >= MAX_APP_NAME_SIZE) { + if (!app_name) { + pr_err("failed to get the app name\n"); + return -EINVAL; + } + if (strlen(app_name) >= MAX_APP_NAME_SIZE) { pr_err("The app_name (%s) with length %zu is not valid\n", app_name, strlen(app_name)); return -EINVAL; -- GitLab