From c3924b06c3b0412c2b46f5d00095481b2fe0474f Mon Sep 17 00:00:00 2001 From: Zhao Xuewen <zhaoxuewen@huawei.com> Date: Fri, 8 Apr 2016 10:46:38 +0800 Subject: [PATCH] net: wireless: bcmdhd: Do not print out device name on invalid length Bug: 27142322 Change-Id: I631f87dcafe8423221099c285332a0b6f86b9ea8 Signed-off-by: Patrick Tjin <pattjin@google.com> --- drivers/net/wireless/bcmdhd/wl_cfg80211.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/net/wireless/bcmdhd/wl_cfg80211.c b/drivers/net/wireless/bcmdhd/wl_cfg80211.c index 56114346f09e..24be3426313a 100644 --- a/drivers/net/wireless/bcmdhd/wl_cfg80211.c +++ b/drivers/net/wireless/bcmdhd/wl_cfg80211.c @@ -1160,10 +1160,12 @@ wl_validate_wps_ie(char *wps_ie, s32 wps_ie_len, bool *pbc) } else if (subelt_id == WPS_ID_DEVICE_NAME) { char devname[100]; size_t namelen = MIN(subelt_len, sizeof(devname)); - memcpy(devname, subel, namelen); - devname[namelen-1] = '\0'; - WL_DBG((" attr WPS_ID_DEVICE_NAME: %s (len %u)\n", - devname, subelt_len)); + if (namelen) { + memcpy(devname, subel, namelen); + devname[namelen - 1] = '\0'; + WL_DBG((" attr WPS_ID_DEVICE_NAME: %s (len %u)\n", + devname, subelt_len)); + } } else if (subelt_id == WPS_ID_DEVICE_PWD_ID) { valptr[0] = *subel; valptr[1] = *(subel + 1); -- GitLab