From f09dd7285636070c155292347155f90c655489fa Mon Sep 17 00:00:00 2001
From: Patrick Tjin <pattjin@google.com>
Date: Tue, 6 Jan 2015 09:19:39 -0800
Subject: [PATCH] Fix sizeof-pointer-memaccess warnings
Changed to use strcmp since sizeof buffer is not known.
Changed sizeof to PAGE_SIZE in snprintf.
Signed-off-by: Patrick Tjin <pattjin@google.com>
---
drivers/usb/gadget/f_qdss.c | 4 ++--
drivers/video/msm/mipi_novatek.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/gadget/f_qdss.c b/drivers/usb/gadget/f_qdss.c
index 26e4bd536421..e939748addc0 100644
--- a/drivers/usb/gadget/f_qdss.c
+++ b/drivers/usb/gadget/f_qdss.c
@@ -583,7 +583,7 @@ static int qdss_bind_config(struct usb_configuration *c, const char *name)
spin_lock_irqsave(&d_lock, flags);
list_for_each_entry(ch, &usb_qdss_ch_list, list) {
- if (!strncmp(name, ch->name, sizeof(ch->name))) {
+ if (strcmp(name, ch->name) == 0) {
found = 1;
break;
}
@@ -737,7 +737,7 @@ struct usb_qdss_ch *usb_qdss_open(const char *name, void *priv,
spin_lock_irqsave(&d_lock, flags);
/* Check if we already have a channel with this name */
list_for_each_entry(ch, &usb_qdss_ch_list, list) {
- if (!strncmp(name, ch->name, sizeof(ch->name))) {
+ if (strcmp(name, ch->name) == 0) {
found = 1;
break;
}
diff --git a/drivers/video/msm/mipi_novatek.c b/drivers/video/msm/mipi_novatek.c
index 096305317679..013bbe3afb37 100644
--- a/drivers/video/msm/mipi_novatek.c
+++ b/drivers/video/msm/mipi_novatek.c
@@ -680,7 +680,7 @@ static ssize_t mipi_dsi_3d_barrier_read(struct device *dev,
struct device_attribute *attr,
char *buf)
{
- return snprintf((char *)buf, sizeof(buf), "%u\n", barrier_mode);
+ return snprintf((char *)buf, PAGE_SIZE, "%u\n", barrier_mode);
}
static ssize_t mipi_dsi_3d_barrier_write(struct device *dev,
--
GitLab