From f9c1ac5ea02ba56163b9c300cb78815aa1dc915f Mon Sep 17 00:00:00 2001
From: Luis Gerhorst <luis.gerhorst@fau.de>
Date: Tue, 10 Jul 2018 16:27:45 +0200
Subject: [PATCH] Cleanup
---
arch/arm/measuremore/measure.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/arch/arm/measuremore/measure.c b/arch/arm/measuremore/measure.c
index 6159900..f8d79c3 100644
--- a/arch/arm/measuremore/measure.c
+++ b/arch/arm/measuremore/measure.c
@@ -18,10 +18,11 @@ u32 debugfs_progress_interval = 100;
static struct dentry *csv_results_folder = NULL;
-/* Lightweight data structure to record checkpoints while benchmarking. Cache-friendly. */
+/* Lightweight data structure to record checkpoints while
+ * benchmarking. Cache-friendly. */
struct benchmark_record {
size_t width; /* The maximum number of checkpoints in a run. */
- size_t height; /* The number of repetitions. */
+ size_t height; /* The number of runs. */
struct checkpoint_record cpr_matrix[];
};
@@ -59,7 +60,7 @@ int memo_start_benchmark(size_t reps, size_t checkpoint_capacity)
/* To put the area into the cache and allow us to recognize used
* checkpoint records. */
- pr_info("Initializing matrix with 0s... \n");
+ pr_info("Initializing matrix with 0s... ");
memzero_explicit(current_bmr, bmr_size);
pr_info("done\n");
@@ -69,8 +70,6 @@ int memo_start_benchmark(size_t reps, size_t checkpoint_capacity)
current_y = 0;
#ifdef CONFIG_MEASUREMORE_TIMESTAMP_TYPE_PMCCNTR
- /* TODO: The followind does not seem to actually reset the pmccntr to
- * 0. It only starts the counter in the first place. */
pmccntr_reset();
#endif
return 0;
@@ -245,7 +244,6 @@ static void export_current_bmr_to_csv_results(void)
pr_info("Exporting results as CSVs:\n");
csv_results_folder = debugfs_create_dir("csv_results", memo_root);
BUG_ON(!csv_results_folder);
- /* Don't forget to free each blob's data in destroy_csv_field(). */
#ifdef CONFIG_MEASUREMORE_TIMESTAMP_TYPE_PMCCNTR
create_csv_file("pmccntr", seq_write_pmccntr_csv_field,
csv_results_folder);
--
GitLab