From 5c1c60ca5bedf89cc186ff82448aab47cedd7ccf Mon Sep 17 00:00:00 2001
From: Florian Fischer <florian.fischer@muhq.space>
Date: Thu, 23 Sep 2021 18:01:07 +0200
Subject: [PATCH] [SimpleDiskAndNetworkTest] don't terminate the Runtime during
the test
Before 05dc56ed the two test cases testDiskAndNetwork, testIov
where combined in one function which was terminating the runtime after the client
closed its socketafter the test was done.
This was already broken before 05dc56ed but after the separation of the
two use cases the race between the Runtime terminating and the execution of
the last parts of the test-runner's alphaFiber became bigger.
When the Runtime terminates because the last worker running the testIoV
code has outstanding IO the test-runner's successSem is never notified.
---
tests/io/SimpleDiskAndNetworkTest.cpp | 1 -
1 file changed, 1 deletion(-)
diff --git a/tests/io/SimpleDiskAndNetworkTest.cpp b/tests/io/SimpleDiskAndNetworkTest.cpp
index 89e0db0c..6150fb93 100644
--- a/tests/io/SimpleDiskAndNetworkTest.cpp
+++ b/tests/io/SimpleDiskAndNetworkTest.cpp
@@ -33,7 +33,6 @@ static void server_func(int client_fd) {
for (;;) {
ssize_t received = recvAndWait(client_fd, recv_buf.data(), recv_buf.size(), 0);
if (received == 0) {
- Runtime::getRuntime()->initiateTermination();
return;
}
--
GitLab