GitLab

previously a race condition when starting a game
allowed the lobby loop to run into a draw call
trying to acquire the lobby lock, while a different
routine was holding the lock and waiting for this loop
to terminate.

only pass the termination check if the lobby lock for
the draw call can be acquired.

should've committed this when i still knew why i did it

prepare for refactor to establish cleaner separation between what
is now in packages. package will also allow for cleaner namespaces
in the future

playerlist, extensionlist and statusbar to show keymappings

we support 0 size screens/views anyway, no need for arbitrary
initial view sizes. just always use the Resize mechanism that
has to be present anyway

this is not currently an issue, since the only transition with
side effects is final scoring which is idempotent

these parts seems reliable enough for now

from lobby, always
from game, if game is empty

since resize and bounds checks work (for a whole while) now
it is not necessary anymore to assume an arbitrary default size

clear to erase names of no longer present players

Update iterates the player map -> needs lock

avoid artifacts when switching contexts

use to keep track of:
present players and order in lobby
connection status in game

windowSizeLoop does not access any variables that are altered during a
reconnect. therefore it can continue to run uninterrupted

keepalive takes care of terminating stale connections so we do not have to
implement a ping loop.

inputloop now accesses player reference. no input loop for a player
must be running when that player is being modified

artifact from previous Place -> *Place refactor

coordinates rotations and pieces are now taken from
the place or state parameters. this fixes an issue of
tokens on a board place being shown on the currently
to-be-placed piece.

prepare for render getting an optional *Place parameter.
optional parameter must be pointer to be able to detect
whether it is present.
for consistency make everything take pointers

bounds check must be done inside the lock.. duh

read the variable after assigning, not before...

farm require neighboorhood information between farms and cities,
which is not yet encoded.
end game scoring is not yet implemented

pennants, inns, cathedrals

detecting adjacent parts of a structure and lack thereof will be used
to tell whether a structure is completed

use breaks instead of weird empty if blocks