Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • E emper
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Florian Fischer
  • emper
  • Merge requests
  • !3

[IO] fail hard if the globalCompleter would drop a Future

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Florian Fischer requested to merge submit_fail_hard into master Feb 03, 2021
  • Overview 0
  • Commits 1
  • Pipelines 1
  • Changes 1

Currently the globalCompleter would drop Futures which he is not able to submit to its SQ because io_uring_submit returned -EBUSY, signalizing a full CQ.

Additional small code changes:

  • don't wrap assert in if constexpr(DEBUG)
  • annotate Future completion in globalCompleter as unlikely
  • use prepared Future count as unsigned
  • remove redundant parenthesis
  • introduce helper function for IoCOntext* tagging For now we fail hard if this hopefully unlikely case occurs.
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: submit_fail_hard