Skip to content
Snippets Groups Projects
Commit 068eac91 authored by Yasushi SHOJI's avatar Yasushi SHOJI Committed by Junio C Hamano
Browse files

[PATCH] plug memory leak in diff.c::diff_free_filepair()


When I run git-diff-tree on big change, it seems the command eats so
much memory.  so I just put git under valgrind to see what's going on.
diff_free_filespec_data() doesn't free diff_filespec itself.

[jc: I ended up doing things slightly differently from Yasushi's
patch.  The original idea was to use free_filespec_data() only to
free the data portion and keep useing the filespec itself, but
no existing code seems to do things that way, so I just yanked
that part out.]

Signed-off-by: default avatarYasushi SHOJI <yashi@atmark-techno.com>
Signed-off-by: default avatarJunio C Hamano <junkio@cox.net>
parent e54c5ea9
No related merge requests found
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment