-
- Downloads
strbuf: introduce strbuf_getline_{lf,nul}()
The strbuf_getline() interface allows a byte other than LF or NUL as
the line terminator, but this is only because I wrote these
codepaths anticipating that there might be a value other than NUL
and LF that could be useful when I introduced line_termination long
time ago. No useful caller that uses other value has emerged.
By now, it is clear that the interface is overly broad without a
good reason. Many codepaths have hardcoded preference to read
either LF terminated or NUL terminated records from their input, and
then call strbuf_getline() with LF or NUL as the third parameter.
This step introduces two thin wrappers around strbuf_getline(),
namely, strbuf_getline_lf() and strbuf_getline_nul(), and
mechanically rewrites these call sites to call either one of
them. The changes contained in this patch are:
* introduction of these two functions in strbuf.[ch]
* mechanical conversion of all callers to strbuf_getline() with
either '\n' or '\0' as the third parameter to instead call the
respective thin wrapper.
After this step, output from "git grep 'strbuf_getline('" would
become a lot smaller. An interim goal of this series is to make
this an empty set, so that we can have strbuf_getline_crlf() take
over the shorter name strbuf_getline().
Signed-off-by:
Junio C Hamano <gitster@pobox.com>
Showing
- bisect.c 4 additions, 4 deletionsbisect.c
- builtin/am.c 7 additions, 7 deletionsbuiltin/am.c
- builtin/cat-file.c 1 addition, 1 deletionbuiltin/cat-file.c
- builtin/check-mailmap.c 1 addition, 1 deletionbuiltin/check-mailmap.c
- builtin/clean.c 3 additions, 3 deletionsbuiltin/clean.c
- builtin/clone.c 1 addition, 1 deletionbuiltin/clone.c
- builtin/column.c 1 addition, 1 deletionbuiltin/column.c
- builtin/commit.c 1 addition, 1 deletionbuiltin/commit.c
- builtin/fetch-pack.c 1 addition, 1 deletionbuiltin/fetch-pack.c
- builtin/grep.c 1 addition, 1 deletionbuiltin/grep.c
- builtin/hash-object.c 1 addition, 1 deletionbuiltin/hash-object.c
- builtin/notes.c 1 addition, 1 deletionbuiltin/notes.c
- builtin/pull.c 1 addition, 1 deletionbuiltin/pull.c
- builtin/repack.c 1 addition, 1 deletionbuiltin/repack.c
- builtin/rev-parse.c 2 additions, 2 deletionsbuiltin/rev-parse.c
- builtin/send-pack.c 1 addition, 1 deletionbuiltin/send-pack.c
- compat/terminal.c 1 addition, 1 deletioncompat/terminal.c
- credential-cache--daemon.c 2 additions, 2 deletionscredential-cache--daemon.c
- credential-store.c 1 addition, 1 deletioncredential-store.c
- credential.c 1 addition, 1 deletioncredential.c
Loading
Please sign in to comment