Skip to content
Snippets Groups Projects
Commit b909a15e authored by Marco Costalba's avatar Marco Costalba Committed by Junio C Hamano
Browse files

[PATCH] Fix git-commit-script to output on stderr when -v fails


When git-commit-script is called with -v option and
verify test fails result is print on stdout
instead of stderr.

[jc: The original patch from Marco updated git-commit-script that
still had the piece of code in question, which has been moved to
an example hook script on its own, so I transplanted the patch to
that new file instead.]

Signed-off-by: default avatarMarco Costalba <mcostalba@yahoo.it>
Signed-off-by: default avatarJunio C Hamano <junkio@cox.net>
parent 165e160e
No related branches found
No related tags found
No related merge requests found
...@@ -19,17 +19,17 @@ perl -e ' ...@@ -19,17 +19,17 @@ perl -e '
sub bad_line { sub bad_line {
my ($why, $line) = @_; my ($why, $line) = @_;
if (!$found_bad) { if (!$found_bad) {
print "*\n"; print STDERR "*\n";
print "* You have some suspicious patch lines:\n"; print STDERR "* You have some suspicious patch lines:\n";
print "*\n"; print STDERR "*\n";
$found_bad = 1; $found_bad = 1;
} }
if ($reported_filename ne $filename) { if ($reported_filename ne $filename) {
print "* In $filename\n"; print STDERR "* In $filename\n";
$reported_filename = $filename; $reported_filename = $filename;
} }
print "* $why (line $lineno)\n"; print STDERR "* $why (line $lineno)\n";
print "$filename:$lineno:$line\n"; print STDERR "$filename:$lineno:$line\n";
} }
open $fh, "-|", qw(git-diff-cache -p -M --cached HEAD); open $fh, "-|", qw(git-diff-cache -p -M --cached HEAD);
while (<$fh>) { while (<$fh>) {
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment