Skip to content
Snippets Groups Projects
Commit 99d5d430 authored by Lianchao Song's avatar Lianchao Song
Browse files

tcp: make challenge acks less predictable


CVE-2016-5696

Yue Cao claims that current host rate limiting of challenge ACKS
(RFC 5961) could leak enough information to allow a patient attacker
to hijack TCP sessions. He will soon provide details in an academic
paper.

This patch increases the default limit from 100 to 1000, and adds
some randomization so that the attacker can no longer hijack
sessions without spending a considerable amount of probes.

Based on initial analysis and patch from Linus.

Note that we also have per socket rate limiting, so it is tempting
to remove the host limit in the future.

v2: randomize the count of challenge acks per second, not the period.

Change-Id: I7b53e7006f54c459885a6c51a1f2b4d96b26e3a2
Fixes: 282f23c6 ("tcp: implement RFC 5961 3.2")
Reported-by: default avatarYue Cao <ycao009@ucr.edu>
Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
Suggested-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
Cc: Yuchung Cheng <ycheng@google.com>
Cc: Neal Cardwell <ncardwell@google.com>
Acked-by: default avatarNeal Cardwell <ncardwell@google.com>
Acked-by: default avatarYuchung Cheng <ycheng@google.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 2d484da5
Branches before_bilderlab
No related tags found
No related merge requests found
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment