Skip to content
Snippets Groups Projects
Commit e013bc2a authored by Viktor Slavkovic's avatar Viktor Slavkovic Committed by Pat Tjin
Browse files

staging: android: ashmem: fix a race condition in ASHMEM_SET_SIZE ioctl


A lock-unlock is missing in ASHMEM_SET_SIZE ioctl which can result in a
race condition when mmap is called. After the !asma->file check, before
setting asma->size, asma->file can be set in mmap. That would result in
having different asma->size than the mapped memory size. Combined with
ASHMEM_UNPIN ioctl and shrinker invocation, this can result in memory
corruption.

Bug: 66954097
Signed-off-by: default avatarViktor Slavkovic <viktors@google.com>
Change-Id: Ia52312a75ade30bc94be6b94420f17f34e0c1f86
parent 823383c9
No related branches found
No related tags found
No related merge requests found
...@@ -672,10 +672,12 @@ static long ashmem_ioctl(struct file *file, unsigned int cmd, unsigned long arg) ...@@ -672,10 +672,12 @@ static long ashmem_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
break; break;
case ASHMEM_SET_SIZE: case ASHMEM_SET_SIZE:
ret = -EINVAL; ret = -EINVAL;
mutex_lock(&ashmem_mutex);
if (!asma->file) { if (!asma->file) {
ret = 0; ret = 0;
asma->size = (size_t) arg; asma->size = (size_t) arg;
} }
mutex_unlock(&ashmem_mutex);
break; break;
case ASHMEM_GET_SIZE: case ASHMEM_GET_SIZE:
ret = asma->size; ret = asma->size;
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment