Skip to content
Snippets Groups Projects
Commit f7ed102e authored by Sasha Levin's avatar Sasha Levin Committed by Gerrit - the friendly Code Review server
Browse files

net/l2tp: don't fall back on UDP [get|set]sockopt


The l2tp [get|set]sockopt() code has fallen back to the UDP functions
for socket option levels != SOL_PPPOL2TP since day one, but that has
never actually worked, since the l2tp socket isn't an inet socket.

As David Miller points out:

  "If we wanted this to work, it'd have to look up the tunnel and then
   use tunnel->sk, but I wonder how useful that would be"

Since this can never have worked so nobody could possibly have depended
on that functionality, just remove the broken code and return -EINVAL.

Change-Id: I7d00fb0c595cdd65f9724d710f93ca5362019e43
Reported-by: default avatarSasha Levin <sasha.levin@oracle.com>
Acked-by: default avatarJames Chapman <jchapman@katalix.com>
Acked-by: default avatarDavid Miller <davem@davemloft.net>
Cc: Phil Turnbull <phil.turnbull@oracle.com>
Cc: Vegard Nossum <vegard.nossum@oracle.com>
Cc: Willy Tarreau <w@1wt.eu>
Cc: stable@vger.kernel.org
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: default avatarDivya Sharma <c_shard@codeaurora.org>
parent 1dd84072
Branches
Tags
No related merge requests found
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment