Skip to content
Snippets Groups Projects
Select Git revision
  • c1b26acae295034e7aab2414ba50047cc889cafe
  • master default protected
  • android-7.1.2_r28_klist
  • oreo-mr1-iot-release
  • sdk-release
  • pie-cts-dev
  • pie-cts-release
  • pie-vts-release
  • nougat-iot-release
  • pie-gsi
  • pie-platform-release
  • pie-r2-release
  • pie-r2-s1-release
  • pie-release
  • pie-dev
  • oreo-m4-s4-release
  • o-mr1-iot-preview-8
  • oreo-m2-s2-release
  • oreo-m2-s1-release
  • oreo-m6-s2-release
  • oreo-m6-s3-release
  • android-o-mr1-iot-release-1.0.4
  • android-9.0.0_r8
  • android-9.0.0_r7
  • android-9.0.0_r6
  • android-9.0.0_r5
  • android-8.1.0_r46
  • android-8.1.0_r45
  • android-n-iot-release-smart-display-r2
  • android-vts-8.1_r5
  • android-cts-8.1_r8
  • android-cts-8.0_r12
  • android-cts-7.1_r20
  • android-cts-7.0_r24
  • android-cts-6.0_r31
  • android-o-mr1-iot-release-1.0.3
  • android-cts-9.0_r1
  • android-8.1.0_r43
  • android-8.1.0_r42
  • android-n-iot-release-smart-display
  • android-p-preview-5
41 results

util_test.cpp

Blame
    • Nick Kralevich's avatar
      d2104df6
      init/util.cpp: don't return a negative unsigned value · d2104df6
      Nick Kralevich authored
      android_name_to_id() returns -1U on error, which causes a
      crash when the following clang options are enabled:
      
        -fsanitize=signed-integer-overflow,unsigned-integer-overflow
        -ftrap-function=abort
        -fsanitize-undefined-trap-on-error
      
      Rather than returning a negative unsigned value (which doesn't
      make a lot of sense, IMHO), return a positive unsigned value.
      
      While we're here, add logging on decode_uid failures.
      
      Bug: 21880301
      Change-Id: I652e4c1daa07c7494cceca2b4e1656b9158f2604
      d2104df6
      History
      init/util.cpp: don't return a negative unsigned value
      Nick Kralevich authored
      android_name_to_id() returns -1U on error, which causes a
      crash when the following clang options are enabled:
      
        -fsanitize=signed-integer-overflow,unsigned-integer-overflow
        -ftrap-function=abort
        -fsanitize-undefined-trap-on-error
      
      Rather than returning a negative unsigned value (which doesn't
      make a lot of sense, IMHO), return a positive unsigned value.
      
      While we're here, add logging on decode_uid failures.
      
      Bug: 21880301
      Change-Id: I652e4c1daa07c7494cceca2b4e1656b9158f2604
    io_uring.c 802 B
    #include <err.h>
    #include <errno.h>
    #include <liburing.h>
    #include <stdlib.h>
    
    #include "stopwatch.h"
    
    struct io_uring ring;
    
    void init(__attribute__((unused)) int fd) {
    	int res = io_uring_queue_init(1, &ring, 0);
    	if (res < 0) {
    		errno = -res;
    		err(EXIT_FAILURE, "io_uring_setup failed");
    	}
    }
    
    unsigned do_read(int fd, void *buf, size_t count) {
    	start_watch();
    
    	struct io_uring_sqe *sqe = io_uring_get_sqe(&ring);
    	io_uring_prep_read(sqe, fd, buf, count, 0);
    
    	int res = io_uring_submit_and_wait(&ring, 1);
    
    	stop_watch();
    
    	if (res < 0) err(EXIT_FAILURE, "io_uring_submit_and_wait failed");
    
    	struct io_uring_cqe *cqe;
    	res = io_uring_peek_cqe(&ring, &cqe);
    	if (res < 0) err(EXIT_FAILURE, "io_uring_peek_cqe failed");
    
    	if (cqe->res < 0) err(EXIT_FAILURE, "read request failed");
    	return 1;
    }