Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
A
AndroidSystemCore
Manage
Activity
Members
Code
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Deploy
Releases
Container registry
Model registry
Analyze
Contributor analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
GitLab community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Werner Sembach
AndroidSystemCore
Commits
1fa55234
Commit
1fa55234
authored
Oct 22, 2015
by
Christopher Ferris
Browse files
Options
Downloads
Patches
Plain Diff
Fix incorrect check of descsz value.
Bug: 25187394 Change-Id: I9642cf493b83ac0eecd71394718ecbefae5d9a33
parent
04766e5a
No related branches found
No related tags found
No related merge requests found
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
debuggerd/elf_utils.cpp
+4
-4
4 additions, 4 deletions
debuggerd/elf_utils.cpp
with
4 additions
and
4 deletions
debuggerd/elf_utils.cpp
+
4
−
4
View file @
1fa55234
...
@@ -63,10 +63,10 @@ static bool get_build_id(
...
@@ -63,10 +63,10 @@ static bool get_build_id(
if
(
nhdr
.
n_type
==
NT_GNU_BUILD_ID
)
{
if
(
nhdr
.
n_type
==
NT_GNU_BUILD_ID
)
{
// Skip the name (which is the owner and should be "GNU").
// Skip the name (which is the owner and should be "GNU").
addr
+=
NOTE_ALIGN
(
nhdr
.
n_namesz
);
addr
+=
NOTE_ALIGN
(
nhdr
.
n_namesz
);
uint8_t
build_id_data
[
1
28
];
uint8_t
build_id_data
[
1
60
];
if
(
nhdr
.
n_
name
sz
>
sizeof
(
build_id_data
))
{
if
(
nhdr
.
n_
desc
sz
>
sizeof
(
build_id_data
))
{
ALOGE
(
"Possible corrupted note,
name
size value is too large: %u"
,
ALOGE
(
"Possible corrupted note,
desc
size value is too large: %u"
,
nhdr
.
n_
name
sz
);
nhdr
.
n_
desc
sz
);
return
false
;
return
false
;
}
}
if
(
backtrace
->
Read
(
addr
,
build_id_data
,
nhdr
.
n_descsz
)
!=
nhdr
.
n_descsz
)
{
if
(
backtrace
->
Read
(
addr
,
build_id_data
,
nhdr
.
n_descsz
)
!=
nhdr
.
n_descsz
)
{
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment