Skip to content
Snippets Groups Projects
Commit 38e9f232 authored by Nick Kralevich's avatar Nick Kralevich
Browse files

getevent: O_RDWR -> O_RDONLY | O_CLOEXEC

No need to open the device read write. Just open it read-only.

This is a partial redo of
https://android-review.googlesource.com/c/platform/system/core/+/334583
which was reverted in
https://android-review.googlesource.com/c/platform/system/core/+/342483

Bug: 30861057
Test: ran getevent, saw correct output, played with device
Change-Id: I426efd68f39dcd97d3ee23c13ed1a9ed96cb4c2e
parent e58548e5
No related branches found
No related tags found
No related merge requests found
...@@ -321,7 +321,7 @@ static int open_device(const char *device, int print_flags) ...@@ -321,7 +321,7 @@ static int open_device(const char *device, int print_flags)
char idstr[80]; char idstr[80];
struct input_id id; struct input_id id;
fd = open(device, O_RDWR); fd = open(device, O_RDONLY | O_CLOEXEC);
if(fd < 0) { if(fd < 0) {
if(print_flags & PRINT_DEVICE_ERRORS) if(print_flags & PRINT_DEVICE_ERRORS)
fprintf(stderr, "could not open %s, %s\n", device, strerror(errno)); fprintf(stderr, "could not open %s, %s\n", device, strerror(errno));
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment