Skip to content
Snippets Groups Projects
  • Alex Klyubin's avatar
    f5446eb1
    Vendor domains must not use Binder · f5446eb1
    Alex Klyubin authored
    On PRODUCT_FULL_TREBLE devices, non-vendor domains (except vendor
    apps) are not permitted to use Binder. This commit thus:
    * groups non-vendor domains using the new "coredomain" attribute,
    * adds neverallow rules restricting Binder use to coredomain and
      appdomain only, and
    * temporarily exempts the domains which are currently violating this
      rule from this restriction. These domains are grouped using the new
      "binder_in_vendor_violators" attribute. The attribute is needed
      because the types corresponding to violators are not exposed to the
      public policy where the neverallow rules are.
    
    Test: mmm system/sepolicy
    Test: Device boots, no new denials
    Test: In Chrome, navigate to ip6.me, play a YouTube video
    Test: YouTube: play a video
    Test: Netflix: play a movie
    Test: Google Camera: take a photo, take an HDR+ photo, record video with
          sound, record slow motion video with sound. Confirm videos play
          back fine and with sound.
    Bug: 35870313
    Change-Id: I0cd1a80b60bcbde358ce0f7a47b90f4435a45c95
    f5446eb1
    History
    Vendor domains must not use Binder
    Alex Klyubin authored
    On PRODUCT_FULL_TREBLE devices, non-vendor domains (except vendor
    apps) are not permitted to use Binder. This commit thus:
    * groups non-vendor domains using the new "coredomain" attribute,
    * adds neverallow rules restricting Binder use to coredomain and
      appdomain only, and
    * temporarily exempts the domains which are currently violating this
      rule from this restriction. These domains are grouped using the new
      "binder_in_vendor_violators" attribute. The attribute is needed
      because the types corresponding to violators are not exposed to the
      public policy where the neverallow rules are.
    
    Test: mmm system/sepolicy
    Test: Device boots, no new denials
    Test: In Chrome, navigate to ip6.me, play a YouTube video
    Test: YouTube: play a video
    Test: Netflix: play a movie
    Test: Google Camera: take a photo, take an HDR+ photo, record video with
          sound, record slow motion video with sound. Confirm videos play
          back fine and with sound.
    Bug: 35870313
    Change-Id: I0cd1a80b60bcbde358ce0f7a47b90f4435a45c95
blkid_untrusted.te 1.07 KiB
# blkid for untrusted block devices

typeattribute blkid_untrusted coredomain;

# Allowed read-only access to vold block devices to extract UUID/label
allow blkid_untrusted block_device:dir search;
allow blkid_untrusted vold_device:blk_file r_file_perms;

# Allow stdin/out back to vold
allow blkid_untrusted vold:fd use;
allow blkid_untrusted vold:fifo_file { read write getattr };

# For blkid launched through popen()
allow blkid_untrusted blkid_exec:file rx_file_perms;

###
### neverallow rules
###

# Untrusted blkid should never be run on block devices holding sensitive data
neverallow blkid_untrusted {
  boot_block_device
  frp_block_device
  metadata_block_device
  recovery_block_device
  root_block_device
  swap_block_device
  system_block_device
  userdata_block_device
  cache_block_device
  dm_device
}:blk_file no_rw_file_perms;

# Only allow entry from vold via blkid binary
neverallow { domain -vold } blkid_untrusted:process transition;
neverallow * blkid_untrusted:process dyntransition;
neverallow blkid_untrusted { file_type fs_type -blkid_exec -shell_exec }:file entrypoint;