Skip to content
Snippets Groups Projects
Commit cedee697 authored by Stephen Smalley's avatar Stephen Smalley
Browse files

Fix fsck-related denials with encrypted userdata.


Allow error reporting via the pty supplied by init.
Allow vold to invoke fsck for checking volumes.

Addresses denials such as:
avc:  denied  { ioctl } for  pid=133 comm="e2fsck" path="/dev/pts/0" dev="devpts" ino=3 scontext=u:r:fsck:s0 tcontext=u:object_r:devpts:s0 tclass=chr_file

avc: denied { execute } for pid=201 comm="vold" name="e2fsck" dev="mmcblk0p25" ino=98 scontext=u:r:vold:s0 tcontext=u:object_r:fsck_exec:s0 tclass=file

These denials show up if you have encrypted userdata.

Change-Id: Idc8e6f83a0751f17cde0ee5e4b1fbd6efe164e4c
Signed-off-by: default avatarStephen Smalley <sds@tycho.nsa.gov>
parent 92dfa31f
No related branches found
No related tags found
No related merge requests found
...@@ -10,7 +10,7 @@ init_daemon_domain(fsck) ...@@ -10,7 +10,7 @@ init_daemon_domain(fsck)
allow fsck tmpfs:chr_file { read write ioctl }; allow fsck tmpfs:chr_file { read write ioctl };
# Inherit and use pty created by android_fork_execvp_ext(). # Inherit and use pty created by android_fork_execvp_ext().
allow fsck devpts:chr_file { read write }; allow fsck devpts:chr_file { read write ioctl };
# Run e2fsck on block devices. # Run e2fsck on block devices.
# TODO: Assign userdata and cache block device types to the corresponding # TODO: Assign userdata and cache block device types to the corresponding
......
...@@ -38,6 +38,9 @@ allow vold sysfs:file rw_file_perms; ...@@ -38,6 +38,9 @@ allow vold sysfs:file rw_file_perms;
write_klog(vold) write_klog(vold)
# Run fsck.
allow vold fsck_exec:file rx_file_perms;
# Log fsck results # Log fsck results
allow vold fscklogs:dir rw_dir_perms; allow vold fscklogs:dir rw_dir_perms;
allow vold fscklogs:file create_file_perms; allow vold fscklogs:file create_file_perms;
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment