Skip to content
Snippets Groups Projects
  1. Apr 30, 2016
  2. Apr 28, 2016
    • Mihai Serban's avatar
      Allow ueventd to relabel block devices · 87c11478
      Mihai Serban authored
      
      There is a race in ueventd's coldboot procedure that permits creation
      of device block nodes before platform devices are registered. In this case
      the device node links used to compute the SELinux context are not known
      and the node is created under the generic context: u:object_r:block_device:s0.
      
      Ueventd has been patched to relabel the nodes on subsequent add events but
      it needs permissions to be allowed to do it.
      
      BUG=28388946
      
      Signed-off-by: default avatarMihai Serban <mihai.serban@intel.com>
      
      (cherry picked from commit d41ad551)
      
      Change-Id: I26838a3a9bc19b341e7176e5dc614827232014bf
      87c11478
    • Nick Kralevich's avatar
      Add no_x_file_perm to property related files. · ea0c294c
      Nick Kralevich authored
      It doesn't ever make sense to attempt to load executable code
      from these files. Add a neverallow rule (compile time assertion and
      CTS test).
      
      Bug: 27882507
      
      (cherry picked from commit 50ba6318)
      
      Change-Id: Ifab6e46a077a87629b4d3c7ada1050f2ab6931d5
      ea0c294c
    • Nick Kralevich's avatar
      Disallow /misc access except for a few domains. · 24a7f167
      Nick Kralevich authored
      The misc_block_device partition is intended for the exclusive
      use of the OTA system, and components related to the OTA system.
      Disallow it's use by anyone else on user builds. On userdebug/eng
      builds, allow any domain to use this, since this appears to be used
      for testing purposes.
      
      Bug: 26470876
      
      (cherry picked from commit 2c7a5f26)
      
      Change-Id: I40c80fa62651a0135e1f07a5e07d2ef65ba04139
      24a7f167
  3. Apr 27, 2016
  4. Apr 26, 2016
    • Jeff Vander Stoep's avatar
      Whitelist additional unix socket ioctl · 81b7675e
      Jeff Vander Stoep authored
      TIOCGWINSZ = 0x00005413
      
      avc: denied { ioctl } for comm="ls" path="socket:[362628]" dev="sockfs" ino=362628 ioctlcmd=5413 scontext=u:r:shell:s0 tcontext=u:r:adbd:s0 tclass=unix_stream_socket permissive=0
      
      Bug: 28171804
      Change-Id: I460e2469730d0cd90d714f30803ef849317d4be7
      81b7675e
  5. Apr 24, 2016
    • Jeffrey Vander Stoep's avatar
    • Jeff Vander Stoep's avatar
      Re-introduce camera_device type · cc8a09f5
      Jeff Vander Stoep authored
      camera_device was previously removed in AOSP commit: b7aace2d
      "camera_device: remove type and add typealias" because the
      same domains required access to both without exception, meaning
      there was no benefit to distinguishing between the two. However,
      with the split up of mediaserver this is no longer the case and
      distinguishing between the camera and video  provides a legitimate
      security benefit. For example, the mediacodec domain requires access
      to the video_device for access to hardware accelerated codecs but does
      not require access to the camera.
      
      Bug: 28359909
      Change-Id: I8a4592722d8e6391c0e91b440914284b7245e232
      cc8a09f5
  6. Apr 23, 2016
  7. Apr 22, 2016
  8. Apr 21, 2016
  9. Apr 20, 2016
    • Christopher Tate's avatar
      Allow system_server to hard link its own files · d9b0a34a
      Christopher Tate authored
      Specifically, backup of wallpaper imagery needs to use hard links to
      achieve "real file" access to the large imagery files without rewriting
      the contents all the time just to stage for backup.  They can't be
      symlinks because the underlying backup mechanisms refuse to act on
      symbolic links for other security reasons.
      
      Bug 25727875
      
      Change-Id: Ic48fba3f94c92a4b16ced27a23646296acf8f3a5
      d9b0a34a
  10. Apr 19, 2016
    • mukesh agrawal's avatar
      allow system server to set log.tag.WifiHAL · e651f6f4
      mukesh agrawal authored
      On eng and userdebug builds (only), allow system server
      to change the value of log.tag.WifiHAL. WifiStateMachine
      will set this property to 'D' by default. If/when a user
      enables "Developer options -> Enable Wi-Fi Verbose Logging",
      WifiStateMachine change log.tag.WifiHAL to 'V'.
      
      BUG=27857554
      TEST=manual (see below)
      
      Test detail
      1. on user build:
         $ adb shell setprop log.tag.WifiHAL V
         $ adb shell getprop log.tag.WifiHAL
         <blank line>
         $ adb bugreport | grep log.tag.WifiHAL
         <11>[  141.918517] init: avc:  denied  { set } for property=log.tag.WifiHAL pid=4583 uid=2000 gid=2000 scontext=u:r:shell:s0 tcontext=u:object_r:wifi_log_prop:s0 tclass=property_service permissive=0
         <11>[  141.918566] init: sys_prop: permission denied uid:2000  name:log.tag.WifiHAL
      2. on userdebug build:
         $ adb shell getprop log.tag.WifiHAL
         $ <blank line>
         $ adb shell setprop log.tag.WifiHAL V
         $ adb shell getprop log.tag.WifiHAL
         V
      3. on userdebug build with modified WifiStateMachine:
         $ adb shell getprop log.tag.WifiHAL
         D
      
      Change-Id: I9cdd52a2b47a3dd1065262ea8c329130b7b044db
      e651f6f4
    • mukesh agrawal's avatar
      limit shell's access to log.* properties · 84cfde22
      mukesh agrawal authored
      Restrict the ability of the shell to set the log.*
      properties. Namely: only allow the shell to set
      such properities on eng and userdebug builds.
      
      The shell (and other domains) can continue to
      read log.* properties on all builds.
      
      While there: harmonize permissions for log.* and
      persist.log.tag. Doing so introduces two changes:
      - log.* is now writable from from |system_app|. This
        mirrors the behavior of persist.log.tag, which is
        writable to support "Developer options" ->
        "Logger buffer sizes" -> "Off".
        (Since this option is visible on user builds, the
        permission is enabled for all builds.)
      - persist.log.tag can now be set from |shell| on
        userdebug_or_eng().
      
      BUG=28221972
      TEST=manual (see below)
      
      Testing details
      - user build (log.tag)
        $ adb shell setprop log.tag.foo V
        $ adb shell getprop log.tag
        <blank line>
        $ adb bugreport | grep log.tag.foo
        [  146.525836] init: avc:  denied  { set } for property=log.tag.foo pid=4644 uid=2000 gid=2000 scontext=u:r:shell:s0 tcontext=u:object_r:log_prop:s0 tclass=property_service permissive=0
        [  146.525878] init: sys_prop: permission denied uid:2000  name:log.tag.foo
      - userdebug build (log.tag)
        $ adb shell getprop log.tag.foo
        <blank line>
        $ adb shell setprop log.tag.foo V
        $ adb shell getprop log.tag.foo
        V
      - user build (persist.log.tag)
        $ adb shell getprop | grep log.tag
        <no match>
        - Developer options -> Logger buffer sizes -> Off
        $ adb shell getprop | grep log.tag
        [persist.log.tag]: [Settings]
        [persist.log.tag.snet_event_log]: [I]
      
      Change-Id: Idf00e7a623723a7c46bf6d01e386aeca92b2ad75
      84cfde22
    • Lorenzo Colitti's avatar
    • Lorenzo Colitti's avatar
      Allow bugreports to dump the native netd service state. · f7bfd489
      Lorenzo Colitti authored
      Bug: 28251026
      Change-Id: I73dce178b873d45e703896f12c10325af2ade81d
      f7bfd489
    • Nick Kralevich's avatar
      drop watchdogd from CAP_SYS_RAWIO neverallow · af82243e
      Nick Kralevich authored
      Doesn't appear to be needed anymore.
      
      Change-Id: I7a1fcf4c17fa69c313daebb87c9b0bf654169ee0
      af82243e
  11. Apr 18, 2016
  12. Apr 16, 2016
  13. Apr 15, 2016
  14. Apr 14, 2016
  15. Apr 13, 2016
Loading