Skip to content
Snippets Groups Projects
  1. Sep 04, 2014
    • Nick Kralevich's avatar
      sdcardd: grant unmount · 5fc825c9
      Nick Kralevich authored
      If the sdcard daemon is restarted (crash or otherwise), one of the first
      things it attempts to do is umount the previously mounted /mnt/shell/emulated
      fuse filesystem, which is denied by SELinux with the following denial:
      
        sdcard  : type=1400 audit(0.0:6997): avc: denied { unmount } for scontext=u:r:sdcardd:s0 tcontext=u:object_r:fuse:s0 tclass=filesystem permissive=0
      
      Allow the operation.
      
      Steps to reproduce:
      
        1) adb shell into the device and su to root
        2) run "kill -9 [PID OF SDCARD]
      
      Expected:
      
        sdcard daemon successfully restarts without error message.
      
      Actual:
      
        SELinux denial above, plus attempts to mount a new filesystem
        on top of the existing filesystem.
      
      (cherrypicked from commit abfd427a)
      
      Bug: 17383009
      Change-Id: I386bfc98e2b5b32b1d11408f7cfbd6e3c1af68f4
      5fc825c9
  2. Sep 02, 2014
  3. Sep 01, 2014
    • Mark Salyzyn's avatar
      logd: permit app access to clear logs · 60f0be84
      Mark Salyzyn authored
      I/auditd(19949): type=1400 audit(0.0:71): avc:  denied  { write } for  comm="logcat" name="logd" dev="tmpfs" ino=5924 scontext=u:r:untrusted_app:s0 tcontext=u:object_r:logd_socket:s0 tclass=sock_file
      
      Bug: 17323719
      Change-Id: Id8399195196ffad884eef98030d544c68ed0596f
      60f0be84
  4. Aug 29, 2014
  5. Aug 27, 2014
    • Nick Kralevich's avatar
      support kernel writes to external SDcards · 4c6b1350
      Nick Kralevich authored
      The kernel, when it creates a loop block device, starts a new
      kernel thread "loop0" (drivers/block/loop.c). This kernel thread,
      which performs writes on behalf of other processes, needs read/write
      privileges to the sdcard. Allow it.
      
      Steps to reproduce:
      0) Get device with external, removable sdcard
      1) Run: "adb install -s foo.apk"
      
      Expected:
      
        APK installs successfully.
      
      Actual:
      
        APK fails to install. Error message:
      
          Vold  E  Failed to write superblock (I/O error)
          loop0  W  type=1400 audit(0.0:3123): avc: denied { read } for path="/mnt/secure/asec/smdl1645334795.tmp.asec" dev="mmcblk1p1" ino=528 scontext=u:r:kernel:s0 tcontext=u:object_r:vfat:s0 tclass=file permissive=0
          PackageHelper  E  Failed to create secure container smdl1645334795.tmp
          DefContainer  E  Failed to create container smdl1645334795.tmp
      
      Bug: 17158723
      Change-Id: I4aa86e372cc55348f6b8becfa17bd4da583925d4
      4c6b1350
  6. Aug 25, 2014
    • Nick Kralevich's avatar
      remove appdomain's ability to examine all of /proc · 0d3f7ddc
      Nick Kralevich authored
      Remove the CTS specific rule which allows appdomain processes
      to view /proc entries for the rest of the system. With this change,
      an SELinux domain will only be able to view it's own /proc
      entries, e.g. untrusted_app can only view /proc entries for other
      untrusted_app, system_app can only view /proc entries for other
      system_apps, etc.
      
      /proc contains sensitive information, and we want to avoid
      leaking this information between app security domains.
      
      Bug: 17254920
      Change-Id: I59da37dde00107a5ab123df3b79a84afa855339f
      0d3f7ddc
    • Nick Kralevich's avatar
  7. Aug 22, 2014
  8. Aug 21, 2014
    • Nick Kralevich's avatar
      tighten up neverallow rules for init binder operations · 65feafce
      Nick Kralevich authored
      Init never uses binder, so allowing binder related operations
      for init never makes sense. Disallow all binder opertions for
      init.
      
      This change expands on commit a730e50b,
      disallowing any init binder operation, not just call operations, which
      may be accidentally added by blindly running audit2allow.
      
      Change-Id: I12547a75cf68517d54784873846bdadcb60c5112
      65feafce
  9. Aug 19, 2014
    • dcashman's avatar
      Allow debuggerd read access to shared_relro files. · cd10eb95
      dcashman authored
      Addresses the following denial when debuggerd attempts to stat Webview mmap'd
      shared relro files on process crash.  Full read permissions may not be necessary:
      
      W/debuggerd(  185): type=1400 audit(0.0:97): avc: denied { search } for name="shared_relro" dev="mmcblk0p28" ino=618955 scontext=u:r:debuggerd:s0 tcontext=u:object_r:shared_relro_file:s0 tclass=dir
      
      Bug: 17101854
      Change-Id: I11eea85668ba033c554e5aab99b70a454fb75164
      cd10eb95
  10. Aug 15, 2014
  11. Aug 06, 2014
  12. Aug 07, 2014
    • dcashman's avatar
      Allow untrusted_app access to temporary apk files. · fbbe9e91
      dcashman authored
      Before actual installation, apks are put in a staging area where they are
      scanned by a verifier before completing the install flow.  This verifier runs as
      a priv-app, which is in the untrusted_app domain.  Allow untrusted_app
      read-access to these files.
      
      Bug: 16515815
      
      Change-Id: Ifedc12a33b1f53b62f45013e7b253dbc79b02a4e
      fbbe9e91
  13. Aug 06, 2014
  14. Aug 05, 2014
  15. Aug 01, 2014
    • Stephen Smalley's avatar
      Allow dumpstate to dump backtraces of certain native processes. · 77a236c9
      Stephen Smalley authored
      
      The list of processes comes from frameworks/native/cmds/dumpstate/utils.c.
      dumpstate calls dump_backtrace_to_file() for each such process, which
      asks debuggerd to dump the backtrace.
      
      Resolves denials such as:
       avc:  denied  { dump_backtrace } for  scontext=u:r:dumpstate:s0 tcontext=u:r:surfaceflinger:s0 tclass=debuggerd
       avc:  denied  { dump_backtrace } for  scontext=u:r:dumpstate:s0 tcontext=u:r:drmserver:s0 tclass=debuggerd
       avc:  denied  { dump_backtrace } for  scontext=u:r:dumpstate:s0 tcontext=u:r:mediaserver:s0 tclass=debuggerd
       avc:  denied  { dump_backtrace } for  scontext=u:r:dumpstate:s0 tcontext=u:r:sdcardd:s0 tclass=debuggerd
      
      Change-Id: Idbfb0fef0aac138073b7217b7dbad826a1193098
      Signed-off-by: default avatarStephen Smalley <sds@tycho.nsa.gov>
      77a236c9
    • dcashman's avatar
      3fe1bcbb
  16. Jul 29, 2014
    • Stephen Smalley's avatar
      Fix neverallow rules to eliminate CTS SELinuxTest warnings. · 21ada26d
      Stephen Smalley authored
      
      Fix two neverallow rules that yield Invalid SELinux context
      warnings from the CTS SELinuxTest.
      
      For transitions from app domains, we only need to check
      { domain -appdomain } (i.e. domains other than app domains),
      not ~appdomain (i.e. all types other than app domains).  Otherwise
      SELinuxTest tries to generate contexts with the r role and
      non-domain types for testing since the target class is process,
      and such contexts are invalid.
      
      For keeping file_type and fs_type exclusive, we only need to
      check associate permission, not all filesystem permissions, as
      only associate takes a file type as the source context.  Otherwise
      SELinuxTest tries to generate contexts with the r role and
      non-domain types for testing filesystem permissions other than
      associate, since the source of such checks is normally a process
      context.
      
      Change-Id: I6c2f63f4786d75294a6938613ba14b64212fc802
      Signed-off-by: default avatarStephen Smalley <sds@tycho.nsa.gov>
      21ada26d
    • dcashman's avatar
      Generate selinux_policy.xml as part of CTS build. · 704741a5
      dcashman authored
      Bug: 16563899
      Bug: 14251916
      Change-Id: Id3172b73f10186ba361caf6b7333e5d2a0648475
      704741a5
  17. Jul 28, 2014
  18. Jul 25, 2014
    • Nick Kralevich's avatar
      Allow sdcardd to read /data/.layout_version · 1a61fb3b
      Nick Kralevich authored
      As described in the system/core commit with the same Change-Id,
      there's a race condition between installd and sdcard when it
      comes to accessing /data/media. Resolve the race by checking
      /data/.layout_version to make sure the filesystem has been upgraded.
      
      Maybe indirectly fixes the following SELinux denial:
      
        sdcard  : type=1400 audit(0.0:3): avc: denied { write } for name="media" dev="mmcblk0p17" ino=102753 scontext=u:r:sdcardd:s0 tcontext=u:object_r:system_data_file:s0 tclass=dir
      
      (cherrypicked from commit 792d8650)
      
      Bug: 16329437
      Change-Id: I5e164f08009c1036469f8734ec07cbae9c5e262b
      1a61fb3b
  19. Jul 24, 2014
  20. Jul 23, 2014
  21. Jul 24, 2014
  22. Jul 23, 2014
  23. Jul 22, 2014
  24. Jul 21, 2014
  25. Jul 17, 2014
  26. Jul 18, 2014
  27. Jul 17, 2014
  28. Jul 16, 2014
Loading