Skip to content
Snippets Groups Projects
  1. Mar 09, 2015
    • dcashman's avatar
      Only allow system_server to send commands to zygote. · 8f81dcad
      dcashman authored
      Add neverallow rules to ensure that zygote commands are only taken from
      system_server.
      
      Also remove the zygote policy class which was removed as an object manager in
      commit: ccb3424639821b5ef85264bc5836451590e8ade7
      
      Bug: 19624279
      
      Change-Id: I1c925d7facf19b3953b5deb85d992415344c4c9f
      8f81dcad
    • Nick Kralevich's avatar
      system_server: allow handling app generated unix_stream_sockets · 0560e75e
      Nick Kralevich authored
      Allow system server to handle already open app unix_stream_sockets.
      This is needed to support system_server receiving a socket
      created using socketpair(AF_UNIX, SOCK_STREAM) and
      socketpair(AF_UNIX, SOCK_SEQPACKET). Needed for future Android
      functionality.
      
      Addresses the following denial:
      
        type=1400 audit(0.0:9): avc: denied { read write } for path="socket:[14911]" dev="sockfs" ino=14911 scontext=u:r:system_server:s0 tcontext=u:r:platform_app:s0:c512,c768 tclass=unix_stream_socket permissive=0
      
      Bug: 19648474
      Change-Id: I4644e318aa74ada4d98b7f49a41d13a9b9584f39
      0560e75e
  2. Mar 07, 2015
  3. Mar 06, 2015
    • dcashman's avatar
      Record observed bluetooth service access. · bb3cef44
      dcashman authored
      Bug: 18106000
      Change-Id: I80b574f73d53439dd710ccdb8f05cc2f9e9a10b4
      bb3cef44
    • Nick Kralevich's avatar
      allow untrusted_app read /data/anr/traces.txt · 1aafc4c7
      Nick Kralevich authored
      The GMS core feedback agent runs as untrusted_app, and needs
      the ability to read /data/anr/traces.txt to report ANR information.
      
      Allow all untrusted_apps to read /data/anr/traces.txt so that GMS core
      can access it.
      
      Longer term, we need to move GMS core into it's own domain, but that's
      a longer term change.
      
      Addresses the following denial:
      
      W/ndroid.feedback(17825): type=1400 audit(0.0:68004): avc: denied { read } for name="traces.txt" dev="mmcblk0p28" ino=325762 scontext=u:r:untrusted_app:s0 tcontext=u:object_r:anr_data_file:s0 tclass=file
      
      (cherrypick from commit e2547c3b)
      
      Bug: 18504118
      Bug: 18340553
      Change-Id: I8b472b6ab7dfe2a73154033e0a088b8e26396fa8
      1aafc4c7
  4. Mar 05, 2015
    • Nick Kralevich's avatar
      move untrusted_app statement to the correct file. · 8be3e779
      Nick Kralevich authored
      Change-Id: I5ae9606023ef7f3489f44e6657766e922160c470
      8be3e779
    • Nick Kralevich's avatar
      ee66ba8c
    • Nick Kralevich's avatar
      recovery: remove auditallow for exec_type:dir writes · b76966d6
      Nick Kralevich authored
      With the move to block based OTAs, we're never going to fix
      this bug. Remove the auditallow statement to avoid SELinux log
      spam.
      
      Bug: 15575013
      Change-Id: I7864e87202b1b70020a8bdf3ef327a2cf4b6bfbd
      b76966d6
    • Nick Kralevich's avatar
      Eliminate CAP_SYS_MODULE from system_server · 92b10ddb
      Nick Kralevich authored
      Right now, the system_server has the CAP_SYS_MODULE capability.  This allows the
      system server to install kernel modules.  Effectively, system_server is one
      kernel module load away from full root access.
      
      Most devices don't need this capability. Remove this capability from
      the core SELinux policy. For devices which require this capability,
      they can add it to their device-specific SELinux policy without making
      any framework code changes.
      
      In particular, most Nexus devices ship with monolithic kernels, so this
      capability isn't needed on those devices.
      
      Bug: 7118228
      Change-Id: I7f96cc61da8b2476f45ba9570762145778d68cb3
      92b10ddb
    • Nick Kralevich's avatar
      update isolated_app service_manager rules · 75f34dc3
      Nick Kralevich authored
      isolated apps should only be able to access 2 services.
      Remove access permissions for services inappropriately added,
      and add a neverallow rule to prevent regressions.
      
      Change-Id: I2783465c4a22507849b2a64894fb76690a27bc01
      75f34dc3
    • Sami Tolvanen's avatar
      Merge "Allow init to set up dm-verity" · 723e31ef
      Sami Tolvanen authored
      723e31ef
    • Sami Tolvanen's avatar
      Allow init to set up dm-verity · 35f537c7
      Sami Tolvanen authored
      Allow init to
      
       1. Access device mapper to set up dm-verity devices
      
          avc:  denied  { write } for  pid=156 comm="init" name="device-mapper" dev="tmpfs" ino=6229 scontext=u:r:init:s0 tcontext=u:object_r:dm_device:s0 tclass=chr_file permissive=0
      
       2. Access the metadata partition to load and store dm-verity state
      
          avc:  denied  { write } for  pid=1 comm="init" name="mmcblk0p25" dev="tmpfs" ino=6408 scontext=u:r:init:s0 tcontext=u:object_r:metadata_block_device:s0 tclass=blk_file permissive=0
      
       3. Read /sys/fs/pstore/console-ramoops to detect restarts triggered
          by dm-verity
      
          avc:  denied  { getattr } for  pid=1 comm="init" path="/sys/fs/pstore/console-ramoops" dev="pstore" ino=9911 scontext=u:r:init:s0 tcontext=u:object_r:pstorefs:s0 tclass=file permissive=0
      
      These can be reproduced using the following steps:
      
       1. Add fs_mgr flag verify to the system partition in fstab
      
       2. Add a device specific init.rc handler for the init action that
          calls the built-in command verity_load_state.
      
      Change-Id: Id8790ae4b204ca66e671eefd3820d649f1d1e7ba
      35f537c7
    • dcashman's avatar
      Revert "Drop special handling of app_data_file in mls constraints." · 60cfe79f
      dcashman authored
      This reverts commit 27042f6d.
      
      Managed profiles are represented by new android users which have the ability to
      communicate across profiles as governed by an IntentFilter provisioned by the
      DevicePolicyManager.  This communication includes reading and writing content
      URIs, which is currently obstructed by the mls separation between an owning user
      and its managed profile.
      
      Bug: 19444116
      Bug: 19525465
      Bug: 19540297
      Bug: 19592525
      Change-Id: Id9a97f24081902bceab5a96ddffd9276d751775b
      60cfe79f
  5. Mar 03, 2015
  6. Mar 02, 2015
  7. Feb 28, 2015
    • Nick Kralevich's avatar
      Delete unconfined domain · f435a8e5
      Nick Kralevich authored
      No longer used.  :-)
      
      Change-Id: I687cc36404e8ad8b899b6e76b1de7ee8c5392e07
      f435a8e5
    • Nick Kralevich's avatar
      init: drop read_policy permission · 07e73489
      Nick Kralevich authored
      As of https://android-review.googlesource.com/127858 ,
      open(O_RDONLY) is no longer used for chmod. It's no
      longer necessary to allow init to read the SELinux policy.
      
      Change-Id: I691dd220827a01a8d7a9955b62f8aca50eb25447
      07e73489
    • Stephen Smalley's avatar
      init: remove permissive_or_unconfined() · ed532c06
      Stephen Smalley authored
      
      Bug: 19050686
      Change-Id: Ie41c3e4d5aaeb43577ba85a4768a5fdbdd665efb
      Signed-off-by: default avatarStephen Smalley <sds@tycho.nsa.gov>
      ed532c06
    • Nick Kralevich's avatar
      Create boot_block_device and allow install_recovery read access · a8e073cd
      Nick Kralevich authored
      The install_recovery script creates a new recovery image based
      off of the boot image plus a patch on /system. We need to allow
      read access to the boot image to allow the patching to succeed,
      otherwise OTAs are broken.
      
      Addresses the following denial:
      
        type=1400 audit(9109404.519:6): avc: denied { read } for pid=341 comm="applypatch" name="mmcblk0p37" dev="tmpfs" ino=9186 scontext=u:r:install_recovery:s0 tcontext=u:object_r:block_device:s0 tclass=blk_file permissive=0
      
      TODO: Add device specific labels for the boot image.
      
      Bug: 19534538
      Change-Id: Ic811ec03e235df3b1bfca9b0a65e23307cd968aa
      a8e073cd
    • dcashman's avatar
      Remove read access from mls constraints. · e8f95b36
      dcashman authored
      Addresses the following denial encountered when sharing photos between personal
      and managed profiles:
      
      Binder_5: type=1400 audit(0.0:236): avc: denied { read } for path="/data/data/com.google.android.apps.plus/cache/media/3/3bbca5f1bcfa7f1-a-nw" dev="dm-0" ino=467800 scontext=u:r:untrusted_app:s0:c529,c768 tcontext=u:object_r:app_data_file:s0:c512,c768 tclass=file permissive=0
      
      Bug: 19540297
      Change-Id: If51108ec5820ca40e066d5ca3e527c7a0f03eca5
      e8f95b36
  8. Feb 27, 2015
    • Nick Kralevich's avatar
      allow init tmpfs:dir relabelfrom · 543faccc
      Nick Kralevich authored
      When encrypting a device, or when an encrypted device boots,
      a tmpfs is mounted in place of /data, so that a pseudo filesystem
      exists to start system_server and related components. SELinux labels
      need to be applied to that tmpfs /data so the system boots
      properly.
      
      Allow init to relabel a tmpfs /data.
      
      Addresses the following denial:
      
      [    6.294896] type=1400 audit(29413651.850:4): avc:  denied  { relabelfrom } for  pid=1 comm="init" name="/" dev="tmpfs" ino=6360 scontext=u:r:init:s0 tcontext=u:object_r:tmpfs:s0 tclass=dir
      
      Steps to reproduce:
        1) Go into Settings > Security > Encrypt Phone
        2) Encrypt phone
        3) See denial
        4) reboot phone
        5) See denial on boot
      
      Bug: 19050686
      Change-Id: Ie57864fe1079d9164d5cfea44683a97498598e41
      543faccc
    • Sami Tolvanen's avatar
    • Sami Tolvanen's avatar
      Revert "Allow ueventd to set verity.* properties" · 9f0682dc
      Sami Tolvanen authored
      Updating properties from ueventd may lead to deadlocks with init in rare
      cases, which makes these changes unnecessary after all.
      
      This reverts commit 47cd53a5.
      
      Change-Id: I87bdd66f0ec025eb3a9ea17574a67e908f3de6da
      9f0682dc
    • Nick Kralevich's avatar
      006ede39
    • Nick Kralevich's avatar
      Merge "kernel.te: fix MTP sync" · a3364dfd
      Nick Kralevich authored
      a3364dfd
    • Nick Kralevich's avatar
      kernel.te: fix MTP sync · 1025d138
      Nick Kralevich authored
      STEPS TO REPRODUCE:
        1. Connect the device to Mac.
        2. Switch to AFT.
        3. Now AFT on Mac will show the device contents.
        4. Now drag and drop the file to device and observe.
      
      EXPECTED RESULTS:
        Should able to copy.
      
      OBSERVED RESULTS:
        Showing can not copy file and on clicking ok,
        It shows device storage can not connect and close the AFT.
      
      Addresses the following denial:
      
        W kworker/u:11: type=1400 audit(0.0:729): avc: denied { use } for path="/storage/emulated/0/Download/song2.mp3" dev="fuse" ino=143 scontext=u:r:kernel:s0 tcontext=u:r:untrusted_app:s0:c512,c768 tclass=fd
        12310 12530 E MtpRequestPacket: Malformed MTP request packet
      
      ps -Z entry:
        u:r:untrusted_app:s0:c512,c768 u0_a6     12310 203   android.process.media
      
      Bug: 15835289
      Change-Id: I47b653507f8d4089b31254c19f44706077e2e96a
      1025d138
    • Nick Kralevich's avatar
      dontaudit clatd self:capability ipc_lock · b4c4424c
      Nick Kralevich authored
      clatd calls mmap(MAP_LOCKED) with a 1M buffer. MAP_LOCKED first checks
      capable(CAP_IPC_LOCK), and then checks to see the requested amount is
      under RLIMIT_MEMLOCK. The latter check succeeds. As a result, clatd
      does not need CAP_IPC_LOCK, so we suppress any denials we see
      from clatd asking for this capability.
      See https://android-review.googlesource.com/127940
      
      Suppresses the following denial:
        type=1400 audit(1424916750.163:7): avc: denied { ipc_lock } for pid=3458 comm="clatd" capability=14 scontext=u:r:clatd:s0 tcontext=u:r:clatd:s0 tclass=capability
      
      Change-Id: Ica108f66010dfc6a5431efa0b4e58f6a784672d1
      b4c4424c
  9. Feb 26, 2015
  10. Feb 25, 2015
    • Nick Kralevich's avatar
      allow kernel to use vold file descriptors · 9fe810b7
      Nick Kralevich authored
      Vold opens ASEC containsers on the sdcard, or OBB files from app's
      home directories, both of which are supplied by vold. We need to
      allow kernel threads to access those file descriptors.
      
      Addresses the following denial:
      
        loop0   : type=1400 audit(0.0:28): avc: denied { use } for path="/mnt/secure/asec/smdl1159865753.tmp.asec" dev="mmcblk1" ino=19 scontext=u:r:kernel:s0 tcontext=u:r:vold:s0 tclass=fd permissive=0
      
      Bug: 19516891
      Change-Id: I5a3607b48f5e0e504e4b3fcaec19152c3784f49d
      9fe810b7
    • Mohamad Ayyash's avatar
      fs_use: Enabled loading security xattrs for squashfs · ab4be88e
      Mohamad Ayyash authored
      
      Change-Id: Icfa4b2cac6a960ef47e928308e4c6c9bd797d180
      Signed-off-by: default avatarMohamad Ayyash <mkayyash@google.com>
      ab4be88e
    • Nick Kralevich's avatar
      Revert /proc/net related changes · 5cf3994d
      Nick Kralevich authored
      Revert the tightening of /proc/net access. These changes
      are causing a lot of denials, and I want additional time to
      figure out a better solution.
      
      Addresses the following denials (and many more):
      
        avc: denied { read } for comm="SyncAdapterThre" name="stats" dev="proc" ino=X scontext=u:r:untrusted_app:s0:c512,c768 tcontext=u:object_r:proc_net:s0 tclass=file
        avc: denied { read } for comm="facebook.katana" name="iface_stat_fmt" dev="proc" ino=X scontext=u:r:untrusted_app:s0:c512,c768 tcontext=u:object_r:proc_net:s0 tclass=file
        avc: denied { read } for comm="IntentService[C" name="if_inet6" dev="proc" ino=X scontext=u:r:untrusted_app:s0:c512,c768 tcontext=u:object_r:proc_net:s0 tclass=file
        avc: denied { read } for comm="dumpstate" name="iface_stat_all" dev="proc" ino=X scontext=u:r:dumpstate:s0 tcontext=u:object_r:proc_net:s0 tclass=file
      
      This reverts commit 0f0324cc
      and commit 99940d1a
      
      Bug: 9496886
      Bug: 19034637
      Change-Id: I436a6e3638ac9ed49afbee214e752fe2b0112868
      5cf3994d
    • Nick Kralevich's avatar
      su: don't auditallow service_manager for su · 28ddd104
      Nick Kralevich authored
      Addresses the following auditallow messages:
      
        avc: granted { find } for service=accessibility scontext=u:r:su:s0 tcontext=u:object_r:accessibility_service:s0 tclass=service_manager
        avc: granted { find } for service=activity scontext=u:r:su:s0 tcontext=u:object_r:activity_service:s0 tclass=service_manager
        avc: granted { find } for service=package scontext=u:r:su:s0 tcontext=u:object_r:package_service:s0 tclass=service_manager
        avc: granted { find } for service=user scontext=u:r:su:s0 tcontext=u:object_r:user_service:s0 tclass=service_manager
        avc: granted { find } for service=window scontext=u:r:su:s0 tcontext=u:object_r:window_service:s0 tclass=service_manager
      
      Change-Id: Ie58ad3347e9ef1aacd39670cfec7d095875e237b
      28ddd104
    • Nick Kralevich's avatar
      kernel: make kernel an mlstrustedsubject · 4308ce8c
      Nick Kralevich authored
      Addresses post-review comment in
      https://android-review.googlesource.com/130620
      
      Change-Id: I427ba99d63724eb526d41da47b95cc0ae038acdd
      4308ce8c
  11. Feb 24, 2015
Loading