Skip to content
Snippets Groups Projects
  1. Mar 26, 2015
  2. Mar 25, 2015
  3. Mar 24, 2015
  4. Mar 20, 2015
    • Nick Kralevich's avatar
      Don't run fsck on certain block devices · e491020f
      Nick Kralevich authored
      Make sure we're not running fsck on block devices where it
      doesn't make any sense. In particular, we should not be running
      fsck on /system since it's mounted read-only, and any modification
      to that block device will screw up verified boot.
      
      Change-Id: Ic8dd4b0519b423bb5ceb814daeebef06a8f065b4
      e491020f
  5. Mar 19, 2015
  6. Mar 17, 2015
  7. Mar 16, 2015
    • dcashman's avatar
      Fix sepolicy-analyze libc++.so loading issue w/CTS. · 3812cf58
      dcashman authored
      Addresses the following error when running CTS on master:
      junit.framework.AssertionFailedError: The following errors were encountered when validating the SELinuxneverallow rule:
      neverallow { appdomain -bluetooth } self:capability *;
      /tmp/SELinuxHostTest5593810182495331783.tmp: error while loading shared libraries: libc++.so: cannot open shared object file: No such file or directory
      
      Also indicate that none of the sepolicy tools need c++ std lib.
      
      Bug: 19617220
      
      Change-Id: I713b3cbd1220655413d399c7cd2b0b50459a5485
      3812cf58
    • Stephen Smalley's avatar
      Allow shell to read /proc/pid/attr/current for ps -Z. · d5892b4c
      Stephen Smalley authored
      
      Needed since Iff1e601e1268d4d77f64788d733789a2d2cd18cc removed it
      from appdomain.
      
      Change-Id: I9fc08b525b9868f0fb703b99b0c0c17ca8b656f9
      Signed-off-by: default avatarStephen Smalley <sds@tycho.nsa.gov>
      d5892b4c
    • Stephen Smalley's avatar
      Remove ability to read all /proc/pid/attr/current entries. · 2cba1ee1
      Stephen Smalley authored
      
      This was rendered obsolete when SELinuxDomainTest was ported
      to SELinuxHostTest and only makes sense if allowing search
      to domain:dir and { open read } to domain:file in order to
      open the /proc/pid/attr/current files in the first place.
      SELinux applies a further :process getattr check when
      reading any of the /proc/pid/attr/* files for any process
      other than self, which is no longer needed by app domains to
      pass CTS.
      
      Change-Id: Iff1e601e1268d4d77f64788d733789a2d2cd18cc
      Signed-off-by: default avatarStephen Smalley <sds@tycho.nsa.gov>
      2cba1ee1
  8. Mar 14, 2015
  9. Mar 13, 2015
    • Stephen Smalley's avatar
      sepolicy: Clean up mls constraints. · 025b7df2
      Stephen Smalley authored
      
      Require equivalence for all write operations.  We were already
      doing this for app_data_file as a result of restricting open
      rather than read/write, so this makes the model consistent across
      all objects and operations.  It also addresses the scenario where
      we have mixed usage of levelFrom=all and levelFrom=user for
      different apps on the same device where the dominated-by (domby)
      relation may not be sufficiently restrictive.
      
      Drop the System V IPC constraints since System V IPC is never allowed
      by TE and thus these constraints are dead policy.
      
      Change-Id: Ic06a35030c086e3978c02d501c380889af8d21e0
      Signed-off-by: default avatarStephen Smalley <sds@tycho.nsa.gov>
      025b7df2
    • Stephen Smalley's avatar
      neverallow untrusted_app as a mlstrustedsubject. · eaece936
      Stephen Smalley authored
      
      Assigning mlstrustedsubject to untrusted_app would undermine
      the per-user isolation model being enforced via levelFrom=user
      in seapp_contexts and the mls constraints.  There is no direct
      way to specify a neverallow on attribute assignment, but this
      makes use of a particular property of the fork permission to
      prevent ever adding mlstrustedsubject to untrusted_app.
      
      A similar restriction for app_data_file and mlstrustedobject
      is also important for the same reason, but cannot be expressed
      as a neverallow.
      
      Change-Id: I5170cadc55cc614aef0cd5f6491de8f69a4fa2a0
      Signed-off-by: default avatarStephen Smalley <sds@tycho.nsa.gov>
      eaece936
    • Stephen Smalley's avatar
      Move allow rules before neverallow rules. · b8caf7fd
      Stephen Smalley authored
      
      There were a few instances where allow rules were appended
      after the neverallow rules stanza in the .te file.  Also
      there were some regular allow rules inserted into the CTS-specific
      rules section of app.te.  Just move the rules as appropriate.
      Should be no change in policy.
      
      Change-Id: Iec76f32d4b531d245bbf5dd9f621a71ff5c71f3e
      Signed-off-by: default avatarStephen Smalley <sds@tycho.nsa.gov>
      b8caf7fd
    • Stephen Smalley's avatar
      sepolicy-analyze: Add attribute command. · 0233cd80
      Stephen Smalley authored
      
      Add an attribute command to sepolicy-analyze for displaying the list
      of types associated with an attribute in a policy.  This is for use
      by CTS to check what domains and types are associated with certain
      attributes such as mlstrustedsubject and mlstrustedobject.
      
      Change-Id: Ie19361c02feb1ad14ce36862c6aace9e66c422bb
      Signed-off-by: default avatarStephen Smalley <sds@tycho.nsa.gov>
      0233cd80
    • Stephen Smalley's avatar
      sepolicy: Drop BOARD_SEPOLICY_IGNORE/REPLACE support. · b4f17069
      Stephen Smalley authored
      With changes I431c1ab22fc53749f623937154b9ec43469d9645 and
      Ia54aa263f2245c7090f4b9d9703130c19f11bd28, it is no longer
      legitimate to use BOARD_SEPOLICY_IGNORE or REPLACE with
      any of the *_contexts files since the CTS requires the AOSP
      entries to be present in the device files.
      
      Further, these changes render BOARD_SEPOLICY_IGNORE unusable for
      most policy files since all domains and types referenced within any
      of the AOSP *_contexts entries must be defined in the kernel policy, so
      you cannot use BOARD_SEPOLICY_IGNORE to exclude any .te file
      that defines a type referenced in any of those *_contexts files.
      There does not seem to be a significant need for such a facility,
      as AOSP policy is small and only domains and types used by most
      devices should be defined in external/sepolicy.
      
      BOARD_SEPOLICY_REPLACE is commonly misused to eliminate neverallow rules
      from AOSP policy, which will only lead to CTS failures, especially
      since change Iefe508df265f62efa92f8eb74fc65542d39e3e74 introduced neverallow
      checking on the entire policy via sepolicy-analyze.  The only remaining
      legitimate function of BOARD_SEPOLICY_REPLACE is to support overriding
      AOSP .te files with more restrictive rule sets.  However, the need for this
      facility has been significantly reduced by the fact that AOSP policy
      is now fully confined + enforcing for all domains, and further restrictions
      beyond AOSP carry a compatibility risk.
      
      Builders of custom policies and custom ROMs still have the freedom to
      apply patches on top of external/sepolicy to tighten rule sets (which are
      likely more maintainable than maintaining a completely separate copy of
      the file via BOARD_SEPOLICY_REPLACE) and/or of using their own separate
      policy build system as exemplified by
      https://bitbucket.org/quarksecurity/build-policies
      
      
      
      Change-Id: I2611e983f7cbfa15f9d45ec3ea301e94132b06fa
      Signed-off-by: default avatarStephen Smalley <sds@tycho.nsa.gov>
      b4f17069
    • Stephen Smalley's avatar
      Fix rules for general_property_contexts. · c9361731
      Stephen Smalley authored
      
      Failed to include base_rules.mk, so this target was not being built.
      
      Change-Id: I2414fa6c3e3e37c74f63c205e3694d1a811c956e
      Signed-off-by: default avatarStephen Smalley <sds@tycho.nsa.gov>
      c9361731
  10. Mar 12, 2015
  11. Mar 11, 2015
Loading