Skip to content
Snippets Groups Projects
  1. Oct 04, 2017
    • Jeff Vander Stoep's avatar
      vold: temporarily re-grant access to default proc label · aadf611e
      Jeff Vander Stoep authored
      On Marlin/Sailfish, StorageManager tests in CTS are exposing a bug
      where the /proc/<pid>/ns/mnt files for system_server are briefly
      mislabeled as "proc" instead of "system_server". Resulting in the
      tests failing. Temporarily re-granting access to the default label
      until the labeling issue can be tracked down.
      
      Repro steps:
      cts-tradefed run commandAndExit cts-dev -m CtsOsTestCases \
      -t android.os.storage.cts.StorageManagerTest
      
      Failures:
      
      android.os.storage.cts.StorageManagerTest#testOpenProxyFileDescriptor
      fail: java.lang.IllegalStateException: command '58 appfuse mount 10065
      959 0' failed with '400 58 Command failed'
      
      android.os.storage.cts.StorageManagerTest#testOpenProxyFileDescriptor_async
      fail: java.lang.IllegalStateException: command '59 appfuse mount 10065
      959 1' failed with '400 59 Command failed'
      
      android.os.storage.cts.StorageManagerTest#testOpenProxyFileDescriptor_error
      fail: java.lang.IllegalStateException: command '60 appfuse mount 10065
      959 2' failed with '400 60 Command failed'
      
      From the log:
      
      10-04 20:41:22.972   595   604 E vold    : Failed to open namespace for
      /proc/959/ns/mnt: Permission denied
      10-04 20:41:22.967   604   604 W vold    : type=1400 audit(0.0:90): avc:
      denied { read } for dev="proc" ino=4026534249 scontext=u:r:vold:s0
      tcontext=u:object_r:proc:s0 tclass=file permissive=0
      10-04 20:41:23.051   604   604 W vold    : type=1400 audit(0.0:91): avc:
      denied { read } for dev="proc" ino=4026534249 scontext=u:r:vold:s0
      tcontext=u:object_r:proc:s0 tclass=file permissive=0
      10-04 20:41:23.054   595   604 E vold    : Failed to open namespace for
      /proc/959/ns/mnt: Permission denied
      10-04 20:41:23.081   604   604 W vold    : type=1400 audit(0.0:92): avc:
      denied { read } for dev="proc" ino=4026534249 scontext=u:r:vold:s0
      tcontext=u:object_r:proc:s0 tclass=file permissive=0
      10-04 20:41:23.086   595   604 E vold    : Failed to open namespace for
      /proc/959/ns/mnt: Permission denied
      
      sailfish:/ # ps -AZ | grep 959
      u:r:system_server:s0           system         959   628 \
      4557136 251500 SyS_epoll_wait 70e6df822c S system_server
      
      The file labels appear to be correct when checked manually.
      
      sailfish:/ # ls -lZ /proc/959/ns/
      lrwxrwxrwx 1 system system u:r:system_server:s0 0 2017-10-04 17:19 mnt -> mnt:[4026534249]
      lrwxrwxrwx 1 system system u:r:system_server:s0 0 2017-10-04 20:55 net -> net:[4026531906]
      
      Bug: 67049235
      Test: cts-tradefed run commandAndExit cts-dev -m CtsOsTestCases \
          -t android.os.storage.cts.StorageManagerTes
      
      Change-Id: Id4d200856c02c023c6f516e3f3bfa060e100086c
      aadf611e
    • Treehugger Robot's avatar
      dbe09253
    • Treehugger Robot's avatar
      c9599b34
    • Jeff Vander Stoep's avatar
      Allow recovery to read /proc/cmdline · e629b7eb
      Jeff Vander Stoep authored
      avc:  denied  { read } for  pid=446 comm="recovery" name="cmdline"
      dev="proc" scontext=u:r:recovery:s0
      tcontext=u:object_r:proc_cmdline:s0 tclass=file
      
      Test: build
      Bug: 66497047
      Change-Id: I9f48db88bed0d6ac76fa2808a4913857230a5d4b
      e629b7eb
    • Jeff Vander Stoep's avatar
      Prepare python tests to be run in CTS · 3ca843a5
      Jeff Vander Stoep authored
      Bug: 37008075
      Test: build, all tests pass. Modify some attributes locally to
          cause tests to fail (verify that they are actually working).
      Change-Id: If9f9ece61dff835f38ef9c8a57f5a7baddbae5cd
      3ca843a5
    • Treehugger Robot's avatar
    • Tri Vo's avatar
    • Jeff Vander Stoep's avatar
      Move python sepolicy tests to embedded launcher · e9777e34
      Jeff Vander Stoep authored
      This is a necessary for enforcing these tests in CTS.
      
      Bug: 37008075
      Test: build
      Change-Id: I36b4ce71c26a0ba01cd0289fe363f0a9f7db1214
      (cherry picked from commit 8d614b3f)
      e9777e34
  2. Oct 03, 2017
  3. Oct 02, 2017
  4. Sep 29, 2017
  5. Sep 28, 2017
  6. Sep 27, 2017
    • Dan Cashman's avatar
      Fix build. · 7d1130f1
      Dan Cashman authored
      (This reverts internal commit: 82ca9c2e)
      Test: None.
      
      Merged-in: I97ffdd48b64ef5c35267387079204512a093a356
      Change-Id: I97ffdd48b64ef5c35267387079204512a093a356
      7d1130f1
    • Jeff Vander Stoep's avatar
      Allow system settings to read /proc/version · c975bd90
      Jeff Vander Stoep authored
      Used to display kernel version in settings app.
      
      avc: denied { read } for name="version" dev="proc"
      scontext=u:r:system_app:s0 tcontext=u:object_r:proc_version:s0
      tclass=file permissive=0
      
      Bug: 66985744
      Test: kernel version now displayed in settings app.
      Change-Id: I53f92f63362b900347fd393a40d70ccf5d220d30
      c975bd90
    • William Roberts's avatar
      nonplat_property_contexts: use fc_sort vs sort · 3949fe23
      William Roberts authored
      sort respects locale settings, so the value of LC_ALL can affect
      how sort orders things. This can cause labeling issues.
      
      More information on locale and sort can be found via:
        * locale(1) - man 1 locale
        * sort(1) - man 1 sort
        * https://debbugs.gnu.org/cgi/bugreport.cgi?bug=28539
      
      
      
      Rather than deal with this locale setting use fc_sort on
      property contexts. This also has the side-effect of
      stripping comments, and thus sed can be dropped.
      
      Test: This was tested by:
        * comparing outputs to previous runs
        * compile tested *only*.
      
      Change-Id: I1e1eb4dff76f717b5f82f697e677a108abb69892
      Signed-off-by: default avatarWilliam Roberts <william.c.roberts@intel.com>
      3949fe23
    • William Roberts's avatar
      plat_property_contexts: use fc_sort vs sort · 4b44d249
      William Roberts authored
      sort respects locale settings, so the value of LC_ALL can affect
      how sort orders things. Issues have surfaced when CTS build
      servers locale differs from image build server locale. And thus
      the prologue of property_contexts differs with what CTS was
      expecting.
      
      More information on locale and sort can be found via:
        * locale(1) - man 1 locale
        * sort(1) - man 1 sort
        * https://debbugs.gnu.org/cgi/bugreport.cgi?bug=28539
      
      
      
      Rather than deal with this locale setting use fc_sort on
      property contexts. This also has the side-effect of
      stripping comments, and thus sed can be dropped.
      
      Test: This was tested by:
        * comparing outputs to previous runs
        * booting the x86-64 emulator
      
      Change-Id: I144ef549cc11d9c61849ffc0e1b1b000f1b8d1a8
      Signed-off-by: default avatarWilliam Roberts <william.c.roberts@intel.com>
      4b44d249
  7. Sep 26, 2017
  8. Sep 24, 2017
  9. Sep 23, 2017
  10. Sep 21, 2017
    • Andreas Gampe's avatar
      Selinux: Give runas permission to read system_data_file links · 4481b885
      Andreas Gampe authored
      Run-as is running a command under an app's uid and in its data
      directory. That data directory may be accessed through a symlink
      from /data/user. So give runas rights to read such a symlink.
      
      Bug: 66292688
      Test: manual
      Test: CTS JVMTI tests
      Change-Id: I0e0a40d11bc00d3ec1eee561b6223732a0d2eeb6
      4481b885
  11. Sep 20, 2017
  12. Sep 19, 2017
Loading