add more type hints and fail with python exceptions

gen_boxplots.py

@@ -2,11 +2,14 @@
 """generate boxplots from descriptive stats in yaml"""
 
 import sys
+import typing as T
 
 import yaml
 
+Data = dict[str, T.Any]
 
-def parse_data(stream):
+
+def parse_data(stream) -> T.Optional[Data]:
     """Convert yamls string to dict"""
     return yaml.safe_load(stream)
 
@@ -49,7 +52,7 @@ PLOT_TEMPLATE = \
 """
 
 
-def generate_boxplot(data) -> str:
+def generate_boxplot(data: Data) -> str:
     """generate a tikzboxplot"""
     plots = ''
     for variant, stats in data.items():
@@ -71,6 +74,10 @@ def main():
         with open(sys.argv[1], 'r', encoding='utf-8') as yaml_file:
             data = parse_data(yaml_file)
 
+    if data is None:
+        print('No data to plot', file=sys.stderr)
+        sys.exit(1)
+
     tikz = generate_boxplot(data)
 
     if len(sys.argv) > 2:

muhq-ma-plots.sh

 #!/bin/bash
 
-set -o pipefail
+set -eo pipefail
 
 SUM=./summarize.py
 PLOT=./gen_boxplots.py

summarize.py

@@ -2,7 +2,6 @@
 """Collect and summarize evaluation results"""
 
 import argparse
-import os
 import sys
 import typing as T
 from pathlib import Path
@@ -15,13 +14,8 @@ Measurements = list[int]
 Data = dict[Variant, Measurements]
 
 
-def collect(result_dir) -> T.Optional[Data]:
+def collect(result_dir) -> Data:
     """Collect the data in result_dir and return calculated averages"""
-    if not result_dir or not os.path.exists(result_dir) or not os.path.isdir(
-            result_dir):
-        print(f'{result_dir} is not a directory')
-        return None
-
     result_dir = Path(result_dir)
 
     data = {}