Merge branch 'gitlab-ci-image' into 'master'

[gitlab-ci] Bump debian-testing-dev image to 1.10

See merge request !199

.clang-tidy

@@ -9,6 +9,7 @@ Checks: >
   -cert-err58-cpp,
   -clang-diagnostic-empty-translation-unit,
   -readability-braces-around-statements,
+  -readability-function-cognitive-complexity,
   -readability-implicit-bool-conversion,
   -readability-isolate-declaration,
   -readability-magic-numbers,

.gitlab-ci.yml

-image: "flowdalic/debian-testing-dev:1.8"
+image: "flowdalic/debian-testing-dev:1.10"
 
 before_script:
   - |

apps/fsearch/fsearch.cpp

@@ -32,7 +32,7 @@ void search(const std::string& path) {
 	}
 
 	std::array<char, EMPER_RIPGREP_BUFSIZE> buf;
-	size_t bytes_searched = 0;
+	off_t bytes_searched = 0;
 
 	ssize_t bytes_read = emper::io::readFileAndWait(fd, buf.data(), buf.size(), bytes_searched);
 	while (bytes_read > 0) {
@@ -41,7 +41,7 @@ void search(const std::string& path) {
 			return;
 		}
 
-		bytes_searched += static_cast<size_t>(bytes_read);
+		bytes_searched += bytes_read;
 		bytes_read = emper::io::readFileAndWait(fd, buf.data(), buf.size(), -1);
 	}
 

emper/Context.hpp

 // SPDX-License-Identifier: LGPL-3.0-or-later
-// Copyright © 2020 Florian Schmaus
+// Copyright © 2020-2021 Florian Schmaus
 #pragma once
 
 #include <cassert>			// for assert
@@ -82,6 +82,7 @@ class ALIGN_TO_CACHE_LINE Context : Logger<LogSubsystem::C> {
 	// cppcheck-suppress noExplicitConstructor selfInitialization
 	Context(func_t mainFunction)
 			// Align the Top-of-Stack (tos) to 16 byte.
+			// NOLINTNEXTLINE(performance-no-int-to-ptr)
 			: tos((void*)((uintptr_t)(context + CONTEXT_SIZE) & (~0xf))),
 				mainFunction(std::move(std::move(mainFunction))) {
 		//		valgrindStackId = VALGRIND_STACK_REGISTER(context, context + CONTEXT_SI);

emper/io/IoContext.cpp

@@ -188,7 +188,7 @@ auto IoContext::reapCompletions(ContinuationBuffer &continuationFibers) -> unsig
 	unsigned reReapCount = 0;
 	uint32_t maxRaceFreeCompleterAttempts = 1;
 
-	using Completion = std::pair<uint32_t, void *>;
+	using Completion = std::pair<int32_t, void *>;
 	// vector to store seen cqes to make the critical section
 	// where cq_lock is held as small as possible
 	std::array<Completion, CQE_BATCH_COUNT> reapedCompletions;

emper/lib/DebugUtil.cpp

 // SPDX-License-Identifier: LGPL-3.0-or-later
-// Copyright © 2020 Florian Schmaus
+// Copyright © 2020-2021 Florian Schmaus
 #include "DebugUtil.hpp"
 
 #include <execinfo.h>
@@ -14,7 +14,7 @@ static void handler(int sig) {
 	// NOLINTNEXTLINE(modernize-avoid-c-arrays)
 	void* array[backtrace_size];
 
-	size_t size = backtrace(array, backtrace_size);
+	int size = backtrace(array, backtrace_size);
 
 	fprintf(stderr, "Error: signal %d:\n", sig);
 	backtrace_symbols_fd(array, size, STDERR_FILENO);