Skip to content
Snippets Groups Projects
  1. Mar 15, 2022
    • Florian Fischer's avatar
      LinuxVersion: fix compare of versions with not the same amount of parts · f5c1c97d
      Florian Fischer authored
      LinuxVersion::compare reported two versions as equal if it could
      find a new '.' in the first version but not in the second.
      But this is clearly wrong because it skips comparision of the valid last
      part.
      
      The comparision 5.16.12 >= 5.18 returned true because compare
      reported the version as equal after comparing the first parts and
      finding a second '.' in the first but not the second.
      
      Fix this behavior by marking the current position as the last but
      do not skip its comparision.
      
      Add tests for the desired behaviour.
      f5c1c97d
  2. Feb 12, 2022
  3. Jan 21, 2022
    • Florian Fischer's avatar
      [LinuxVersion] fix version comparison · 7eb1fff6
      Florian Fischer authored
      LinuxVersion used the assumption that both strings have the same
      amount of dot-separated components.
      But this is obviously not always the case.
      If we can't compare the two strings further they must been equal so far.
      7eb1fff6
  4. Sep 14, 2021
    • Florian Fischer's avatar
      [lib/LinuxVersion] multiple fixes · c1387013
      Florian Fischer authored
      * remove fancy but broken static LinuxVersion object.
        This means each usage of a EMPER_LINUX_* macro results in a syscall.
        But I think this is worth it when the result is a sound program.
        Users of those macros should store the result of the comparison anyway.
      * fix that we skipped parsing the last part of a version string
      * add a test for LinuxVersion
      * IO_MUST_INVALIDATE_BROKEN_CHAIN can still be const
      c1387013
  5. Apr 01, 2021
Loading