Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • E emper
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 15
    • Issues 15
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • i4i4
  • manycore
  • emper
  • Merge requests
  • !170

[Future] improve cancellation

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Florian Fischer requested to merge aj46ezos/emper:improve_future_cancellation into master Apr 13, 2021
  • Overview 0
  • Commits 1
  • Pipelines 1
  • Changes 3
  • Improve warn message in Future::cancel()
  • Don't cancel a Future in the destructor if it was already cancelled or received
  • Restructure CancelFutureTest into single separate test cases

With this I can not reproduce the CancelFutureTest failures anymore neither SIGABRT nor the timeout.

I tested the CancelFutureTest (10 times) on various build configurations with out any failure:

meson build-release --buildtype=release
meson build-debugoptimized
meson build-stats -Dstats=true
meson build-stats-laws -Dstats=true -Ddefault_scheduling_strategy=locality_aware_work_stealing
meson build-ci-failure -Dstats=true -Dio=false
for d in build-*
do
    meson test -C ${d} CancelFutureTest --repeat=10
done

Not sure if this resolves #16 (closed). I will keep it open for now.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: improve_future_cancellation