Fix most llvm-12 clang-tidy warnings in IO code (!205) · Merge requests · Lehrstuhl für Informatik 4 (Systemsoftware) / manycore / emper

Merged Florian Fischer requested to merge aj46ezos/emper:fix-llvm-12-clang-tidy-warnings into master 3 years ago

May 17, 2021

[TaggedPtr] ignore clang-tidy pointer cast diagnostics · d26a8aed
Florian Fischer authored 3 years ago

d26a8aed
[GlobalIoContext] use correct types · 122d2974
Florian Fischer authored 3 years ago
```
Thanks llvm 12 :)
```
122d2974

[SimpleDiskAndNetworkTest] use *AndWait() or waitAndSetErrno() and correct types · 4b7f7802

Florian Fischer authored 3 years ago

errno was never set on error and thus the DIE_MSG_ERRNO did not properly
report what happened.

Found during changing Future member types.

4b7f7802

[io.hpp] fix openAndWait and closeAndWait definitions · 084d678e

Florian Fischer authored 3 years ago

The posix versions (close/openat) return int as well.
And this fixes a narrowing conversion in c_emper.cpp: emper_openat and emper_close

084d678e

[IO] improve Future member types · c3b57183

Florian Fischer authored 3 years ago

Use int32_t as Future returnValue instead of ssize_t since
io_uring uses int32_t not ssize_t as results value therefore it is
pointless to use a bigger type.

This shrinks the future size and prevents useless and implementation defined
narrowing conversions from ssize_t to int32_t.

Use union for flags and offset.

Ignore int to pointer cast clang-tidy warning.

c3b57183

Fix most llvm-12 clang-tidy warnings in IO code

Merge request reports

Activity