Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • E emper
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 15
    • Issues 15
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • i4i4
  • manycore
  • emper
  • Merge requests
  • !25

Remove -UNDEBUG from tests

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Florian Fischer requested to merge test_no_undef_ndebug into master Nov 20, 2020
  • Overview 0
  • Commits 1
  • Pipelines 2
  • Changes 1

The explicit -UNDEBUG was introduced in the CMake to meson migration (62900cd1) but as far as I can tell it was not present in the CMake tests definition.

First of all, I don't see any reason why we would undef NDEBUG for builds where we explicitly define it.

Secondly, it makes tests less reliable because it enables only some debug messages but not all. For example if emper is build with NDEBUG a test using a Semaphore will output debug messages from the Semaphore but not from the Runtime.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: test_no_undef_ndebug