Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • E emper
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 15
    • Issues 15
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • i4i4
  • manycore
  • emper
  • Merge requests
  • !266

[WakeupStrategy] fix the throttle algorithm for notifiaction from anywhere

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Florian Fischer requested to merge aj46ezos/emper:fix-throttle-wakeup into master Oct 04, 2021
  • Overview 0
  • Commits 1
  • Pipelines 1
  • Changes 3

The throttle algorithm had the same problem like our sleep algorithms where notifications from anywhere race with a worker going to sleep resulting in lost wakeups. In our sleep strategies we prevent those races by preventing sleep attempts when notifying from anywhere. The throttle algorithm also does now exactly this. A notifier from anywhere will now always set the WakeupStrategy state to notified. If the state was previously pending this new approach does not differ from the previous behavior and a sleeping worker will be notified. If the state was waking the waking worker skips its sleep if it observes the WakeupStrategy state as notified.

Fixes #26 (closed).

Edited Oct 04, 2021 by Florian Fischer
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix-throttle-wakeup