Skip to content
Snippets Groups Projects

Revert "[tests] don't undef NDEBUG for test executables"

Merged Florian Schmaus requested to merge flow/emper:ndebug into master

This reverts commit b33ac93c.

Now that logging is done independently from NDEBUG, we can re-enable "undef NDEBUG for test executables". The rationale that we want to undefine NDEBUG for test executable is that we want, even in release builds, asserts in tests enabled. Note that this also applies to asserts in the emper core library, if those are in headers.

Merge request reports

Pipeline #53032 passed

Pipeline passed for a3b2a501 on flow:ndebug

Merged by Florian SchmausFlorian Schmaus 4 years ago (Dec 1, 2020 3:43pm UTC)

Loading

Pipeline #53063 passed

Pipeline passed for 254fa48b on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
Please register or sign in to reply
Loading