Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • E emper
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 15
    • Issues 15
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • i4i4
  • manycore
  • emper
  • Merge requests
  • !36

Revert "[tests] don't undef NDEBUG for test executables"

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Florian Schmaus requested to merge flow/emper:ndebug into master Dec 01, 2020
  • Overview 0
  • Commits 1
  • Pipelines 1
  • Changes 1

This reverts commit b33ac93c.

Now that logging is done independently from NDEBUG, we can re-enable "undef NDEBUG for test executables". The rationale that we want to undefine NDEBUG for test executable is that we want, even in release builds, asserts in tests enabled. Note that this also applies to asserts in the emper core library, if those are in headers.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: ndebug