Skip to content
Snippets Groups Projects
  1. Feb 21, 2019
  2. Jul 25, 2018
  3. Jul 19, 2018
  4. Apr 08, 2018
  5. Jul 17, 2017
  6. Mar 08, 2017
    • Hans-Peter Deifel's avatar
      upload: Send correct form data in presence of checkboxes · 0ffecd03
      Hans-Peter Deifel authored
      tl;dr: Unchecked checkboxes usually don't send their value as
      parameter when the form is submitted. The ajax request in our upload
      code did just that which resulted in the value of checkboxes being
      wrongly interpreted.
      
      The default value of a checkbox is "on", even when it is off. The crux
      is that with standard HTML forms, this value will only be included in
      the form data if the checkbox is checked. The python end thus receives
      "on" for a checked checkbox and the empty string for an unchecked
      checkbox. It so happens that bool("on") == True and bool("") == False.
      
      Our JavaScript code that sends the form data for the upload page
      wrongly included the checkbox value, even if it was not checked. This
      resulted in the python end always receiving "on".
      
      See: http://stackoverflow.com/questions/33487360/formdata-and-checkboxes
      
      fixes #106
      0ffecd03
  7. Feb 06, 2017
  8. Sep 23, 2016
  9. Sep 22, 2016
  10. Sep 21, 2016
  11. Aug 17, 2016
  12. Aug 15, 2016
  13. Aug 09, 2016
  14. Jan 28, 2016
  15. Jan 26, 2016
  16. Jan 02, 2016
  17. Jul 23, 2015
    • Hans-Peter Deifel's avatar
      Make theme selection site local · 26730cb7
      Hans-Peter Deifel authored
      - Remove the very host specific configuration from config/__init__.py
        and replace it by generic default values (no URL specific themes;
        'fsi_inf' as default theme)
      
      - Add documentation for the two variables 'default_theme' and
        'themes_by_url' so that site admins can overwrite them in their local
        config.
      26730cb7
    • Hans-Peter Deifel's avatar
      Put more information about lecture in mod-mail · 9922ce0b
      Hans-Peter Deifel authored
      Specifically, put the lecture name in in the subject and the semester in
      the body.
      
      fixes #291
      9922ce0b
Loading