Skip to content
Snippets Groups Projects
Commit c9ab13c7 authored by Johannes Schindelin's avatar Johannes Schindelin Committed by Anton Wuerfel
Browse files

Mark win32's pthread_exit() as NORETURN

The pthread_exit() function is not expected to return. Ever. On Windows,
we call ExitThread() whose documentation claims: "Ends the calling
thread", i.e. there is no condition in which this function simply
returns: https://msdn.microsoft.com/en-us/library/windows/desktop/ms682659

While at it, fix the return type to be void, as per
http://pubs.opengroup.org/onlinepubs/9699919799/functions/pthread_exit.html



Pointed out by Jeff King, helped by Stefan Naewe, Junio Hamano &
Johannes Sixt.

Signed-off-by: default avatarJohannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: default avatarJunio C Hamano <gitster@pobox.com>
parent aca17648
No related branches found
No related tags found
No related merge requests found
...@@ -78,7 +78,7 @@ extern int win32_pthread_join(pthread_t *thread, void **value_ptr); ...@@ -78,7 +78,7 @@ extern int win32_pthread_join(pthread_t *thread, void **value_ptr);
#define pthread_equal(t1, t2) ((t1).tid == (t2).tid) #define pthread_equal(t1, t2) ((t1).tid == (t2).tid)
extern pthread_t pthread_self(void); extern pthread_t pthread_self(void);
static inline int pthread_exit(void *ret) static inline void NORETURN pthread_exit(void *ret)
{ {
ExitThread((DWORD)(intptr_t)ret); ExitThread((DWORD)(intptr_t)ret);
} }
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment