Skip to content
Snippets Groups Projects
  1. Apr 19, 2016
    • mukesh agrawal's avatar
      limit shell's access to log.* properties · 84cfde22
      mukesh agrawal authored
      Restrict the ability of the shell to set the log.*
      properties. Namely: only allow the shell to set
      such properities on eng and userdebug builds.
      
      The shell (and other domains) can continue to
      read log.* properties on all builds.
      
      While there: harmonize permissions for log.* and
      persist.log.tag. Doing so introduces two changes:
      - log.* is now writable from from |system_app|. This
        mirrors the behavior of persist.log.tag, which is
        writable to support "Developer options" ->
        "Logger buffer sizes" -> "Off".
        (Since this option is visible on user builds, the
        permission is enabled for all builds.)
      - persist.log.tag can now be set from |shell| on
        userdebug_or_eng().
      
      BUG=28221972
      TEST=manual (see below)
      
      Testing details
      - user build (log.tag)
        $ adb shell setprop log.tag.foo V
        $ adb shell getprop log.tag
        <blank line>
        $ adb bugreport | grep log.tag.foo
        [  146.525836] init: avc:  denied  { set } for property=log.tag.foo pid=4644 uid=2000 gid=2000 scontext=u:r:shell:s0 tcontext=u:object_r:log_prop:s0 tclass=property_service permissive=0
        [  146.525878] init: sys_prop: permission denied uid:2000  name:log.tag.foo
      - userdebug build (log.tag)
        $ adb shell getprop log.tag.foo
        <blank line>
        $ adb shell setprop log.tag.foo V
        $ adb shell getprop log.tag.foo
        V
      - user build (persist.log.tag)
        $ adb shell getprop | grep log.tag
        <no match>
        - Developer options -> Logger buffer sizes -> Off
        $ adb shell getprop | grep log.tag
        [persist.log.tag]: [Settings]
        [persist.log.tag.snet_event_log]: [I]
      
      Change-Id: Idf00e7a623723a7c46bf6d01e386aeca92b2ad75
      84cfde22
  2. Apr 14, 2016
  3. Apr 13, 2016
  4. Apr 12, 2016
  5. Apr 11, 2016
    • Peng Xu's avatar
      Allow all apps to discover contexthub_service · 7df44d82
      Peng Xu authored
      This allows system app, regular app as well as test app to access
      ContextHubManager API. Additional "signature|privilige" permission
      requirement (LOCATION_HARDWARE) still exist to prevent security
      issues, misuse and abuse.
      
      Change-Id: I47f3d243a3de7f1202c933fc715a935c43cf319b
      7df44d82
  6. Apr 09, 2016
    • Alex Deymo's avatar
      Allow postinstall_file to be an entrypoint. · ac52f460
      Alex Deymo authored
      postinstall_file was an exec_type so it could be an entrypoint for the
      domain_auto_trans from update_engine domain to postinstall domain. This
      patch removes the exec_type from postinstall_file and exempts it from
      the neverallow rule to become an entrypoint.
      
      Bug: 28008031
      TEST=postinstall_example still runs as the "postinstall" domain on edison-eng.
      
      (cherry picked from commit a9671c6b)
      
      Change-Id: I2e1f61ed42f8549e959edbe047c56513903e8e9c
      ac52f460
  7. Apr 08, 2016
  8. Apr 07, 2016
  9. Apr 06, 2016
    • Ruben Brunk's avatar
    • Ruben Brunk's avatar
      Update selinux policy for VrManager AIDL. · 743969ba
      Ruben Brunk authored
      Bug: 27884853
      Change-Id: I097306a324bdc25c5d22868f0342e175ce0dbb9a
      743969ba
    • Daniel Rosenberg's avatar
      Expand bluetooth access to media_rw_data_file for now. · 4a0c8036
      Daniel Rosenberg authored
      With sdcardfs, we no longer have a separate sdcardd acting as
      an intermediate between the outside world and /data/media.
      Unless we modify sdcardfs to change contexts, we need these.
      
      Remove this patch if sdcardfs is updated to change the
      secontext of fs accesses.
      
      Bug: 28040634
      
      Change-Id: I492c87e9f232c57f43abd09b7864b52847bc3555
      4a0c8036
    • Jeff Sharkey's avatar
      Allow system_server to execute timeout. · 75b25dd1
      Jeff Sharkey authored
      We've seen evidence that the logcat binary can end up wedged, which
      means we can eventually starve system_server for FDs.  To mitigate
      this, wrap logcat using the timeout utility to kill and clean up if
      it takes too long to exit.
      
      avc: denied { execute } for name="toybox" dev="mmcblk0p43" ino=457 scontext=u:r:system_server:s0 tcontext=u:object_r:toolbox_exec:s0 tclass=file permissive=1
      avc: denied { read open } for path="/system/bin/toybox" dev="mmcblk0p43" ino=457 scontext=u:r:system_server:s0tcontext=u:object_r:toolbox_exec:s0 tclass=file permissive=1
      avc: denied { execute_no_trans } for path="/system/bin/toybox" dev="mmcblk0p43" ino=457 scontext=u:r:system_server:s0 tcontext=u:object_r:toolbox_exec:s0 tclass=file permissive=1
      
      Bug: 27994717, 28021719, 28009200
      Change-Id: I76d3c7fe5b37fb9a144a3e5dbcc9150dfea495ee
      75b25dd1
  10. Apr 05, 2016
    • Daniel Rosenberg's avatar
      Allow search/getattr access to media_rw_data_file for now. · b80bdef0
      Daniel Rosenberg authored
      With sdcardfs, we no longer have a separate sdcardd acting as
      an intermediate between the outside world and /data/media.
      Unless we modify sdcardfs to change contexts, we need these.
      Added for: system_server, dumpstate, and bluetooth
      
      Remove this patch if sdcardfs is updated to change the
      secontext of fs accesses.
      
      Bug: 27932396
      Change-Id: I294cfe23269b7959586252250f5527f13e60529b
      b80bdef0
  11. Apr 02, 2016
  12. Apr 01, 2016
    • Mark Salyzyn's avatar
      dumpstate: access /data/misc/logd · 3ea709be
      Mark Salyzyn authored
      (cherry pick from commit 74541338)
      
      Bug: 27965066
      Change-Id: Ia0690c544876e209e4c080b0e959f763b731c48a
      3ea709be
    • Nick Kralevich's avatar
      refine /data/misc/logd rules · 8a8770cd
      Nick Kralevich authored
      (cherry pick from commit 6937aa93)
      
      Followup to 121f5bfd.
      
      Move misc_logd_file neverallow rule from domain.te to logd.te,
      since the goal of the neverallow rule is to protect logd / logpersist
      files from other processes.
      
      Switch the misc_logd_file neverallow rule from using "rw_file_perms"
      to "no_rw_file_perms". The latter covers more cases of file
      modifications.
      
      Add more neverallow rules covering misc_logd_file directories.
      
      Instead of using not_userdebug_nor_eng(), modify the rules to be
      consistent with other highly constrained file types such as
      keystore_data_file or vold_data_file. See, for example,
      https://android-review.googlesource.com/144768
      
      To see the net effect of this change, you can use the following
      command line:
      
        sesearch --allow -t misc_logd_file -c file,dir,lnk_file \
        out/target/product/bullhead/root/sepolicy
      
      Before this change:
      
        # userdebug builds
        allow init misc_logd_file:dir { search setattr read create getattr write relabelfrom ioctl rmdir remove_name relabelto open add_name };
        allow init misc_logd_file:file { setattr read create write relabelfrom getattr relabelto unlink open };
        allow init misc_logd_file:lnk_file { setattr relabelfrom create getattr relabelto unlink };
        allow logd misc_logd_file:dir { search read lock getattr write ioctl remove_name open add_name };
        allow logd misc_logd_file:file { rename setattr read lock create getattr write ioctl unlink open append };
        allow shell misc_logd_file:dir { search read lock getattr ioctl open };
        allow shell misc_logd_file:file { read lock ioctl open getattr };
      
        # user builds
        allow init misc_logd_file:dir { search setattr read create getattr write relabelfrom ioctl rmdir remove_name relabelto open add_name };
        allow init misc_logd_file:file relabelto;
        allow init misc_logd_file:lnk_file { setattr relabelfrom create getattr relabelto unlink };
      
      After this change:
      
        # userdebug builds
        allow init misc_logd_file:dir { search setattr read create getattr ioctl relabelto open };
        allow init misc_logd_file:file { relabelto getattr };
        allow init misc_logd_file:lnk_file relabelto;
        allow logd misc_logd_file:dir { search read lock getattr write ioctl remove_name open add_name };
        allow logd misc_logd_file:file { rename setattr read lock create getattr write ioctl unlink open append };
        allow shell misc_logd_file:dir { search read lock getattr ioctl open };
        allow shell misc_logd_file:file { read lock ioctl open getattr };
      
        # user builds
        allow init misc_logd_file:dir { search setattr read create getattr ioctl relabelto open };
        allow init misc_logd_file:file { relabelto getattr };
        allow init misc_logd_file:lnk_file relabelto;
      
      Change-Id: I0b00215049ad83182f458b4b9e258289c5144479
      Bug: 27965066
      8a8770cd
    • Jesse Hall's avatar
      Define gpu_service and allow surfaceflinger to provide it · 59970a4e
      Jesse Hall authored
      Bug: 26620936 and 27352427
      Change-Id: I3d6d2e479d95133693790a97827e45e9dd30bc4a
      59970a4e
    • Jeff Tinker's avatar
  13. Mar 31, 2016
    • Jeff Tinker's avatar
      Allow mediadrmservice to access processinfo · a6ae3312
      Jeff Tinker authored
      Needed to support session reclaiming
      
      bug: 27916039
      Change-Id: I464e6db5b9bc4e83f85cb4623eeca340e1efd603
      a6ae3312
    • Nick Kralevich's avatar
      bootanim: allow /proc/meminfo read · 7a35c136
      Nick Kralevich authored
      Allow /proc/meminfo to be read by bootanim. Not sure why
      it's needed, but harmless enough.
      
      Modify domain_deprecated so it doesn't use r_dir_file().
      /proc/meminfo is neither a symlink nor a directory, so it doesn't
      make sense to create allow rules for those classes of objects.
      
      Addresses the following denial:
      
        avc: denied { read } for comm="BootAnimation" name="meminfo" dev="proc"
        ino=4026536593 scontext=u:r:bootanim:s0
        tcontext=u:object_r:proc_meminfo:s0 tclass=file permissive=0
      
      This denial is only showing up on flounder, flounder_lte, or
      dragon devices. I'm not sure why.
      
      Change-Id: I0f808bcae47fc2fda512cd147c3b44593835cac5
      7a35c136
    • Daniel Rosenberg's avatar
    • Daniel Rosenberg's avatar
      Allow access to media_rw_data_file for now. · d25d57a3
      Daniel Rosenberg authored
      With sdcardfs, we no longer have a separate sdcardd acting as
      an intermediate between the outside world and /data/media.
      Unless we modify sdcardfs to change contexts, we need these.
      Added for: adbd, kernel, mediaserver, and shell
      
      Remove this patch if sdcardfs is updated to change the
      secontext of fs accesses.
      
      Bug: 27915475
      Bug: 27937873
      
      Change-Id: I25edcfc7fb8423b3184db84040bda790a1042724
      d25d57a3
    • Daniel Rosenberg's avatar
    • Daniel Rosenberg's avatar
      Allow shell and adbd access to media_rw_data_file for now. · bb90999e
      Daniel Rosenberg authored
      With sdcardfs, we no longer have a separate sdcardd acting as
      an intermediate between the outside world and /data/media.
      Unless we modify sdcardfs to change contexts, we need these.
      
      Remove this patch if sdcardfs is updated to change the
      secontext of fs accesses.
      
      Bug: 27925072
      Change-Id: I3ad37c0f12836249c83042bdc1111b6360f22b3c
      bb90999e
  14. Mar 30, 2016
Loading