Skip to content
Snippets Groups Projects
  1. Sep 28, 2017
    • Bowgo Tsai's avatar
      Removing $(PRODUCT_OUT)/root/root · 4cc4096a
      Bowgo Tsai authored
      Bug: 65570851
      Test: boot sailfish
      Change-Id: I008bf5386595c614236de44131afcda7d3fd6d98
      Merged-In: I008bf5386595c614236de44131afcda7d3fd6d98
      (cherry picked from commit 82ca9c2e)
      4cc4096a
  2. Sep 27, 2017
    • Dan Cashman's avatar
      Fix build. · 7d1130f1
      Dan Cashman authored
      (This reverts internal commit: 82ca9c2e)
      Test: None.
      
      Merged-in: I97ffdd48b64ef5c35267387079204512a093a356
      Change-Id: I97ffdd48b64ef5c35267387079204512a093a356
      7d1130f1
    • Jeff Vander Stoep's avatar
      Allow system settings to read /proc/version · c975bd90
      Jeff Vander Stoep authored
      Used to display kernel version in settings app.
      
      avc: denied { read } for name="version" dev="proc"
      scontext=u:r:system_app:s0 tcontext=u:object_r:proc_version:s0
      tclass=file permissive=0
      
      Bug: 66985744
      Test: kernel version now displayed in settings app.
      Change-Id: I53f92f63362b900347fd393a40d70ccf5d220d30
      c975bd90
    • Dan Cashman's avatar
      Fix build. · 852aca05
      Dan Cashman authored
      (This reverts internal commit: 82ca9c2e)
      Test: None.
      
      Change-Id: I97ffdd48b64ef5c35267387079204512a093a356
      852aca05
    • Dan Cashman's avatar
      Fix build. Split mediaprovider from priv_app. · 3e21c5f1
      Dan Cashman authored
      This CL was accidentally reverted a second time by commit:
      cb5129f9.  Submit it for the third,
      and final, time.
      
      (cherry-pick of 5637587d
      which was in AOSP and internal master but not stage-aosp-master)
      
      Bug: 62102757
      Test: Builds and boots.
      Change-Id: I0394907e808c737422e644aec452baa3e777cf6f
      3e21c5f1
  3. Sep 26, 2017
  4. Sep 15, 2017
  5. Sep 14, 2017
    • Tri Vo's avatar
      Explicitly label logd's dependencies in /proc. · 87ed5e8d
      Tri Vo authored
      labeled /proc/kmsg as proc_kmsg, changed logd's access from proc to
      proc_kmsg, and added a compat mapping.
      
      Bug: 65643247
      Test: device boots without selinux denials to the newly introduced proc_kmsg
      Test: logd-unit-tests passes
      
      Merged-In: I92c9f5694289eb6a94c4d90f14e2de4d46b5228e
      Change-Id: I92c9f5694289eb6a94c4d90f14e2de4d46b5228e
      (partial CP of commit 528da6fe)
      87ed5e8d
  6. Sep 11, 2017
  7. Sep 05, 2017
  8. Aug 28, 2017
    • Bowgo Tsai's avatar
      Moving adbd from rootdir to system/bin · 5846c79e
      Bowgo Tsai authored
      Bug: 63910933
      Test: boot sailfish in normal mode, checks adbd is started
      Test: boot sailfish in recovery mode, checks adbd is started
      Test: boot bullhead in normal mode, checks adbd is started
      Test: boot bullhead in recovery mode, checks adbd is started
      
      Change-Id: I35ed78a15a34626fbd3c21d030e2bf51033f7b79
      Merged-In: I35ed78a15a34626fbd3c21d030e2bf51033f7b79
      (cherry picked from commit e2423d14)
      5846c79e
  9. Aug 24, 2017
    • Mark Salyzyn's avatar
      Switch /data/misc/reboot/last_reboot_reason to persistent property · 006c2e99
      Mark Salyzyn authored
      Switch from /data/misc/reboot/last_reboot_reason to persistent
      Android property persist.sys.boot.reason for indicating why the
      device is rebooted or shutdown.
      
      Introduce protection for all boot reason properties
      
      Protect the following properties with these labels
      
      ro.boot.bootreason      u:object_r:bootloader_boot_reason_prop:s0
      sys.boot.reason         u:object_r:sys_boot_reason_prop:s0
      persist.sys.boot.reason u:object_r:last_boot_reason_prop:s0
      
      Setup the current as-need access rules for each.
      
      ToDo: Remove u:object_r:reboot_data_file after internal fixes.
      
      Test: system/core/bootstat/boot_reason_test.sh
      Bug: 64687998
      Change-Id: I3771c73933e8ae2d94aee936c7a38b6282611b80
      006c2e99
  10. Aug 16, 2017
    • Martijn Coenen's avatar
      Remove display.qservice from service_contexts. · e1887359
      Martijn Coenen authored
      This is a Qualcomm proprietary service,
      and does not belong here.
      
      Test: boot Marlin
      Bug: 63391760
      Merged-In: If7469051f6cef3e2440f7021ae26c9815ff54820
      Change-Id: If7469051f6cef3e2440f7021ae26c9815ff54820
      e1887359
  11. Aug 14, 2017
    • Steven Moreland's avatar
      Add screencap domain. · 9216a6ad
      Steven Moreland authored
      Only seeing this denial in permissive:
      allow shell screencap_exec:file getattr;
      
      Bug: 37565047
      Test: adb shell screencap w/o root
      Test: cts-tradefed run cts-dev --module CtsAadbHostTestCases
      Merged-In: I9f31d2067e002e7042646ee38dbfc06687481ac7
      Change-Id: I9f31d2067e002e7042646ee38dbfc06687481ac7
      9216a6ad
    • Steven Moreland's avatar
      Add screencap domain. · 6b780b35
      Steven Moreland authored
      Only seeing this denial in permissive:
      allow shell screencap_exec:file getattr;
      
      Bug: 37565047
      Test: adb shell screencap w/o root
      Test: cts-tradefed run cts-dev --module CtsAadbHostTestCases
      Merged-In: I9f31d2067e002e7042646ee38dbfc06687481ac7
      Change-Id: I9f31d2067e002e7042646ee38dbfc06687481ac7
      6b780b35
  12. Aug 11, 2017
    • Josh Gao's avatar
      Add /dev/kmsg_debug. · 94e2a921
      Josh Gao authored
      Add /dev/kmsg_debug on userdebug devices, to allow crash_dump to log
      crashes to dmesg when logd isn't up yet (or is the one crashing).
      
      Bug: http://b/36574794
      Test: stop tombstoned; crasher; dmesg
      Change-Id: I6ffe11bc613e88198893e82712719522b74fe1be
      94e2a921
    • Nick Kralevich's avatar
      Validate no-cross-domain /proc/PID access · 7a463809
      Nick Kralevich authored
      Android uses hidepid=2 to restrict visibility to other /proc entries on
      the system. This helps preserve user, application, and system
      confidentiality by preventing unauthorized access to application metadata,
      and addresses attacks such as
      http://www.cs.ucr.edu/~zhiyunq/pub/sec14_android_activity_inference.pdf
      
      Ensure the SELinux (weaker) equivalent is being enforced by adding
      neverallow compile time assertions.
      
      TODO: The "shell" user runs as both an Android application, as well as
      spawned via adb shell. This was a mistake. We should separate out the
      "shell" Android app into it's own SELinux domain. For now, exclude the
      shell from this assertion. (The shell Android app is covered by
      hidepid=2, so there's no leaking of data, but still, it's over
      privileged today and should be cleaned up.
      
      Bug: 23310674
      Test: policy compiles. Compile time assertion only.
      Change-Id: I0e1a6506b2719aabf7eb8127f046c4ada947ba90
      7a463809
  13. Aug 01, 2017
    • Ruchi Kandoi's avatar
      Allow nfc application to set nfc property · 0393dafd
      Ruchi Kandoi authored
      type=1400 audit(1501520483.066:14): avc: denied { write } for pid=3330
      comm=4173796E635461736B202331 name="property_service" dev="tmpfs"
      ino=10749 scontext=u:r:nfc:s0 tcontext=u:object_r:property_socket:s0
      tclass=sock_file permissive=0
      
      Test: No sepolicy denials
      Bug: 64010793
      Change-Id: I8d73e8e19cd4d0a8c61f1f184820c53e5cc2b6d6
      (cherry picked from commit df964950)
      0393dafd
  14. Jul 31, 2017
    • Ruchi Kandoi's avatar
      Allow nfc application to set nfc property · df964950
      Ruchi Kandoi authored
      type=1400 audit(1501520483.066:14): avc: denied { write } for pid=3330
      comm=4173796E635461736B202331 name="property_service" dev="tmpfs"
      ino=10749 scontext=u:r:nfc:s0 tcontext=u:object_r:property_socket:s0
      tclass=sock_file permissive=0
      
      Test: No sepolicy denials
      Bug: 64010793
      Change-Id: I8d73e8e19cd4d0a8c61f1f184820c53e5cc2b6d6
      df964950
  15. Jul 28, 2017
    • Jeff Vander Stoep's avatar
      system_server: allow writing to timerslack_ns · 5c41d40e
      Jeff Vander Stoep authored
      The only file in /proc/<pid>/ that is world writeable is
      /proc/<pid>/timerslack_ns so granting selinux write permission to
      a process's /proc/<pid>/ file only allows writing to timerslack_ns
      (unless the process is running as system UID).
      
      Addresses denials such as:
      avc: denied { write } for comm="Binder:1117_2" name="timerslack_ns"
      dev="proc" ino=27908 scontext=u:r:system_server:s0
      tcontext=u:r:priv_app:s0 tclass=file permissive=1
      
      Bug: 30675296
      Test: build
      Change-Id: I2cee8ce73a0dc05d771881c36da2fde5411859fb
      5c41d40e
    • Jeff Vander Stoep's avatar
      domain_deprecated is dead · b5da252e
      Jeff Vander Stoep authored
      long live domain.te!
      
      Remove all references.
      
      Bug: 28760354
      Test: build
      Merged-In: I99953ecc7d275fdbe8e56d8f47a27d1f9e1cc09a
      Change-Id: I99953ecc7d275fdbe8e56d8f47a27d1f9e1cc09a
      b5da252e
    • Niranjan Pendharkar's avatar
      Add system_net_netd_hwservice. · 5aef6a94
      Niranjan Pendharkar authored
      This hidl service provides functionality for oem networking
      configuration to vendor services which is required by
      at least some vendor radio modules.
      
      Test: VtsHalNetNetdV1_0TargetTest, netd_integration_test, netd_unit_test
      Test: no denials
      Bug: 36682246
      Change-Id: I86ac9082166b406b2fc814972375ba737460ad7b
      5aef6a94
  16. Jul 27, 2017
    • Jeff Vander Stoep's avatar
      domain_deprecated: remove sysfs rules · 275f6dd5
      Jeff Vander Stoep authored
      Clean up the remaining granted permissions in domain_deprecated.
      
      avc: granted { read open } for comm="uncrypt"
      path="/sys/firmware/devicetree/base/firmware/android/fstab/compatible"
      dev="sysfs" ino=17591 scontext=u:r:uncrypt:s0
      tcontext=u:object_r:sysfs:s0 tclass=file
      avc: granted { getattr } for comm="uncrypt"
      path="/sys/firmware/devicetree/base/firmware/android/compatible"
      dev="sysfs" ino=17583 scontext=u:r:uncrypt:s0
      tcontext=u:object_r:sysfs:s0 tclass=file
      
      vc: granted { read open } for comm="update_engine"
      path="/sys/firmware/devicetree/base/firmware/android/fstab" dev="sysfs"
      ino=17258 scontext=u:r:update_engine:s0 tcontext=u:object_r:sysfs:s0
      tclass=dir
      avc: granted { getattr } for comm="update_engine"
      path="/sys/firmware/devicetree/base/firmware/android/fstab/compatible"
      dev="sysfs" ino=17259 scontext=u:r:update_engine:s0
      tcontext=u:object_r:sysfs:s0 tclass=file
      
      Bug: 28760354
      Test: build
      Change-Id: Id318ce84894c1001361923f5205de093a15c1e6a
      275f6dd5
    • Joel Galenson's avatar
      Add missing comment from my previous merge in 47966cec. · 87e51162
      Joel Galenson authored
      Test: Built.
      Change-Id: Ia5f5b52e10e9411cd87901053675d9e77a622529
      87e51162
    • Joel Galenson's avatar
      Move file labeling to genfs_contexts. · 27c0aa7a
      Joel Galenson authored
      This should improve performance, as file_contexts is slower than
      genfs_contexts.
      
      Bug: 62413700
      Test: Built, flashed, and booted Sailfish.  Verified that the
      files have the correct context and that wifi, web, and atrace work.
      
      Merged-In: Ia28707ec565a0792bc882fbffe9e8ab9968535f5
      Change-Id: I9546f3af3c95e3443684ae4764881b69987611ef
      27c0aa7a
  17. Jul 26, 2017
    • Jeff Vander Stoep's avatar
      system_server: read symlinks in /cache · a4cada74
      Jeff Vander Stoep authored
      type=1400 audit(0.0:6): avc: denied { read } for comm="Thread-5"
      name="cache" dev="dm-0" ino=13 scontext=u:r:system_server:s0
      tcontext=u:object_r:cache_file:s0 tclass=lnk_file permissive=0
      
      Bug: 64067152
      Test: build
      Change-Id: Ie90c0343a834aa87b7ded41f503e05d9b63b3244
      a4cada74
    • Jeff Vander Stoep's avatar
      domain_deprecated: remove proc access · c15d54ef
      Jeff Vander Stoep authored
      Remove "granted" logspam. Grante the observed permissions to the
      individual processes that need them and remove the permission from
      domain_deprecated.
      
      avc: granted { read open } for comm="ndroid.settings"
      path="/proc/version" dev="proc" ino=4026532081
      scontext=u:r:system_app:s0 tcontext=u:object_r:proc:s0 tclass=file
      avc: granted { getattr } for comm=4173796E635461736B202332
      path="/proc/pagetypeinfo" dev="proc" ino=4026532129
      scontext=u:r:system_app:s0 tcontext=u:object_r:proc:s0 tclass=file
      
      avc: granted { read open } for comm="uncrypt" path="/proc/cmdline"
      dev="proc" ino=4026532072 scontext=u:r:uncrypt:s0
      tcontext=u:object_r:proc:s0 tclass=file
      
      avc: granted { read open } for comm="update_engine"
      path="/proc/sys/kernel/random/boot_id" dev="proc" ino=15852829
      scontext=u:r:update_engine:s0 tcontext=u:object_r:proc:s0 tclass=file
      
      avc: granted { read open } for comm="tiveportallogin"
      path="/proc/vmstat" dev="proc" ino=4026532130
      scontext=u:r:platform_app:s0:c512,c768 tcontext=u:object_r:proc:s0
      tclass=file
      
      This change is specifically not granting the following since it
      should not be allowed:
      avc: granted { read open } for comm="crash_dump64"
      path="/proc/filesystems" dev="proc" ino=4026532416
      scontext=u:r:dex2oat:s0 tcontext=u:object_r:proc:s0 tclass=file
      avc: granted { read } for comm="crash_dump64" name="filesystems"
      dev="proc" ino=4026532416 scontext=u:r:dex2oat:s0
      tcontext=u:object_r:proc:s0 tclass=file
      avc: granted { getattr } for comm="crash_dump64"
      path="/proc/filesystems" dev="proc" ino=4026532416
      scontext=u:r:dex2oat:s0 tcontext=u:object_r:proc:s0 tclass=file
      
      Bug: 64032843
      Bug: 28760354
      Test: build
      Change-Id: Ib309e97b6229bdf013468dca34f606c0e8da96d0
      c15d54ef
  18. Jul 25, 2017
  19. Jul 24, 2017
    • Jeff Vander Stoep's avatar
      Move domain_deprecated into private policy · 7c34e83f
      Jeff Vander Stoep authored
      This attribute is being actively removed from policy. Since
      attributes are not being versioned, partners must not be able to
      access and use this attribute. Move it from private and verify in
      the logs that rild and tee are not using these permissions.
      
      Bug: 38316109
      Test: build and boot Marlin
      Test: Verify that rild and tee are not being granted any of these
            permissions.
      Merged-In: I31beeb5bdf3885195310b086c1af3432dc6a349b
      Change-Id: I31beeb5bdf3885195310b086c1af3432dc6a349b
      (cherry picked from commit 76aab82c)
      7c34e83f
  20. Jul 18, 2017
  21. Jul 13, 2017
    • Marc Hittinger's avatar
      Revert "Enable lowmemorykiler trace event toggling." · 4d0e433d
      Marc Hittinger authored
      Reverting this commit to fix CTS tests in oc-dr.
      This reverts commit 718e0852.
      
      Test: Tested lowmemorykiller tracing removed via traceur.
      Bug: 62908858
      Merged-In: Ifc1c6ac634b94e060ed1f311049bd37f6fcc8313
      
      Change-Id: Ie462decf32578bbe74a9ec9bdb8bb4ae1b87da29
      4d0e433d
    • Stephen Smalley's avatar
      sepolicy: Define validate_trans permission · 50992311
      Stephen Smalley authored
      
      Kernel commit f9df6458218f4fe ("selinux: export validatetrans
      decisions") introduced a /sys/fs/selinux/validatetrans pseudo file
      for use by userspace file system servers and defined a new validatetrans
      permission to control its use.
      
      Define the new permission in the Android SELinux policy.
      This change only defines the new permission; it does not allow it
      to any domains by default.
      
      This avoids a kernel message warning about the undefined permission on
      the policy load, ala:
      SELinux:  Permission validate_trans in class security not defined in policy.
      
      Test: Policy builds
      
      Change-Id: Ib922a83b7d8f94905207663a72f7a1bc3db8d2c2
      Signed-off-by: default avatarStephen Smalley <sds@tycho.nsa.gov>
      50992311
    • Andreas Gampe's avatar
      App: Allow wrapped app to send pid · 3a5abb3b
      Andreas Gampe authored
      Allow wrapped app to send pid back to zygote.
      
      (cherry picked from commit ee694980)
      
      Bug: 63566721
      Bug: 63635227
      Test: lunch angler-userdebug && m
      Test: lunch angler-user && m
      Test: lunch angler-user && m && fastboot flashall && m cts && cts-tradefed run commandAndExit cts-dev -m CtsWrapWrapDebugTestCases
      Change-Id: Ie1b41c3eb124aa5ee321c124d0121a0e965f0f0e
      3a5abb3b
    • Lorenzo Colitti's avatar
      Revert "Temporarily revert the SELinux policy for persist.netd.stable_secret." · 5b3efd3b
      Lorenzo Colitti authored
      This change must only be submitted when device-specific policies
      have been reverted.
      
      This reverts commit 07e631d2.
      
      Bug: 17613910
      Test: builds
      Change-Id: Ie33e293107bf1eba2498f2422d941544c76b8cad
      Merged-In: I356c39a5dc955b3d7c28d8c7baf2887a17beb272
      5b3efd3b
    • Andreas Gampe's avatar
      App: Allow wrapped app to send pid · ee694980
      Andreas Gampe authored
      Allow wrapped app to send pid back to zygote.
      
      Bug: 63566721
      Bug: 63635227
      Test: lunch angler-userdebug && m
      Test: lunch angler-user && m
      Test: lunch angler-user && m && fastboot flashall && m cts && cts-tradefed run commandAndExit cts-dev -m CtsWrapWrapDebugTestCases
      Change-Id: Ie1b41c3eb124aa5ee321c124d0121a0e965f0f0e
      ee694980
  22. Jul 12, 2017
    • Jeff Vander Stoep's avatar
      suppress logspam · fc283871
      Jeff Vander Stoep authored
      avc: denied { search } for name="tmp" dev="sda13" ino=1867778
      scontext=u:r:isolated_app:s0:c512,c768
      tcontext=u:object_r:shell_data_file:s0 tclass=dir
      
      avc: denied { getattr } for path="/mnt/expand" dev="tmpfs" ino=9850
      scontext=u:r:webview_zygote:s0 tcontext=u:object_r:mnt_expand_file:s0
      tclass=dir
      
      Bug: 63631799
      Test: build. Denial no longer appears in the logs
      Change-Id: Ie8a297c73b0f0e9008a7bf24438ef5354bf893df
      fc283871
    • Peng Xu's avatar
      Allow system to dump sensor hal process · e4968f90
      Peng Xu authored
      Test: tested taking bugreport, sensor HAL traces show up in
            "VM TRACES JUST NOW"
      Test: tested trigger ANR by `adb shell am hang --allow-restart`,
            sensor HAL traces shows up in /data/anr/traces.txt
      Bug: 63096400
      Change-Id: I1d012b9d9810f987be7aaf9d68abfd9c3184ac5c
      e4968f90
  23. Jul 11, 2017
    • Jeff Vander Stoep's avatar
      domain_deprecated: remove rootfs access · a12aad45
      Jeff Vander Stoep authored
      Grant audited permissions collected in logs.
      
      tcontext=platform_app
      avc: granted { getattr } for comm=496E666C6174657254687265616420
      path="/" dev="dm-0" ino=2 scontext=u:r:platform_app:s0:c512,c768
      tcontext=u:object_r:rootfs:s0 tclass=dir
      
      tcontext=system_app
      avc: granted { getattr } for comm="android:ui" path="/" dev="dm-0"
      scontext=u:r:system_app:s0 tcontext=u:object_r:rootfs:s0 tclass=dir
      avc: granted { getattr } for comm="android:ui" path="/" dev="dm-0"
      scontext=u:r:system_app:s0 tcontext=u:object_r:rootfs:s0 tclass=dir
      
      tcontext=update_engine
      avc: granted { getattr } for comm="update_engine" path="/" dev="dm-0"
      ino=2 scontext=u:r:update_engine:s0 tcontext=u:object_r:rootfs:s0
      tclass=dir
      avc: granted { getattr } for comm="update_engine" path="/fstab.foo"
      dev="dm-0" ino=25 scontext=u:r:update_engine:s0
      tcontext=u:object_r:rootfs:s0 tclass=file
      avc: granted { read open } for comm="update_engine" path="/fstab.foo"
      dev="dm-0" ino=25 scontext=u:r:update_engine:s0
      tcontext=u:object_r:rootfs:s0 tclass=file
      
      Bug: 28760354
      Test: build
      Change-Id: I6135eea1d10b903a4a7e69da468097f495484665
      a12aad45
Loading