Skip to content
Snippets Groups Projects
  1. Mar 20, 2018
  2. Mar 19, 2018
  3. Mar 16, 2018
  4. Mar 15, 2018
    • padarshr's avatar
      Init: Enable init to relabel symlinks for recovery_block_device. · bc14ee3c
      padarshr authored
      Allow init the ability to relabel recovery block devices. In the case
      where we have recovery as a chain partition, due to its presence in
      early mount node, init, in first stage itself would require relabel
      permissions for the restorecon operation on recovery block device.
      
      Bug: 73642793
      Test: On bootup, recovery partition gets the appropriate se-label.
            Perform OTA on non-A/B device with recovery as chain partition,
            now the recovery partition gets upgraded successfully, now that
            it has the correct se-label.
      
      Change-Id: I370c510320e78ab78c9c55573073415b4983d0f6
      bc14ee3c
    • Bowgo Tsai's avatar
      Mark some odm properties as vendor-init-settable · a47a1c25
      Bowgo Tsai authored
      Bug: 64195575
      Test: boot a device
      Change-Id: I7f7deb5e2c5c6e0a75cf22eb610a7973b5be0d7e
      a47a1c25
  5. Mar 13, 2018
  6. Mar 12, 2018
    • Sunny Kapdi's avatar
      Bluetooth A2DP offload: Binder call to audio HAL · bc0c88f3
      Sunny Kapdi authored
      Add rule to allow Binder call from Bluetooth process to Bluetooth
      audio HIDL interface running in audio HAL service process.
      
      Bug: 72242910
      Test: Manual; TestTracker/148125
      Change-Id: I1981a78bece10b8e516f218d3edde8b77943d130
      (cherry picked from commit e8cfac90e8bf14466b6431a21bc5ccd4bf6ca3ea)
      bc0c88f3
    • Amit Mahajan's avatar
      Revert "Revert "Move rild from public to vendor."" · 3007344d
      Amit Mahajan authored
      This reverts commit 016f0a58.
      
      Reason for revert: Was temporarily reverted, merging back in with fix.
      
      Test: Basic telephony sanity, treehugger
      Bug: 74486619
      Bug: 36427227
      Merged-in: Ide68726a90d5485c2758673079427407aee1e4f2
      Change-Id: Ide68726a90d5485c2758673079427407aee1e4f2
      (cherry picked from commit 312248ff)
      3007344d
    • Jakub Pawlowski's avatar
      Add ro.hardware.audio.hearing_aid · a4b52dba
      Jakub Pawlowski authored
      Bug: 69623109
      Change-Id: I7d194a3489fc5ff278cef7bebe9bfe6c39d3b2b8
      a4b52dba
    • Amit Mahajan's avatar
      Revert "Move rild from public to vendor." · 58758dc2
      Amit Mahajan authored
      This reverts commit aed57d4e.
      
      Reason for revert: This CL is expected to break pre-submit tests (b/74486619)
      
      Merged-in: I103c3faa1604fddc27b3b4602b587f2d733827b1
      Change-Id: I0eb7a744e0d43ab15fc490e7e7c870d0f44e1401
      58758dc2
    • Bowgo Tsai's avatar
      Adding /odm support · dd6efea2
      Bowgo Tsai authored
      /odm partition isn't mandatory and the following symlinks will exist on
      a device without /odm partition.
      
        /odm/app ->/vendor/odm/app
        /odm/bin ->/vendor/odm/bin
        /odm/etc ->/vendor/odm/etc
        /odm/firmware ->/vendor/odm/firmware
        /odm/framework ->/vendor/odm/framework
        /odm/lib -> /vendor/odm/lib
        /odm/lib64 -> /vendor/odm/lib64
        /odm/overlay -> /vendor/odm/overlay
        /odm/priv-app -> /vendor/odm/priv-app
      
      This CL allows all domains to access the symlinks, also removes the
      Treble compliance neverallows on them because the actual restrictions
      should apply to the real path directly.
      
      Bug: 70678783
      Test: boot a device
      Change-Id: If1522780a13710d8a592272dc688685cbae29f52
      dd6efea2
  7. Mar 10, 2018
    • Amit Mahajan's avatar
      Move rild from public to vendor. · aed57d4e
      Amit Mahajan authored
      Also change the neverallow exceptions to be for hal_telephony_server
      instead of rild.
      
      Test: Basic telephony sanity, treehugger
      Bug: 36427227
      Merged-in: If892b28416d98ca1f9c241c5fcec70fbae35c82e
      Change-Id: If892b28416d98ca1f9c241c5fcec70fbae35c82e
      aed57d4e
  8. Mar 09, 2018
    • Jaekyun Seok's avatar
      Allow public-readable to persist.rcs.supported · 7ff848c5
      Jaekyun Seok authored
      Bug: 74266614
      Test: succeeded building and tested on pixel
      PRODUCT_COMPATIBLE_PROPERTY_OVERRIDE=true
      
      Change-Id: I926eb4316c178a39693300fe983176acfb9cabec
      Merged-In: I926eb4316c178a39693300fe983176acfb9cabec
      (cherry picked from commit 9ddba296)
      7ff848c5
  9. Mar 07, 2018
    • Ruchi Kandoi's avatar
      Add secure_element_device · ea3cf000
      Ruchi Kandoi authored
      Test: eSE initializes at boot
      Bug: 64881253
      Change-Id: Ib2388b7368c790c402c000adddf1488bee492cce
      ea3cf000
    • Kenny Root's avatar
      Add ADB system service · 0b79a179
      Kenny Root authored
      ADB is being separated from USB service since it's not tied to the USB
      transport. This duplicates the usb_service's settings to adb_service for
      this purpose.
      
      Bug: 63820489
      Test: make
      Change-Id: Idbcfbe470d7568f9cba51f0c8d4a8ee9503db93d
      0b79a179
  10. Mar 01, 2018
    • Alan Stokes's avatar
      Allow hal_vibrator access to sysfs_vibrator files. · 17d008ae
      Alan Stokes authored
      We already grant rw file access, but without dir search it's not much
      use.
      
      denied { search } for name="vibrator" dev="sysfs" ino=49606 scontext=u:r:hal_vibrator_default:s0 tcontext=u:object_r:sysfs_vibrator:s0 tclass=dir permissive=0
      
      Bug: 72643420
      Test: Builds, denial gone
      Change-Id: I3513c0a14f0ac1e60517009046e2654f1fc45c66
      17d008ae
    • huans's avatar
      Add shell:fifo_file permission for cameraserver · a6acef9a
      huans authored
      Bug: 73952536
      Test: run cts -m CtsCameraTestCases -t android.hardware.camera2.cts.IdleUidTest#testCameraAccessBecomingInactiveUid
      Change-Id: I508352671367dfa106e80108c3a5c0255b5273b2
      a6acef9a
  11. Feb 28, 2018
    • Jeff Vander Stoep's avatar
      kernel: exempt from vendor_file restrictions · 1242c940
      Jeff Vander Stoep authored
      The kernel is unusual in that it's both a core process, but vendor
      provided. Exempt it from the restriction against accessing files from
      on /vendor. Also, rework the neverallow rule so that it disallows
      opening/modifying files, but allows reading files passed over IPC.
      
      Bug: 68213100
      Test: build (this is a build-time test)
      Change-Id: I2f6b2698ec45d2e8480dc1de47bf12b9b53c4446
      1242c940
    • Haynes Mathew George's avatar
      audio: Enable vndbinder use from hal_audio · ebc7b434
      Haynes Mathew George authored
      Allow hal audio to use vndbinder
      
      Change-Id: I83fc8d5b873bfc4e36f44e423d5740cb5e9739ee
      ebc7b434
  12. Feb 27, 2018
    • Jaekyun Seok's avatar
      Allow vendor-init-settable to persist.sys.zram_enabled · b47efe34
      Jaekyun Seok authored
      persist.sys.zram_enabled is set in vendor/build.prop in taimen and walleye,
      which was added after the initial whitelist.
      go/treble-sysprop-compatibility requires whitelisting such a property to
      allow it to be overridden by vendor/{default|build}.prop.
      
      Bug: 73905119
      Test: succeeded building and test with taimen
      Change-Id: I931182aa05eb90c14df6e2c7cc26913f3874fa18
      b47efe34
    • Alan Stokes's avatar
      Suppress noisy performanced denials in permissive mode. · cf71a5ae
      Alan Stokes authored
      The sheer volume of these can cause confusion.
      
      Sample denials (repeated for many processes):
      denied { getattr } for path="/proc/1/status" dev="proc" ino=24427 scontext=u:r:performanced:s0 tcontext=u:r:init:s0 tclass=file permissive=1
      denied { open } for path="/proc/1" dev="proc" ino=18608 scontext=u:r:performanced:s0 tcontext=u:r:init:s0 tclass=dir permissive=1
      denied { open } for path="/proc/1/status" dev="proc" ino=24427 scontext=u:r:performanced:s0 tcontext=u:r:init:s0 tclass=file permissive=1
      denied { read } for name="status" dev="proc" ino=24427 scontext=u:r:performanced:s0 tcontext=u:r:init:s0 tclass=file permissive=1
      
      Bug: 72643420
      Test: Denials no longer present in permissive mode.
      Change-Id: Ic07b9b0b59ca2122c4843095b63075ab8fd2c70b
      cf71a5ae
    • Alan Stokes's avatar
      Allow init to create & write to vibrator/trigger. · 5a570606
      Alan Stokes authored
      The write is here: https://android.googlesource.com/platform/system/core/+/master/rootdir/init.rc#257.
      
      Denials (on a device with the sysfs_vibrator label properly applied):
      denied { write } for name="vibrator" dev="sysfs" ino=49613 scontext=u:r:init:s0 tcontext=u:object_r:sysfs_vibrator:s0 tclass=dir
      denied { write } for name="trigger" dev="sysfs" ino=49620 scontext=u:r:init:s0 tcontext=u:object_r:sysfs_vibrator:s0 tclass=file
      denied { open } for path="/sys/devices/<redacted>/vibrator/trigger" dev="sysfs" ino=49620 scontext=u:r:init:s0 tcontext=u:object_r:sysfs_vibrator:s0 tclass=file
      
      Bug: b/72643420
      Test: Device boots, denials gone
      
      Change-Id: Ib50d9a8533303daccb1330685e3204bea3fbd8a8
      5a570606
  13. Feb 26, 2018
  14. Feb 23, 2018
    • Robert Sesek's avatar
      Remove rules for starting the webview_zygote as a child of init. · 869562e9
      Robert Sesek authored
      The webview_zygote is now launched as a child-zygote process from the
      main zygote process.
      
      Bug: 63749735
      Test: m
      Test: Launch "Third-party licenses" activity from Settings, and it
            renders correctly via the WebView.
      Merged-In: I9c948b58a969d35d5a5add4b6ab62b8f990645d1
      Change-Id: I153476642cf14883b0dfea0d9f5b3b5e30ac1c08
      869562e9
    • Jeff Vander Stoep's avatar
      Useful neverallow errors · 7636d607
      Jeff Vander Stoep authored
      Neverallow errors include the file name and line number of the
      violated rule. However, if multiple neverallow rules are included
      within a single macro, then the line number is for the entire macro,
      not the individual neverallow rule that is violated. To fix this,
      only include one neverallow rule per macro.
      
      This changes nothing on device, nor does it change the results of
      compilation, it only makes the printed errors more useful.
      
      Bug: 69139821
      Test: build aosp_taimen-userdebug (neverallow rules are build time
          tests)
      
      Change-Id: Id0fc5906431db20e71265c7e9d55fbee4bdf53db
      7636d607
  15. Feb 22, 2018
    • Sandeep Patil's avatar
      Add label for kernel test files and executables · 34e35e9e
      Sandeep Patil authored
      
      This required for kernel to do loopback mounts on filesystem
      images created by the kernel system call tests in LTP.
      
      Add a corresponding neverallow to stop all domains from accessing
      the location at /data/local/tmp/ltp.
      
      Bug: 73220071
      Test: Boot sailfish successfully
      Test: run vts-kernel -m VtsKernelLtp -t syscalls.fchown04
      
      Change-Id: I73f5f14017e22971fc246a05751ba67be4653bca
      Signed-off-by: default avatarSandeep Patil <sspatil@google.com>
      34e35e9e
  16. Feb 21, 2018
    • Primiano Tucci's avatar
      perfetto: Make producer socket MLS-aware · 5ef6669b
      Primiano Tucci authored
      The previous selinux rules obtained via audit2allow didn't really
      work with the case of apps connecting to the producer socket,
      despite all the allow rules being correctly in place.
      This was failing our CTS tests.
      
      The reason for the failure (see denials pasted below) is due to
      Multi Level Security (for multi-user), which was still preventing
      apps form a different level to connect to the traced producer
      socket and write to the shmem buffers they get passed back.
      This CL tags the objects being accessed as mlstrusted.
      CTS tests pass with this CL.
      
      Denials:
      avc: denied { write } for pid=8545 comm="traced_probes" name="traced_producer" dev="tmpfs" ino=23629 scontext=u:r:untrusted_app_25:s0:c512,c768 tcontext=u:object_r:traced_producer_socket:s0 tclass=sock_file permissive=1
      avc: denied { write } for pid=8545 comm="traced_probes" name="traced_producer" dev="tmpfs" ino=23629 scontext=u:r:untrusted_app_25:s0:c512,c768 tcontext=u:object_r:traced_producer_socket:s0 tclass=sock_file permissive=1
      avc: denied { connectto } for pid=8545 comm="traced_probes" path="/dev/socket/traced_producer" scontext=u:r:untrusted_app_25:s0:c512,c768 tcontext=u:r:traced:s0 tclass=unix_stream_socket permissive=1
      avc: denied { connectto } for pid=8545 comm="traced_probes" path="/dev/socket/traced_producer" scontext=u:r:untrusted_app_25:s0:c512,c768 tcontext=u:r:traced:s0 tclass=unix_stream_socket permissive=1
      avc: denied { write } for pid=8545 comm="traced_probes" path=2F6D656D66643A706572666574746F5F73686D656D202864656C6574656429 dev="tmpfs" ino=104483 scontext=u:r:untrusted_app_25:s0:c512,c768 tcontext=u:object_r:traced_tmpfs:s0 tclass=file permissive=1
      
      Change-Id: I1598bc0b07bf39b8d0420b66caf06a4ca884f383
      Bug: 73340039
      Test: CtsPerfettoTestCases
      5ef6669b
  17. Feb 15, 2018
    • Robert Sesek's avatar
      SELinux changes to accomodate starting the webview_zygote as a child of the zygote. · febdfa4e
      Robert Sesek authored
      In this architecture, the system_server instructs the zygote to fork a
      child-zygote to be the webview_zygote. The system_server tells this new
      zygote to listen for fork requests on a random abstract unix socket of
      its choosing.
      
      A follow-up CL will remove the rules for starting webview_zygote via
      init.
      
      Bug: 63749735
      Test: m
      Test: Launch "Third-party licenses" activity from Settings, and it
            renders correctly via the WebView.
      Merged-In: I864743943c11c18de386010ecd4b616721cb9954
      Change-Id: I1c352e47b66eca3a3fa641daa6ecc3e7a889b54e
      febdfa4e
  18. Feb 13, 2018
  19. Feb 09, 2018
  20. Feb 08, 2018
    • Jeff Vander Stoep's avatar
      label /data/vendor{_ce,_de} · d25ccabd
      Jeff Vander Stoep authored
      Restrictions introduced in vendor init mean that new devices
      may not no longer exempt vendor init from writing to system_data_file.
      This means we must introduce a new label for /data/vendor which
      vendor_init may write to.
      
      Bug: 73087047
      Test: build and boot Taimen and Marlin. Complete SUW, enroll fingerprint
          No new denials.
      
      Change-Id: I65f904bb28952d4776aab947515947e14befbe34
      d25ccabd
  21. Feb 07, 2018
    • Tri Vo's avatar
      shell: remove from system_executes_vendor_violators. · bfe51254
      Tri Vo authored
      And grant explicit exemption from system_executes_vendor_violators
      neverallow rules.
      
      This does not change the policy, but is needed to test the violator
      attribute for emptiness.
      
      Bug: 72662597
      Test: build sepolicy
      Change-Id: Iba79bb42e1381b221fe0dc53470f62f8267a4791
      bfe51254
  22. Feb 06, 2018
  23. Feb 05, 2018
    • Mark Salyzyn's avatar
      lmkd: add live-lock killer daemon · d583e596
      Mark Salyzyn authored
      llkd needs the ability to forcibly crash the kernel if
      cause is unlikely to result in an orderly shutdown. It
      also needs to scan /proc/<pid> for additional process
      information.
      
      Test: lmkd_unit_test --gtest_filter=llkd.*
      Bug: 33808187
      Change-Id: I7f158a13814e79d5ec71fe90dbc7461abb521945
      d583e596
    • Jaekyun Seok's avatar
      Add tests for compatible property (1/2) · 64ade65d
      Jaekyun Seok authored
      The feature of compatible property has its own neverallow rules and it
      is enforced on devices launchig with Android P.
      
      This CL changes hal_nfc to hal_nfc_server in neverallow rules because
      sepolicy-analyze doesn't recognize it. Additionally one more neverallow
      rule is added to restrict reading nfc_prop.
      
      Bug: 72013705
      Bug: 72678352
      Test: 'run cts -m CtsSecurityHostTestCases' on walleye with
      ro.product.first_api_level=28
      
      Change-Id: I753cc81f7ca0e4ad6a2434b2a047052678f57671
      64ade65d
    • Carmen Jackson's avatar
      Use a whitelisting strategy for tracefs. · 2c8ca45d
      Carmen Jackson authored
      This changes tracefs files to be default-enabled in debug mode, but
      default-disabled with specific files enabled in user mode.
      
      Bug: 64762598
      Test: Successfully took traces in user mode.
      
      Change-Id: I572ea22253e0c1e42065fbd1d2fd7845de06fceb
      2c8ca45d
    • Andrew Scull's avatar
      authsecret HAL policies. · 64f35fa0
      Andrew Scull authored
      Bug: 71527305
      Test: compile and boot
      Change-Id: I91097bd62d99b8dd9eb6f53060badbaf0f4b8b4a
      (cherry picked from commit 1aedf4b5)
      64f35fa0
Loading