- Oct 02, 2017
-
-
Tri Vo authored
Bug: 65643247 Test: SurfaceFlinger_test passes (except known failures) without selinux denials Change-Id: I6ce185f92e5ad64a172da7d7e12167d8da2ebed0
-
- Sep 29, 2017
-
-
Etan Cohen authored
A parallel Wi-Fi RTT service is being added in parallel. Switch-over will occur once the new service is ready. Bug: 65014552 Test: integration tests Change-Id: Ie4b15592140462af70c7092511aee3f603aaa411
-
- Sep 28, 2017
-
-
Bowgo Tsai authored
Bug: 65570851 Test: boot sailfish Change-Id: I008bf5386595c614236de44131afcda7d3fd6d98 Merged-In: I008bf5386595c614236de44131afcda7d3fd6d98 (cherry picked from commit 82ca9c2e)
-
- Sep 27, 2017
-
-
Dan Cashman authored
(This reverts internal commit: 82ca9c2e) Test: None. Merged-in: I97ffdd48b64ef5c35267387079204512a093a356 Change-Id: I97ffdd48b64ef5c35267387079204512a093a356
-
Jeff Vander Stoep authored
Used to display kernel version in settings app. avc: denied { read } for name="version" dev="proc" scontext=u:r:system_app:s0 tcontext=u:object_r:proc_version:s0 tclass=file permissive=0 Bug: 66985744 Test: kernel version now displayed in settings app. Change-Id: I53f92f63362b900347fd393a40d70ccf5d220d30
-
- Sep 26, 2017
-
-
Dan Cashman authored
Bug: 37916906 Test: Builds 'n' boots. Change-Id: Ia1d86264446ebecc1ca79f32f11354921bc77668 Merged-In: I208ec6a864127a059fb389417a9c6b259d7474cb
-
- Sep 15, 2017
-
-
Tomasz Wasilczyk authored
Bug: 63600413 Test: VTS, instrumentation, audit2allow Test: after cherry-pick - it builds Change-Id: I57c0150a52c13f1ce21f9ae2147e3814aad0fb7e (cherry picked from commit 567b947d)
-
- Sep 14, 2017
-
-
Tri Vo authored
labeled /proc/kmsg as proc_kmsg, changed logd's access from proc to proc_kmsg, and added a compat mapping. Bug: 65643247 Test: device boots without selinux denials to the newly introduced proc_kmsg Test: logd-unit-tests passes Merged-In: I92c9f5694289eb6a94c4d90f14e2de4d46b5228e Change-Id: I92c9f5694289eb6a94c4d90f14e2de4d46b5228e (partial CP of commit 528da6fe)
-
- Sep 11, 2017
-
- Sep 05, 2017
-
-
Steven Moreland authored
This reverts commit 9216a6ad. Bug: 65206688 Merged-In: I8e61b77a1abe9543e4fba77defb8062407676fcf Change-Id: I8e61b77a1abe9543e4fba77defb8062407676fcf
-
- Aug 28, 2017
-
-
Bowgo Tsai authored
Bug: 63910933 Test: boot sailfish in normal mode, checks adbd is started Test: boot sailfish in recovery mode, checks adbd is started Test: boot bullhead in normal mode, checks adbd is started Test: boot bullhead in recovery mode, checks adbd is started Change-Id: I35ed78a15a34626fbd3c21d030e2bf51033f7b79 Merged-In: I35ed78a15a34626fbd3c21d030e2bf51033f7b79 (cherry picked from commit e2423d14)
-
- Aug 24, 2017
-
-
Mark Salyzyn authored
Switch from /data/misc/reboot/last_reboot_reason to persistent Android property persist.sys.boot.reason for indicating why the device is rebooted or shutdown. Introduce protection for all boot reason properties Protect the following properties with these labels ro.boot.bootreason u:object_r:bootloader_boot_reason_prop:s0 sys.boot.reason u:object_r:sys_boot_reason_prop:s0 persist.sys.boot.reason u:object_r:last_boot_reason_prop:s0 Setup the current as-need access rules for each. ToDo: Remove u:object_r:reboot_data_file after internal fixes. Test: system/core/bootstat/boot_reason_test.sh Bug: 64687998 Change-Id: I3771c73933e8ae2d94aee936c7a38b6282611b80
-
- Aug 16, 2017
-
-
Martijn Coenen authored
This is a Qualcomm proprietary service, and does not belong here. Test: boot Marlin Bug: 63391760 Merged-In: If7469051f6cef3e2440f7021ae26c9815ff54820 Change-Id: If7469051f6cef3e2440f7021ae26c9815ff54820
-
- Aug 14, 2017
-
-
Steven Moreland authored
Only seeing this denial in permissive: allow shell screencap_exec:file getattr; Bug: 37565047 Test: adb shell screencap w/o root Test: cts-tradefed run cts-dev --module CtsAadbHostTestCases Merged-In: I9f31d2067e002e7042646ee38dbfc06687481ac7 Change-Id: I9f31d2067e002e7042646ee38dbfc06687481ac7
-
Steven Moreland authored
Only seeing this denial in permissive: allow shell screencap_exec:file getattr; Bug: 37565047 Test: adb shell screencap w/o root Test: cts-tradefed run cts-dev --module CtsAadbHostTestCases Merged-In: I9f31d2067e002e7042646ee38dbfc06687481ac7 Change-Id: I9f31d2067e002e7042646ee38dbfc06687481ac7
-
- Aug 11, 2017
-
-
Josh Gao authored
Add /dev/kmsg_debug on userdebug devices, to allow crash_dump to log crashes to dmesg when logd isn't up yet (or is the one crashing). Bug: http://b/36574794 Test: stop tombstoned; crasher; dmesg Change-Id: I6ffe11bc613e88198893e82712719522b74fe1be
-
Nick Kralevich authored
Android uses hidepid=2 to restrict visibility to other /proc entries on the system. This helps preserve user, application, and system confidentiality by preventing unauthorized access to application metadata, and addresses attacks such as http://www.cs.ucr.edu/~zhiyunq/pub/sec14_android_activity_inference.pdf Ensure the SELinux (weaker) equivalent is being enforced by adding neverallow compile time assertions. TODO: The "shell" user runs as both an Android application, as well as spawned via adb shell. This was a mistake. We should separate out the "shell" Android app into it's own SELinux domain. For now, exclude the shell from this assertion. (The shell Android app is covered by hidepid=2, so there's no leaking of data, but still, it's over privileged today and should be cleaned up. Bug: 23310674 Test: policy compiles. Compile time assertion only. Change-Id: I0e1a6506b2719aabf7eb8127f046c4ada947ba90
-
- Jul 31, 2017
-
-
Ruchi Kandoi authored
type=1400 audit(1501520483.066:14): avc: denied { write } for pid=3330 comm=4173796E635461736B202331 name="property_service" dev="tmpfs" ino=10749 scontext=u:r:nfc:s0 tcontext=u:object_r:property_socket:s0 tclass=sock_file permissive=0 Test: No sepolicy denials Bug: 64010793 Change-Id: I8d73e8e19cd4d0a8c61f1f184820c53e5cc2b6d6
-
- Jul 28, 2017
-
-
Jeff Vander Stoep authored
The only file in /proc/<pid>/ that is world writeable is /proc/<pid>/timerslack_ns so granting selinux write permission to a process's /proc/<pid>/ file only allows writing to timerslack_ns (unless the process is running as system UID). Addresses denials such as: avc: denied { write } for comm="Binder:1117_2" name="timerslack_ns" dev="proc" ino=27908 scontext=u:r:system_server:s0 tcontext=u:r:priv_app:s0 tclass=file permissive=1 Bug: 30675296 Test: build Change-Id: I2cee8ce73a0dc05d771881c36da2fde5411859fb
-
Jeff Vander Stoep authored
long live domain.te! Remove all references. Bug: 28760354 Test: build Merged-In: I99953ecc7d275fdbe8e56d8f47a27d1f9e1cc09a Change-Id: I99953ecc7d275fdbe8e56d8f47a27d1f9e1cc09a
-
- Jul 27, 2017
-
-
Jeff Vander Stoep authored
Clean up the remaining granted permissions in domain_deprecated. avc: granted { read open } for comm="uncrypt" path="/sys/firmware/devicetree/base/firmware/android/fstab/compatible" dev="sysfs" ino=17591 scontext=u:r:uncrypt:s0 tcontext=u:object_r:sysfs:s0 tclass=file avc: granted { getattr } for comm="uncrypt" path="/sys/firmware/devicetree/base/firmware/android/compatible" dev="sysfs" ino=17583 scontext=u:r:uncrypt:s0 tcontext=u:object_r:sysfs:s0 tclass=file vc: granted { read open } for comm="update_engine" path="/sys/firmware/devicetree/base/firmware/android/fstab" dev="sysfs" ino=17258 scontext=u:r:update_engine:s0 tcontext=u:object_r:sysfs:s0 tclass=dir avc: granted { getattr } for comm="update_engine" path="/sys/firmware/devicetree/base/firmware/android/fstab/compatible" dev="sysfs" ino=17259 scontext=u:r:update_engine:s0 tcontext=u:object_r:sysfs:s0 tclass=file Bug: 28760354 Test: build Change-Id: Id318ce84894c1001361923f5205de093a15c1e6a
-
Joel Galenson authored
Test: Built. Change-Id: Ia5f5b52e10e9411cd87901053675d9e77a622529
-
Joel Galenson authored
This should improve performance, as file_contexts is slower than genfs_contexts. Bug: 62413700 Test: Built, flashed, and booted Sailfish. Verified that the files have the correct context and that wifi, web, and atrace work. Merged-In: Ia28707ec565a0792bc882fbffe9e8ab9968535f5 Change-Id: I9546f3af3c95e3443684ae4764881b69987611ef
-
- Jul 26, 2017
-
-
Jeff Vander Stoep authored
type=1400 audit(0.0:6): avc: denied { read } for comm="Thread-5" name="cache" dev="dm-0" ino=13 scontext=u:r:system_server:s0 tcontext=u:object_r:cache_file:s0 tclass=lnk_file permissive=0 Bug: 64067152 Test: build Change-Id: Ie90c0343a834aa87b7ded41f503e05d9b63b3244
-
Jeff Vander Stoep authored
Remove "granted" logspam. Grante the observed permissions to the individual processes that need them and remove the permission from domain_deprecated. avc: granted { read open } for comm="ndroid.settings" path="/proc/version" dev="proc" ino=4026532081 scontext=u:r:system_app:s0 tcontext=u:object_r:proc:s0 tclass=file avc: granted { getattr } for comm=4173796E635461736B202332 path="/proc/pagetypeinfo" dev="proc" ino=4026532129 scontext=u:r:system_app:s0 tcontext=u:object_r:proc:s0 tclass=file avc: granted { read open } for comm="uncrypt" path="/proc/cmdline" dev="proc" ino=4026532072 scontext=u:r:uncrypt:s0 tcontext=u:object_r:proc:s0 tclass=file avc: granted { read open } for comm="update_engine" path="/proc/sys/kernel/random/boot_id" dev="proc" ino=15852829 scontext=u:r:update_engine:s0 tcontext=u:object_r:proc:s0 tclass=file avc: granted { read open } for comm="tiveportallogin" path="/proc/vmstat" dev="proc" ino=4026532130 scontext=u:r:platform_app:s0:c512,c768 tcontext=u:object_r:proc:s0 tclass=file This change is specifically not granting the following since it should not be allowed: avc: granted { read open } for comm="crash_dump64" path="/proc/filesystems" dev="proc" ino=4026532416 scontext=u:r:dex2oat:s0 tcontext=u:object_r:proc:s0 tclass=file avc: granted { read } for comm="crash_dump64" name="filesystems" dev="proc" ino=4026532416 scontext=u:r:dex2oat:s0 tcontext=u:object_r:proc:s0 tclass=file avc: granted { getattr } for comm="crash_dump64" path="/proc/filesystems" dev="proc" ino=4026532416 scontext=u:r:dex2oat:s0 tcontext=u:object_r:proc:s0 tclass=file Bug: 64032843 Bug: 28760354 Test: build Change-Id: Ib309e97b6229bdf013468dca34f606c0e8da96d0
-
- Jul 25, 2017
-
-
Jeff Vander Stoep authored
Logs indicate that all processes that require access already have it. Bug: 28760354 Test: build Change-Id: I8533308d0e5f9bf20e542f8435d70ba7755b4938
-
Andreas Gampe authored
To support libartd test runs. Bug: 15735795 Bug: 62087184 Test: m Test: manual tests with libartd Change-Id: I33a12198566f5d979207e1edd4460b839a0f55f1
-
- Jul 24, 2017
-
-
Jeff Vander Stoep authored
This attribute is being actively removed from policy. Since attributes are not being versioned, partners must not be able to access and use this attribute. Move it from private and verify in the logs that rild and tee are not using these permissions. Bug: 38316109 Test: build and boot Marlin Test: Verify that rild and tee are not being granted any of these permissions. Merged-In: I31beeb5bdf3885195310b086c1af3432dc6a349b Change-Id: I31beeb5bdf3885195310b086c1af3432dc6a349b (cherry picked from commit 76aab82c)
-
- Jul 18, 2017
-
-
Max Bires authored
This is needed for timerslack functionality which should be present in most kernels going forward Test: system_server can write to cameraserver files Change-Id: I85797128b1467d92eb354364de8eb60f8e45c931
-
- Jul 13, 2017
-
-
Stephen Smalley authored
Kernel commit f9df6458218f4fe ("selinux: export validatetrans decisions") introduced a /sys/fs/selinux/validatetrans pseudo file for use by userspace file system servers and defined a new validatetrans permission to control its use. Define the new permission in the Android SELinux policy. This change only defines the new permission; it does not allow it to any domains by default. This avoids a kernel message warning about the undefined permission on the policy load, ala: SELinux: Permission validate_trans in class security not defined in policy. Test: Policy builds Change-Id: Ib922a83b7d8f94905207663a72f7a1bc3db8d2c2 Signed-off-by:
Stephen Smalley <sds@tycho.nsa.gov>
-
Lorenzo Colitti authored
This change must only be submitted when device-specific policies have been reverted. This reverts commit 07e631d2. Bug: 17613910 Test: builds Change-Id: Ie33e293107bf1eba2498f2422d941544c76b8cad Merged-In: I356c39a5dc955b3d7c28d8c7baf2887a17beb272
-
Andreas Gampe authored
Allow wrapped app to send pid back to zygote. Bug: 63566721 Bug: 63635227 Test: lunch angler-userdebug && m Test: lunch angler-user && m Test: lunch angler-user && m && fastboot flashall && m cts && cts-tradefed run commandAndExit cts-dev -m CtsWrapWrapDebugTestCases Change-Id: Ie1b41c3eb124aa5ee321c124d0121a0e965f0f0e
-
- Jul 11, 2017
-
-
Jeff Vander Stoep authored
Grant audited permissions collected in logs. tcontext=platform_app avc: granted { getattr } for comm=496E666C6174657254687265616420 path="/" dev="dm-0" ino=2 scontext=u:r:platform_app:s0:c512,c768 tcontext=u:object_r:rootfs:s0 tclass=dir tcontext=system_app avc: granted { getattr } for comm="android:ui" path="/" dev="dm-0" scontext=u:r:system_app:s0 tcontext=u:object_r:rootfs:s0 tclass=dir avc: granted { getattr } for comm="android:ui" path="/" dev="dm-0" scontext=u:r:system_app:s0 tcontext=u:object_r:rootfs:s0 tclass=dir tcontext=update_engine avc: granted { getattr } for comm="update_engine" path="/" dev="dm-0" ino=2 scontext=u:r:update_engine:s0 tcontext=u:object_r:rootfs:s0 tclass=dir avc: granted { getattr } for comm="update_engine" path="/fstab.foo" dev="dm-0" ino=25 scontext=u:r:update_engine:s0 tcontext=u:object_r:rootfs:s0 tclass=file avc: granted { read open } for comm="update_engine" path="/fstab.foo" dev="dm-0" ino=25 scontext=u:r:update_engine:s0 tcontext=u:object_r:rootfs:s0 tclass=file Bug: 28760354 Test: build Change-Id: I6135eea1d10b903a4a7e69da468097f495484665
-
Robert Benea authored
Allow lmkd to access /dev/memcg once again. Test: lmkd can access memcg bug: 36588803 Change-Id: I1f46b438050d95cebd2fcc495938192305fc9fc9
-
- Jul 10, 2017
-
-
Stephen Smalley authored
Kernel commit 3ba4bf5f1e2c ("selinux: add a map permission check for mmap") added a map permission check on mmap so that we can distinguish memory mapped access (since it has different implications for revocation). The purpose of a separate map permission check on mmap(2) is to permit policy to prohibit memory mapping of specific files for which we need to ensure that every access is revalidated, particularly useful for scenarios where we expect the file to be relabeled at runtime in order to reflect state changes (e.g. cross-domain solution, assured pipeline without data copying). The kernel commit is anticipated to be included in Linux 4.13. This change defines map permission for the Android policy. It mirrors the definition in the kernel classmap by adding it to the common definitions for files and sockets. This will break compatibility for kernels that predate the dynamic class/perm mapping support (< 2.6.33); on such kernels, one would instead need to add map permission to the end of each file and socket access vector. This change also adds map permission to the global macro definitions for file permissions, thereby allowing it in any allow rule that uses these macros, and to specific rules allowing mapping of files from /system and executable types. This should cover most cases where it is needed, although it may still need to be added to specific allow rules when the global macros are not used. Test: Policy builds Change-Id: Iab3ccd2b6587618e68ecab58218838749fe5e7f5 Signed-off-by:
Stephen Smalley <sds@tycho.nsa.gov>
-
Lorenzo Colitti authored
This change did not make it into core sepolicy in time for O. The revert allows devices to define these selinux policies in vendor-specific sepolicy instead of core sepolicy. It is necessary because: 1. It is too late to change property_contexts in O. 2. Adding the netd_stable_secret prop to vendor sepolicy results in a duplicate definition error at compile time. 3. Defining a new vendor-specific context (such as net_stable_secret_vendor_prop) and applying it to persist.netd.stable_secret results in the device not booting due to attempting to apply two different contexts to the same property. Lack of the sepolicy no longer breaks wifi connectivity now that IpManager no longer considers failure to set the stable secret to be a fatal error. Once all interested devices have adopted the vendor sepolicy, this policy can safely be reinstated by reverting said vendor sepolicies in internal master. This reverts commit abb1ba65. Bug: 17613910 Test: bullhead builds, boots, connects to wifi Change-Id: Idffcf78491171c54bca9f93cb920eab9b1c47709
-
- Jul 01, 2017
-
-
Andres Oportus authored
Bug: 62706738 Bug: 34133340 Test: Check that uid_time_in_state can't be read from the shell without root permissions and that "dumpsys batterystats --checkin| grep ctf" shows frequency data (system_server was able to read uid_time_in_state) Change-Id: Ic6a54da4ebcc9e10b0e3af8f14a45d7408e8686e (cherry picked from commit 4dc88795)
-
Tomasz Wasilczyk authored
Bug: b/36863239 Test: manual Change-Id: I7e929926efbb1570ea9723ef3810a511c71dc11a (cherry picked from commit 38f0928f)
-
- Jun 30, 2017
-
-
Jeff Vander Stoep authored
A legitimate call to access(2) is generating a denial. Use the audit_access permission to suppress the denial on just the access() call. avc: denied { write } for name="verified_jars" scontext=u:r:dexoptanalyzer:s0 tcontext=u:object_r:app_data_file:s0:c512,c768 tclass=dir Bug: 62597207 Test: build policy Test: The following cmd succeeds but no longer generates a denial adb shell cmd package compile -r bg-dexopt --secondary-dex \ com.google.android.googlequicksearchbox Change-Id: I7d03df2754c24c039bce11426bf8f317232f5e5f (cherry picked from commit 575e6270)
-