- Jul 25, 2017
-
-
Michael Butler authored
Bug: 63905942 Test: mm -j40 Change-Id: I354ee863475aedd2dc9d2b436a00bcd82931456f (cherry picked from commit 4fc5fb5e521347d65dc921f8c1fb751c66f9a92c)
-
- Jul 18, 2017
-
-
Max Bires authored
This is needed for timerslack functionality which should be present in most kernels going forward Test: system_server can write to cameraserver files Change-Id: I85797128b1467d92eb354364de8eb60f8e45c931
-
- Jul 17, 2017
-
-
Ranjith Kagathi Ananda authored
Remove restriction to restrict only domains in AOSP to use the untrusted_app_all attribute BUG=63167163 Test: Sanity check Change-Id: I9e1b8605fad108f45f988d8198a9a1cadb8dfa5e
-
- Jul 13, 2017
-
-
Marc Hittinger authored
Reverting this commit to fix CTS tests in oc-dr. This reverts commit 718e0852. Test: Tested lowmemorykiller tracing removed via traceur. Bug: 62908858 Merged-In: Ifc1c6ac634b94e060ed1f311049bd37f6fcc8313 Change-Id: Ie462decf32578bbe74a9ec9bdb8bb4ae1b87da29
-
Stephen Smalley authored
Kernel commit f9df6458218f4fe ("selinux: export validatetrans decisions") introduced a /sys/fs/selinux/validatetrans pseudo file for use by userspace file system servers and defined a new validatetrans permission to control its use. Define the new permission in the Android SELinux policy. This change only defines the new permission; it does not allow it to any domains by default. This avoids a kernel message warning about the undefined permission on the policy load, ala: SELinux: Permission validate_trans in class security not defined in policy. Test: Policy builds Change-Id: Ib922a83b7d8f94905207663a72f7a1bc3db8d2c2 Signed-off-by:
Stephen Smalley <sds@tycho.nsa.gov>
-
Andreas Gampe authored
Allow wrapped app to send pid back to zygote. (cherry picked from commit ee694980) Bug: 63566721 Bug: 63635227 Test: lunch angler-userdebug && m Test: lunch angler-user && m Test: lunch angler-user && m && fastboot flashall && m cts && cts-tradefed run commandAndExit cts-dev -m CtsWrapWrapDebugTestCases Change-Id: Ie1b41c3eb124aa5ee321c124d0121a0e965f0f0e
-
Lorenzo Colitti authored
This change must only be submitted when device-specific policies have been reverted. This reverts commit 07e631d2. Bug: 17613910 Test: builds Change-Id: Ie33e293107bf1eba2498f2422d941544c76b8cad Merged-In: I356c39a5dc955b3d7c28d8c7baf2887a17beb272
-
Andreas Gampe authored
Allow wrapped app to send pid back to zygote. Bug: 63566721 Bug: 63635227 Test: lunch angler-userdebug && m Test: lunch angler-user && m Test: lunch angler-user && m && fastboot flashall && m cts && cts-tradefed run commandAndExit cts-dev -m CtsWrapWrapDebugTestCases Change-Id: Ie1b41c3eb124aa5ee321c124d0121a0e965f0f0e
-
- Jul 12, 2017
-
-
Jeff Vander Stoep authored
avc: denied { search } for name="tmp" dev="sda13" ino=1867778 scontext=u:r:isolated_app:s0:c512,c768 tcontext=u:object_r:shell_data_file:s0 tclass=dir avc: denied { getattr } for path="/mnt/expand" dev="tmpfs" ino=9850 scontext=u:r:webview_zygote:s0 tcontext=u:object_r:mnt_expand_file:s0 tclass=dir Bug: 63631799 Test: build. Denial no longer appears in the logs Change-Id: Ie8a297c73b0f0e9008a7bf24438ef5354bf893df
-
Peng Xu authored
Test: tested taking bugreport, sensor HAL traces show up in "VM TRACES JUST NOW" Test: tested trigger ANR by `adb shell am hang --allow-restart`, sensor HAL traces shows up in /data/anr/traces.txt Bug: 63096400 Change-Id: I1d012b9d9810f987be7aaf9d68abfd9c3184ac5c
-
Jeff Vander Stoep authored
Prevent files in /proc from incorrectly having sysfs_type attribute. Rework neverallows so that ueventd has write access to all of /sys which it needs to handle uevents. Bug: 63147833 Test: Build. Flash angler, verify files are correctly labeled and no new denials are in the logs. Change-Id: Ib94d44e78cee0e83e2ac924f1c72e611e8e73558
-
Lorenzo Colitti authored
This re-adds netd_stable_secret_prop to core sepolicy. It was temporarily reverted so it could be added to device-specific policy in oc-dr1-dev. DO NOT SUBMIT until http://ag/2528214 has automerged to master. This reverts commit 9fa11b77. Bug: 17613910 Test: make -j64 bootimage Change-Id: I356c39a5dc955b3d7c28d8c7baf2887a17beb272
-
Jeff Vander Stoep authored
Logs indicate that these rules have already been moved to the domains that need them. Bug: 28760354 Test: build Change-Id: I588a1e7ea7ef984907b79a5a391efb2dcd6e6431 (cherry picked from commit 78b016ee80e48a874511b5bbd6842a2062e049e9)
-
- Jul 11, 2017
-
-
Lorenzo Colitti authored
This change did not make it into core sepolicy in time for O. The revert allows devices to define these selinux policies in vendor-specific sepolicy instead of core sepolicy. It is necessary because: 1. It is too late to change property_contexts in O. 2. Adding the netd_stable_secret prop to vendor sepolicy results in a duplicate definition error at compile time. 3. Defining a new vendor-specific context (such as net_stable_secret_vendor_prop) and applying it to persist.netd.stable_secret results in the device not booting due to attempting to apply two different contexts to the same property. Lack of the sepolicy no longer breaks wifi connectivity now that IpManager no longer considers failure to set the stable secret to be a fatal error. Once all interested devices have adopted the vendor sepolicy, this policy can safely be reinstated by reverting said vendor sepolicies in internal master. This reverts commit abb1ba65. Bug: 17613910 Test: bullhead builds, boots, connects to wifi Change-Id: Idffcf78491171c54bca9f93cb920eab9b1c47709
-
Jeff Vander Stoep authored
Grant audited permissions collected in logs. tcontext=platform_app avc: granted { getattr } for comm=496E666C6174657254687265616420 path="/" dev="dm-0" ino=2 scontext=u:r:platform_app:s0:c512,c768 tcontext=u:object_r:rootfs:s0 tclass=dir tcontext=system_app avc: granted { getattr } for comm="android:ui" path="/" dev="dm-0" scontext=u:r:system_app:s0 tcontext=u:object_r:rootfs:s0 tclass=dir avc: granted { getattr } for comm="android:ui" path="/" dev="dm-0" scontext=u:r:system_app:s0 tcontext=u:object_r:rootfs:s0 tclass=dir tcontext=update_engine avc: granted { getattr } for comm="update_engine" path="/" dev="dm-0" ino=2 scontext=u:r:update_engine:s0 tcontext=u:object_r:rootfs:s0 tclass=dir avc: granted { getattr } for comm="update_engine" path="/fstab.foo" dev="dm-0" ino=25 scontext=u:r:update_engine:s0 tcontext=u:object_r:rootfs:s0 tclass=file avc: granted { read open } for comm="update_engine" path="/fstab.foo" dev="dm-0" ino=25 scontext=u:r:update_engine:s0 tcontext=u:object_r:rootfs:s0 tclass=file Bug: 28760354 Test: build Change-Id: I6135eea1d10b903a4a7e69da468097f495484665
-
Robert Benea authored
Allow lmkd to access /dev/memcg once again. Test: lmkd can access memcg bug: 36588803 Change-Id: I1f46b438050d95cebd2fcc495938192305fc9fc9
-
- Jul 10, 2017
-
-
Stephen Smalley authored
Kernel commit 3ba4bf5f1e2c ("selinux: add a map permission check for mmap") added a map permission check on mmap so that we can distinguish memory mapped access (since it has different implications for revocation). The purpose of a separate map permission check on mmap(2) is to permit policy to prohibit memory mapping of specific files for which we need to ensure that every access is revalidated, particularly useful for scenarios where we expect the file to be relabeled at runtime in order to reflect state changes (e.g. cross-domain solution, assured pipeline without data copying). The kernel commit is anticipated to be included in Linux 4.13. This change defines map permission for the Android policy. It mirrors the definition in the kernel classmap by adding it to the common definitions for files and sockets. This will break compatibility for kernels that predate the dynamic class/perm mapping support (< 2.6.33); on such kernels, one would instead need to add map permission to the end of each file and socket access vector. This change also adds map permission to the global macro definitions for file permissions, thereby allowing it in any allow rule that uses these macros, and to specific rules allowing mapping of files from /system and executable types. This should cover most cases where it is needed, although it may still need to be added to specific allow rules when the global macros are not used. Test: Policy builds Change-Id: Iab3ccd2b6587618e68ecab58218838749fe5e7f5 Signed-off-by:
Stephen Smalley <sds@tycho.nsa.gov>
-
Dan Cashman authored
This CL was accidentally reverted a second time by commit: cb5129f9. Submit it for the third, and final, time. Bug: 62102757 Test: Builds and boots.
-
Jeff Vander Stoep authored
Logs indicate that all processes that require read access have already been granted it. Bug: 28760354 Test: build policy Change-Id: I5826c45f54af32e3d4296df904c8523bb5df5e62 (cherry picked from commit 7fc2b564ce2af2b5f27739a2d9bbb535814fc89e)
-
Jeff Vander Stoep authored
Address the "granted" permissions observed in the logs including: tcontext=uncrypt avc: granted { search } for comm="uncrypt" name="/" dev="mmcblk0p40" ino=2 scontext=u:r:uncrypt:s0 tcontext=u:object_r:cache_file:s0 tclass=dir tcontext=install_recovery avc: granted { search } for comm="applypatch" name="saved.file" scontext=u:r:install_recovery:s0 tcontext=u:object_r:cache_file:s0 tclass=dir avc: granted { read } for comm="applypatch" name="saved.file" dev="mmcblk0p6" ino=14 scontext=u:r:install_recovery:s0 tcontext=u:object_r:cache_file:s0 tclass=file avc: granted { getattr } for comm="applypatch" path="/cache/saved.file" dev="mmcblk0p6" ino=14 scontext=u:r:install_recovery:s0 tcontext=u:object_r:cache_file:s0 tclass=file tcontext=update_engine avc: granted { search } for comm="update_engine" name="cache" dev="sda35" ino=1409025 scontext=u:r:update_engine:s0 tcontext=u:object_r:cache_file:s0 tclass=dir" avc: granted { read } for comm="update_engine" name="update.zip" dev="sda35" ino=1409037 scontext=u:r:update_engine:s0 tcontext=u:object_r:cache_file:s0:c512,c768 tclass=file avc: granted { read } for comm="update_engine" name="cache" dev="dm-0" ino=16 scontext=u:r:update_engine:s0 tcontext=u:object_r:cache_file:s0 tclass=lnk_file Bug: 28760354 Test: build policy. Change-Id: Ia13fe47268df904bd4f815c429a0acac961aed1e (cherry picked from commit 5fd60597d7d04c1861e7d8f3938384efb0384386)
-
Jeff Vander Stoep authored
Logs indicate that all processes that require access already have it. Bug: 28760354 Test: build Change-Id: I3dfa16bf4fba7f653c5f8525e8c565e9e24334a8 (cherry picked from commit 3e5bb807)
-
Lorenzo Colitti authored
This change did not make it into core sepolicy in time for O. The revert allows devices to define these selinux policies in vendor-specific sepolicy instead of core sepolicy. It is necessary because: 1. It is too late to change property_contexts in O. 2. Adding the netd_stable_secret prop to vendor sepolicy results in a duplicate definition error at compile time. 3. Defining a new vendor-specific context (such as net_stable_secret_vendor_prop) and applying it to persist.netd.stable_secret results in the device not booting due to attempting to apply two different contexts to the same property. Lack of the sepolicy no longer breaks wifi connectivity now that IpManager no longer considers failure to set the stable secret to be a fatal error. Once all interested devices have adopted the vendor sepolicy, this policy can safely be reinstated by reverting said vendor sepolicies in internal master. This reverts commit abb1ba65. Bug: 17613910 Test: bullhead builds, boots, connects to wifi Change-Id: Idffcf78491171c54bca9f93cb920eab9b1c47709
-
- Jul 06, 2017
-
-
Joel Galenson authored
When moving SELinux rules from file_contexts to genfs_contexts, we added some genfs rules to label specific files. It turns out that one of those files was the prefix of some other files, and since genfs does prefix-labeling, those other files had their labels changed. To fix this, we are changing the whole tracefs /instances/wifi from debugfs_tracing_instances to debugfs_wifi_tracing (a few of the files already had this label). This simplifies the rules. Bug: 62413700 Test: Built, flashed, and booted two devices. Verified that the files have the correct context and that wifi, camera, and traceur work. Change-Id: Id62db079f439ae8c531b44d1184eea26d5b760c3
-
- Jul 05, 2017
-
-
Jeff Vander Stoep authored
Change fb889f23 "Force expand all hal_* attributes" annotated all hal_* attributes to be expanded to their associated types. However some of these attributes are used in CTS for neverallow checking. Mark these attributes to be preserved. In addition, remove the hacky workaround introduced in oc-dev for b/62658302 where extraneous neverallow rules were introduced to prevent unused or negated attributes from being auto-expanded from policy. Bug: 62658302 Bug: 63135903 Test: cts-tradefed run cts -m CtsSecurityHostTestCases -t \ android.cts.security.SELinuxNeverallowRulesTest armeabi-v7a CtsSecurityHostTestCases completed in 4s. 501 passed, 0 failed, 0 not executed Merged-In: I989def70a16f66e7a18bef1191510793fbe9cb8c Change-Id: I989def70a16f66e7a18bef1191510793fbe9cb8c
-
Joel Galenson authored
The code used to look like this, but in commit 4cae28d4 we replaced the generic regexes to improve performance. Now that we've switched to genfs, this no longer affects performance, so let's simplify the labeling. Bug: 62413700 Test: Built, flashed, and booted two devices. Verified that all of the files have the correct context and that wifi, camera, and traceur work. Change-Id: I1a859d17075fa25543ee090cc7a7478391bc45c1
-
Joel Galenson authored
This should slightly improve performance, as file_contexts is slower than genfs_contexts. Now that the kernel patch enabling genfs labeling of tracefs has landed, we can re-enable this. Bug: 62413700 Test: Built, flashed, and booted two devices. Verified that all of the files have the correct context and that wifi, camera, and traceur work. Change-Id: Ifc1c6ac634b94e060ed1f311049bd37f6fcc8313
-
Jin Qian authored
move them to device-specific files. Bug: 62908056 Change-Id: I299819785d5a64e6ecdde1cd7da472477fe1e295 Merged-In: If92352ea7a70780e9d81ab10963d63e16b793792
-
Jin Qian authored
Test: let fs_mgr format a damaged /data partition Bug: 35219933 Change-Id: I379567772c73e52f532a24acf640c21f2bab5c5b Merged-In: I379567772c73e52f532a24acf640c21f2bab5c5b
-
- Jul 01, 2017
-
-
Andres Oportus authored
Bug: 62706738 Bug: 34133340 Test: Check that uid_time_in_state can't be read from the shell without root permissions and that "dumpsys batterystats --checkin| grep ctf" shows frequency data (system_server was able to read uid_time_in_state) Change-Id: Ic6a54da4ebcc9e10b0e3af8f14a45d7408e8686e (cherry picked from commit 4dc88795)
-
Tomasz Wasilczyk authored
Bug: b/36863239 Test: manual Change-Id: I7e929926efbb1570ea9723ef3810a511c71dc11a (cherry picked from commit 38f0928f)
-
- Jun 30, 2017
-
-
Jeff Vander Stoep authored
A legitimate call to access(2) is generating a denial. Use the audit_access permission to suppress the denial on just the access() call. avc: denied { write } for name="verified_jars" scontext=u:r:dexoptanalyzer:s0 tcontext=u:object_r:app_data_file:s0:c512,c768 tclass=dir Bug: 62597207 Test: build policy Test: The following cmd succeeds but no longer generates a denial adb shell cmd package compile -r bg-dexopt --secondary-dex \ com.google.android.googlequicksearchbox Change-Id: I7d03df2754c24c039bce11426bf8f317232f5e5f (cherry picked from commit 575e6270)
-
- Jun 29, 2017
-
-
Jeff Vander Stoep authored
avc: denied { read write } scontext=u:r:ipacm:s0 tcontext=u:r:system_server:s0 tclass=netlink_netfilter_socket avc: denied { setopt } scontext=u:r:ipacm:s0 tcontext=u:r:system_server:s0 tclass=netlink_netfilter_socket avc: denied { getattr } scontext=u:r:ipacm:s0 tcontext=u:r:system_server:s0 tclass=netlink_netfilter_socket avc: denied { create } for scontext=u:r:system_server:s0 tcontext=u:r:system_server:s0 tclass=netlink_netfilter_socket Bug: 29337859 Bug: 32163131 Test: adb shell getenforce Enforcing adb shell dumpsys connectivity tethering Tethering: ... Log: ... 06-28 11:46:58.841 - SET master tether settings: ON 06-28 11:46:58.857 - [OffloadController] tethering offload started And logs show some signs of happiness: 06-28 11:46:58.853 816 947 I IPAHALService: IPACM was provided two FDs (18, 19) 06-28 11:46:58.853 1200 1571 I zygote64: Looking for service android.hardware.tetheroffload.control@1.0::IOffloadControl/default Change-Id: I0c63bd2de334b4ca40e54efb9df4ed4904667e21
-
- Jun 27, 2017
-
-
Andreas Gampe authored
rc-style powerctl has beem removed. Accordingly, asan_extract now needs access to sys.powerctl directly. (orginally commit: 82672089) Bug: 36458146 Bug: 38241921 Test: Builds and boots. Change-Id: I7d6e583f5e98b671986a2071abf157c86e288a10
-
Neil Fuller authored
This reinstates the selinux changes for the timezone service that were reverted on oc-dr1-dev and undesirably merged down to master. This reverts commit 96c619c8. Test: make Bug: 31008728 Change-Id: Ief2129c409de09b2782881a6556d918af59badd9
-
Tom Cherry authored
This was marked deprecated in 2014 and removed in 2015, let's remove the sepolicy now too. (Originally submitted in commit: 8c60f74d) Bug: 38242876 Test: Builds and boots. Change-Id: I4caa0dbf77956fcbc61a07897242b951c275b502
-
- Jun 26, 2017
-
-
Jeff Vander Stoep authored
A legitimate call to access(2) is generating a denial. Use the audit_access permission to suppress the denial on just the access() call. avc: denied { write } for name="verified_jars" scontext=u:r:dexoptanalyzer:s0 tcontext=u:object_r:app_data_file:s0:c512,c768 tclass=dir Bug: 62597207 Test: build policy Test: The following cmd succeeds but no longer generates a denial adb shell cmd package compile -r bg-dexopt --secondary-dex \ com.google.android.googlequicksearchbox Change-Id: I7d03df2754c24c039bce11426bf8f317232f5e5f
-
Stephen Smalley authored
Linux kernel commit da69a5306ab9 ("selinux: support distinctions among all network address families") triggers a build error if a new address family is added without defining a corresponding SELinux security class. As a result, the smc_socket class was added to the kernel to resolve a build failure as part of merge commit 3051bf36c25d that introduced AF_SMC circa Linux 4.11. Define this security class and its access vector, add it to the socket_class_set macro, and exclude it from webview_zygote like other socket classes. Test: Policy builds Change-Id: Idbb8139bb09c6d1c47f1a76bd10f4ce1e9d939cb Signed-off-by:
Stephen Smalley <sds@tycho.nsa.gov>
-
- Jun 23, 2017
-
-
Jeff Vander Stoep authored
avc: denied { find } for interface=android.hardware.configstore::ISurfaceFlingerConfigs scontext=u:r:system_server:s0 tcontext=u:object_r:hal_configstore_ISurfaceFlingerConfigs:s0 tclass=hwservice_manager permissive=0 Bug: 35197529 Test: Device boots without this denial Change-Id: Ia43bc5879e03a1f2056e373b17cc6533636f98b1
-
Tomasz Wasilczyk authored
Bug: b/36863239 Test: instrumentalization Change-Id: I782693dcda13bd38b45626a65c8eeae552368030
-