Skip to content
Snippets Groups Projects
Select Git revision
  • 2b5a8c8f59d9dff49f273bafbde57d5a7dc2706a
  • bpf-spectre default protected
  • vf-baseline
  • bpf-spectre-baseline
  • pkt-ptr-revert-v1
  • v6.5-rc6-bpf-spectre-nospec
  • master
  • spectector-bpf
  • bpftask protected
  • bpftask-no-unused-args
  • bpftask-master
  • v5.9-bpftask
  • v5.8-amd-17h-em protected
  • v5.8-amd-17h-eas protected
  • freqinv-amd3950x-v5.8
  • v5.8-scale-inv-acc-amd-ryzen-3950x
  • 23186e43-amd-17h-eas protected
  • caffb99b6929-perf-x86-rapl-Enable-RAPL-for-AMD-Fam17h
  • 6a9ee74800a1-amd-17h-eas protected
  • add2fae34926-amd_17h_em
  • 3643c88e5545-Add-support-for-frequency-invariance-for-some-x86
  • v5.7-rc6
22 results

testing

  • Clone with SSH
  • Clone with HTTPS
  • user avatar
    Junio C Hamano authored
    The strbuf_getline() interface allows a byte other than LF or NUL as
    the line terminator, but this is only because I wrote these
    codepaths anticipating that there might be a value other than NUL
    and LF that could be useful when I introduced line_termination long
    time ago.  No useful caller that uses other value has emerged.
    
    By now, it is clear that the interface is overly broad without a
    good reason.  Many codepaths have hardcoded preference to read
    either LF terminated or NUL terminated records from their input, and
    then call strbuf_getline() with LF or NUL as the third parameter.
    
    This step introduces two thin wrappers around strbuf_getline(),
    namely, strbuf_getline_lf() and strbuf_getline_nul(), and
    mechanically rewrites these call sites to call either one of
    them.  The changes contained in this patch are:
    
     * introduction of these two functions in strbuf.[ch]
    
     * mechanical conversion of all callers to strbuf_getline() with
       either '\n' or '\0' as the third parameter to instead call the
       respective thin wrapper.
    
    After this step, output from "git grep 'strbuf_getline('" would
    become a lot smaller.  An interim goal of this series is to make
    this an empty set, so that we can have strbuf_getline_crlf() take
    over the shorter name strbuf_getline().
    
    Signed-off-by: default avatarJunio C Hamano <gitster@pobox.com>
    8f309aeb
    History
    Name Last commit Last update
    ..