- Apr 09, 2018
-
-
Max Bires authored
This will allow adb shell getprop ro.vendor.build.security_patch to properly return the correct build property, whereas previously it was offlimits due to lack of label. Test: adb shell getprop ro.vendor.build.security_patch successfully returns whatever VENDOR_SECURITY_PATCH is defined to be in the Android .mk files Change-Id: Ie8427738125fc7f909ad8d51e4b76558f5544d49
-
Alan Stokes authored
cgroupfs doesn't allow files to be created, so this can't be needed. Also remove redundant neverallow and dontaudit rules. These are now more broadly handled by domain.te. Bug: 74182216 Test: Denials remain silenced. Change-Id: If7eb0e59f567695d987272a2fd36dbc251516e9f (cherry picked from commit 8e8c1093)
-
- Apr 06, 2018
-
-
Yifan Hong authored
This is originally allowed in healthd but the permission was not transfered to health HAL. A typical health HAL implementation is likely to write battery info to kernel logs. Test: device has battery kernel logs with health HAL but without healthd Bug: 77661605 Change-Id: Ib3b5d3fe6bdb3df2a240c85f9d27b863153805d2
-
Yifan Hong authored
This is originally allowed in healthd but the permission was not transfered to health HAL. A typical health HAL implementation is likely to write battery info to kernel logs. Test: device has battery kernel logs with health HAL but without healthd Bug: 77661605 Change-Id: Ib3b5d3fe6bdb3df2a240c85f9d27b863153805d2
-
Alan Stokes authored
cgroupfs doesn't allow files to be created, so this can't be needed. Also remove redundant neverallow and dontaudit rules. These are now more broadly handled by domain.te. Bug: 74182216 Test: Denials remain silenced. Change-Id: If7eb0e59f567695d987272a2fd36dbc251516e9f
-
- Apr 05, 2018
-
-
Kweku Adams authored
Bug: 72177715 Test: flash device and check incident output Change-Id: I16c172caec235d985a6767642134fbd5e5c23912 (cherry picked from commit 985db6d8)
-
- Apr 04, 2018
-
-
Jeff Vander Stoep authored
System components should use the public tagSocket() API, not direct file access to /proc/net/xt_qtaguid/* and /dev/xt_qtaguid. Test: build/boot taimen-userdebug. Use youtube, browse chrome, navigate maps on both cellular and wifi. Bug: 68774956 Change-Id: Id895395de100d8f9a09886aceb0d6061fef832ef
-
Jeff Vander Stoep authored
Remove unecessary access to /proc/net/xt_qtaguid/ctrl and /dev/xt_qtaguid. Bug: 68774956 Test: atest CtsNativeNetTestCases Test: adb root; atest tagSocket Change-Id: If3a1e823be0e342faefff28ecd878189c68a8e92
-
Kweku Adams authored
Bug: 72177715 Test: flash device and check incident output Change-Id: I16c172caec235d985a6767642134fbd5e5c23912
-
- Apr 03, 2018
-
-
Jeff Vander Stoep authored
Test: build Bug: 68774956 Change-Id: I0f9fd87eb41e67e14f35e49eba13e3d1de745250
-
Chenbo Feng authored
The file under /proc/net/xt_qtaguid is going away in future release. Apps should use the provided public api instead of directly reading the proc file. This change will block apps that based on SDK 28 or above to directly read that file and we will delete that file after apps move away from it. Test: Flashed with master branch on marlin, verified phone boot, can browse web, watch youtube video, make phone call and use google map for navigation with wifi on and off. run cts -m CtsNetTestCases -t android.net.cts.TrafficStatsTest run cts -m CtsAppSecurityHostTestCases -t \ android.appsecurity.cts.AppSecurityTests Change-Id: I4c4d6c9ab28b426acef23db53f171de8f20be1dc (cherry picked from commit 5ec8f843)
-
Jeff Vander Stoep authored
This is a partial cherry pick of commit 6231b4d9 'Enforce per-app data protections for targetSdk 28+'. Untrusted_app_27 remains unreachable, but it's existence prevents future merge conflicts. Bug: 63897054 Test: build/boot aosp_walleye-userdebug Change-Id: I64b013874fe87b55f47e817a1279e76ecf86b7c0 Merged-In: I64b013874fe87b55f47e817a1279e76ecf86b7c0 (cherry picked from commit 6231b4d9)
-
Jeff Vander Stoep authored
tagSocket() now results in netd performing these actions on behalf of the calling process. Remove direct access to: /dev/xt_qtaguid /proc/net/xt_qtaguid/ctrl Bug: 68774956 Test: -m CtsAppSecurityHostTestCases -t android.appsecurity.cts.AppSecurityTests -m CtsNativeNetTestCases Test: stream youtube, browse chrome Test: go/manual-ab-ota Change-Id: I6a044f304c3ec4e7c6043aebeb1ae63c9c5a0beb
-
Jeff Tinker authored
Change-Id: Id7823a3130443107beb4d97426807a6395cf6930 related-to-bug:74607984 test:adb bugreport and check for drm trace dumps
-
- Apr 02, 2018
-
-
Jaekyun Seok authored
A default value of persist.sys.sf.native_mode could be set by SoC partners in some devices including some pixels. So it should have vendor_init_settable accessibility. Bug: 74266614 Test: succeeded building and tested with a pixel device with PRODUCT_COMPATIBLE_PROPERTY_OVERRIDE=true. Change-Id: I5d7a029f82505983d21dc722541fb55761a8714d Merged-In: I5d7a029f82505983d21dc722541fb55761a8714d (cherry picked from commit 0dc35873)
-
Andreas Gampe authored
Update for debugfs labeling changes. Update for simpleperf behavior with stack traces (temp file). (cherry picked from commit c8fe29ff) Bug: 73175642 Test: m Test: manual - run profiling, look for logs Merged-In: Ie000a00ef56cc603f498d48d89001f566c03b661 Change-Id: Ie000a00ef56cc603f498d48d89001f566c03b661
-
Andreas Gampe authored
Update for debugfs labeling changes. Update for simpleperf behavior with stack traces (temp file). Bug: 73175642 Test: m Test: manual - run profiling, look for logs Change-Id: Ie000a00ef56cc603f498d48d89001f566c03b661
-
Jiyong Park authored
This reverts commit 942500b9. Bug: 75287236 Test: boot a device Merged-In: If81a2d2a46979ffbd536bb95528c3b4ebe3483df Change-Id: If81a2d2a46979ffbd536bb95528c3b4ebe3483df (cherry picked from commit a6d9d6b6)
-
Jaekyun Seok authored
A default value of persist.sys.sf.native_mode could be set by SoC partners in some devices including some pixels. So it should have vendor_init_settable accessibility. Bug: 74266614 Test: succeeded building and tested with a pixel device with PRODUCT_COMPATIBLE_PROPERTY_OVERRIDE=true. Change-Id: I5d7a029f82505983d21dc722541fb55761a8714d
-
Jiyong Park authored
This reverts commit 942500b9. Bug: 75287236 Test: boot a device Change-Id: If81a2d2a46979ffbd536bb95528c3b4ebe3483df
-
- Mar 30, 2018
-
-
Florian Mayer authored
See also go/perfetto-io-tracing-security. * Grant CAP_DAC_READ_SEARCH to traced_probes. * Allow traced_probes to list selected labels. * Change ext4 and f2fs events to be available on user builds. Bug: 74584014 Change-Id: I891a0209be981d760a828a69e4831e238248ebad
-
- Mar 29, 2018
-
-
Florian Mayer authored
See also go/perfetto-io-tracing-security. * Grant CAP_DAC_READ_SEARCH to traced_probes. * Allow traced_probes to list selected labels. * Change ext4 and f2fs events to be available on user builds. Bug: 74584014 Cherry-picked from aosp/631805 Change-Id: I891a0209be981d760a828a69e4831e238248ebad Merged-In: I891a0209be981d760a828a69e4831e238248ebad
-
Alan Stokes authored
The kernel generates file creation audits when O_CREAT is passed even if the file already exists - which it always does in the cgroup cases. We add neverallow rules to prevent mistakenly allowing unnecessary create access. We also suppress these denials, which just add noise to the log, for the more common culprits. Bug: 72643420 Bug: 74182216 Test: Ran build_policies.sh and checked failures were unrelated. Test: Device still boots, denials gone. Change-Id: I034b41ca70da1e73b81fe90090e656f4a3b542dc (cherry picked from commit 92c149d0)
-
Alan Stokes authored
The kernel generates file creation audits when O_CREAT is passed even if the file already exists - which it always does in the cgroup cases. We add neverallow rules to prevent mistakenly allowing unnecessary create access. We also suppress these denials, which just add noise to the log, for the more common culprits. Bug: 72643420 Bug: 74182216 Test: Ran build_policies.sh and checked failures were unrelated. Test: Device still boots, denials gone. Change-Id: I034b41ca70da1e73b81fe90090e656f4a3b542dc
-
Pawin Vongmasa authored
Test: Builds Bug: 64121714 Bug: 31973802 Change-Id: Id37be8726a8bb297e35bca494964fdbcc48c6a73
-
Alan Stokes authored
In permissive mode we get more spurious denials when O_CREAT is used with an already-existing file. They're harmless so we don't need to audit them. Example denials: denied { add_name } for name="trigger" scontext=u:r:init:s0 tcontext=u:object_r:sysfs_leds:s0 tclass=dir permissive=1 denied { create } for name="trigger" scontext=u:r:init:s0 tcontext=u:object_r:sysfs_leds:s0 tclass=file permissive=1 Bug: 72643420 Bug: 74182216 Test: Device boots, denials gone. Change-Id: I54b1a0c138ff5167f1d1d12c4b0b9e9afaa5bca0 (cherry picked from commit 7d4294cb)
-
- Mar 28, 2018
-
-
Elliott Hughes authored
Bug: http://b/73140330 Test: boots Change-Id: I8fd27c6eb8c99870cb77019ae06bdb46a934ffc9
-
Alan Stokes authored
In permissive mode we get more spurious denials when O_CREAT is used with an already-existing file. They're harmless so we don't need to audit them. Example denials: denied { add_name } for name="trigger" scontext=u:r:init:s0 tcontext=u:object_r:sysfs_leds:s0 tclass=dir permissive=1 denied { create } for name="trigger" scontext=u:r:init:s0 tcontext=u:object_r:sysfs_leds:s0 tclass=file permissive=1 Bug: 72643420 Bug: 74182216 Test: Device boots, denials gone. Change-Id: I54b1a0c138ff5167f1d1d12c4b0b9e9afaa5bca0
-
Jaekyun Seok authored
A default value of persist.radio.multisim.config can be set by SoC vendors, and so vendor-init-settable should be allowed to it. Bug: 73871799 Test: succeeded building and tested with taimen Change-Id: Ie62b91e7e3d7e05425b742838417f1cab7b3fed4 Merged-In: Ie62b91e7e3d7e05425b742838417f1cab7b3fed4 (cherry picked from commit ac8c6e3d)
-
Andreas Gampe authored
Give statsd rights to connect to perfprofd in userdebug. (cherry picked from commit 488030ee) Bug: 73175642 Test: mmma system/extras/perfprofd Merged-In: Idea0a6b757d1b16ec2e6c8719e24900f1e5518fd Change-Id: Idea0a6b757d1b16ec2e6c8719e24900f1e5518fd
-
- Mar 27, 2018
-
-
Tri Vo authored
We only need this change for aosp devices. Internal sepolicy for healthd domain is different and does not need this. Addresses this denial: avc: denied { open } for path="/sys/class/power_supply" dev="sysfs" ino=25340 scontext=u:r:healthd:s0 tcontext=u:object_r:sysfs:s0 tclass=dir permissive=1 Test: $OUT/vendor/etc/selinux/precompiled_sepolicy contains the new permission. Change-Id: Ie47c231af800026fd9d8a1f752253bb338768c13
-
Janis Danisevskis authored
The ConfirmationUI API has a callback interface by which confirmation results are presented to the calling app. This requires keystore to call into apps. Test: Device boots and no more denials when call back is delivered to apps. Bug: 63928580 Change-Id: Ie23211aeb74c39956c3c3b8b32843d35afa1315a
-
Janis Danisevskis authored
The ConfirmationUI API has a callback interface by which confirmation results are presented to the calling app. This requires keystore to call into apps. Test: Device boots and no more denials when call back is delivered to apps. Bug: 63928580 Change-Id: Ie23211aeb74c39956c3c3b8b32843d35afa1315a
-
Andreas Gampe authored
Give statsd rights to connect to perfprofd in userdebug. Test: mmma system/extras/perfprofd Change-Id: Idea0a6b757d1b16ec2e6c8719e24900f1e5518fd
-
Jaekyun Seok authored
A default value of persist.radio.multisim.config can be set by SoC vendors, and so vendor-init-settable should be allowed to it. Bug: 73871799 Test: succeeded building and tested with taimen Change-Id: Ie62b91e7e3d7e05425b742838417f1cab7b3fed4
-
- Mar 26, 2018
-
-
Jeff Vander Stoep authored
Suppress WAI denials from crashdump. Test: build/flash Taimen. Verify no new denials. Bug: 68319037 Change-Id: If39d057cb020def7afe89fd95e049e45cce2ae16 (cherry picked from commit cc0304cf)
-
Jeff Vander Stoep authored
Suppress WAI denials from crashdump. Test: build/flash Taimen. Verify no new denials. Bug: 68319037 Change-Id: If39d057cb020def7afe89fd95e049e45cce2ae16
-
Primiano Tucci authored
This reverts commit 6f2040f8. Reason for revert: not needed anymore after ag/3773705 This was meant to allow system_server toggling the property on/off. Later we realized that we needed a separate property for that (see discussion in b/76077784) and system server happens to have already permissions to write to sys.* properties even without this CL. Reverting because at this point this creates just unnecessary clutter. Change-Id: Ia73d000aad3c4288a5652047dfe10896e231b0b1 Test: perfetto_integrationtests Bug: 76077784
-
- Mar 23, 2018
-
-
Tri Vo authored
Kernel modules are not permitted to be on /system partition. That was one of Treble requirements in O: https://source.android.com/devices/architecture/kernel/modular-kernels#file-locations Bug: 74069409 Test: pixel/nexus devices don't have LKMs in /system, so this change shoudl be harmless. Test: walleye boots without issues from modprobe. Merged-In: I8b3aeb55aacb3c99e0486224161d09a64bb52cd1 Change-Id: I8b3aeb55aacb3c99e0486224161d09a64bb52cd1 (cherry picked from commit 6ef9f523)
-
Jong Wook Kim authored
Add sepolicy rule to grant Wifi HAL permission to use SIOCSIFHWADDR ioctl. This permission is needed to dynamically change MAC address of the device. We are moving the implementation of setting the MAC address from WifiCond to Vendor HAL to give vendors flexibility in supporting Connected MAC Randomization. Will clean up WifiCond sepolicy afterwards. Bug: 74347653 Test: Verified manually Change-Id: I334cefddf385ecb1ee169eb692c4e0060c26d6d9
-