Skip to content
Snippets Groups Projects
  1. Jun 15, 2017
  2. Jun 13, 2017
    • Tom Cherry's avatar
      Add getpgid to system_service and init · c59eb4d8
      Tom Cherry authored
      In libprocessgroup, we want to only send signals once to processes,
      particularly for SIGTERM.  We must send the signal both to all
      processes within a POSIX process group and a cgroup.  To ensure that
      we do not duplicate the signals being sent, we check the processes in
      the cgroup to see if they're in the POSIX process groups that we're
      killing.  If they are, we skip sending a second signal.  This requires
      getpgid permissions, hence this SELinux change.
      
      avc: denied { getpgid } for pid=797 comm="ActivityManager" scontext=u:r:system_server:s0 tcontext=u:r:untrusted_app_25:s0:c512,c768 tclass=process permissive=1
      avc: denied { getpgid } for pid=797 comm="ActivityManager" scontext=u:r:system_server:s0 tcontext=u:r:untrusted_app_25:s0:c512,c768 tclass=process permissive=1
      avc: denied { getpgid } for pid=797 comm="ActivityManager" scontext=u:r:system_server:s0 tcontext=u:r:system_app:s0 tclass=process permissive=1
      avc: denied { getpgid } for pid=797 comm="ActivityManager" scontext=u:r:system_server:s0 tcontext=u:r:system_app:s0 tclass=process permissive=1
      avc: denied { getpgid } for pid=1 comm="init" scontext=u:r:init:s0 tcontext=u:r:zygote:s0 tclass=process permissive=1
      avc: denied { getpgid } for pid=1 comm="init" scontext=u:r:init:s0 tcontext=u:r:zygote:s0 tclass=process permissive=1
      avc: denied { getpgid } for pid=1 comm="init" scontext=u:r:init:s0 tcontext=u:r:system_server:s0 tclass=process permissive=1
      avc: denied { getpgid } for pid=1 comm="init" scontext=u:r:init:s0 tcontext=u:r:system_server:s0 tclass=process permissive=1
      
      Bug: 37853905
      Bug: 62418791
      Test: Boot, kill zygote, reboot
      Change-Id: Ib6c265dbaac8833c47145ae28fb6594ca8545570
      c59eb4d8
  3. Jun 12, 2017
    • Joel Scherpelz's avatar
      SELinux policy for secure persistent netd storage · abb1ba65
      Joel Scherpelz authored
      This is used to persist RFC 7217 stable secrets across device reboots.
      
      First submit caused a merge conflict. This revision replaces netd_prop
      with a more unique name netd_stable_secret_prop.
      
      Test: as follows
          - Manually tested that stable_secret is generated on first use and
            persists until reset of user data partition (factory reset).
          - Tested that "adb shell getprop" was denied access to
            persist.netd.stable_secret after running "adb unroot".
      Bug: 17613910
      
      Change-Id: I0a609c724799a15b1926e62534c16810d34f2275
      abb1ba65
  4. Jun 08, 2017
    • Bartosz Fabianowski's avatar
      Revert "SELinux policy for secure persistent netd storage" · 06486796
      Bartosz Fabianowski authored
      This broke the build on master. See b/17613910#comment17
      for details.
      
      This reverts commit ef1fd98b.
      
      Change-Id: I11f7d463061a9b6340c11827135586266e26f016
      06486796
    • Joel Scherpelz's avatar
      SELinux policy for secure persistent netd storage · ef1fd98b
      Joel Scherpelz authored
      This is used to persist RFC 7217 stable secrets across device reboots.
      
      Test: as follows
          - Manually tested that stable_secret is generated on first use and
            persists until reset of user data partition (factory reset).
          - Tested that "adb shell getprop" was denied access to
            persist.netd.stable_secret after running "adb unroot".
      Bug: 17613910
      
      Change-Id: I4dad00fb189d697aceaffae49ad63987c7e45054
      ef1fd98b
  5. Jun 06, 2017
  6. Jun 05, 2017
  7. Jun 03, 2017
  8. Jun 02, 2017
  9. Jun 01, 2017
  10. May 31, 2017
    • Narayan Kamath's avatar
      SEPolicy: Allow app / system_server to write to dumpstate pipes. · a34781ae
      Narayan Kamath authored
      tombstoned allows dumpstate to install "intercepts" to java trace
      requests for a given process. When an "intercept" is installed, all
      trace output is redirected to a pipe provided by dumpstate instead
      of the default location (usually in /data/anr or /data/tombstone).
      
      Note that these processes are already granted "write" and "getattr"
      on dumpstate:fifo_file in order to communicate with dumpstate; this
      change adds "append" to the existing set of permissions.
      
      Bug: 32064548
      Test: manual
      Change-Id: Iccbd78c59071252fef318589f3e55ece51a3c64c
      a34781ae
    • Narayan Kamath's avatar
      SEPolicy: Changes for new stack dumping scheme. · e628cb5b
      Narayan Kamath authored
      Applications connect to tombstoned via a unix domain socket and request
      an open FD to which they can write their traces. This socket has a new
      label (tombstoned_java_trace_socket) and appdomain and system_server are
      given permissions to connect and write to it.
      
      Apps no longer need permissions to open files under /data/anr/ and
      these permissions will be withdrawn in a future change.
      
      Bug: 32064548
      Test: Manual
      
      Merged-In: I70a3e6e230268d12b454e849fa88418082269c4f
      Change-Id: Ib4b73fc130f4993c44d96c8d68f61b6d9bb2c7d5
      e628cb5b
  11. May 27, 2017
  12. May 26, 2017
  13. May 25, 2017
  14. May 24, 2017
  15. May 22, 2017
  16. May 18, 2017
  17. May 15, 2017
    • Alex Vakulenko's avatar
      SELinux policies for PDX services · c4055f0d
      Alex Vakulenko authored
      Specify per-service rules for PDX transport. Now being able to
      grant permissions to individual services provided by processes,
      not all services of a process.
      
      Also tighter control over which permissions are required for
      client and server for individual components of IPC (endpoints,
      channels, etc).
      
      Bug: 37646189
      Change-Id: I78eb8ae8b6e08105666445a66bfcbd2f1d69d0ea
      Merged-Id: I78eb8ae8b6e08105666445a66bfcbd2f1d69d0ea
      c4055f0d
  18. May 12, 2017
  19. May 11, 2017
  20. May 10, 2017
    • Tao Bao's avatar
      recovery.te: Allow setting sys.usb.ffs.ready. · ce5ca4d0
      Tao Bao authored
      This is needed for devices using configfs, where init listens for
      sys.usb.ffs.ready=1 to config usb_gadget. When recovery starts
      sideloading, minadbd (forked from recovery) sets the property to trigger
      that action.
      
      avc:  denied  { set } for property=sys.usb.ffs.ready pid=541 uid=0 gid=0
      scontext=u:r:recovery:s0 tcontext=u:object_r:ffs_prop:s0
      tclass=property_service
      
      Bug: 35803743
      Test: Device shows up in sideload mode.
      Change-Id: Ie7f1224d3a8650160ac29811f73b8286fbced4f4
      ce5ca4d0
    • Jaesoo Lee's avatar
      configstore: assign label to all minor versions of configstore service · c895f278
      Jaesoo Lee authored
      Added rule:
      
      /(vendor|system/vendor)/bin/hw/android\.hardware\.configstore@1\.[0-9]-service
      u:object_r:hal_configstore_default_exec:s0
      
      Bug: 37727469
      Test: Built and tested on Sailfish
      Change-Id: Icf167fad1c7e601c3662f527d1e3e844ff517b58
      c895f278
  21. May 09, 2017
  22. May 08, 2017
    • Mark Salyzyn's avatar
    • Treehugger Robot's avatar
      07667733
    • Nick Kralevich's avatar
      Further restrict SELinux API access · 14e2e926
      Nick Kralevich authored
      Remove SELinux access from domain_deprecated. Access to SELinux APIs can
      be granted on a per-domain basis.
      
      Remove appdomain access to SELinux APIs. SELinux APIs are not public and
      are not intended for application use. In particular, some exploits poll
      on /sys/fs/selinux/enforce to determine if the attack was successful,
      and we want to ensure that the behavior isn't allowed. This access was
      only granted in the past for CTS purposes, but all the relevant CTS
      tests have been moved to the shell domain.
      
      Bug: 27756382
      Bug: 28760354
      Test: Device boots and no obvious problems. No collected denials.
      Change-Id: Ide68311bd0542671c8ebf9df0326e512a1cf325b
      14e2e926
    • Mark Salyzyn's avatar
      init: add "+passcred" for socket to set SO_PASSCRED · 5045773a
      Mark Salyzyn authored
      In the init scripts for socket, the type can have a suffix of
      "+cred" to request that the socket be bound to report SO_PASSCRED
      credentials on socket transactions.  Here we add socket setopt
      to selinux rules.
      
      Test: gTest logd-unit-tests --gtest_filter=logd.statistics right after boot
            (fails without logd.rc change)
      Bug: 37985222
      Change-Id: I37cdf7eea93c3e8fa52964e765eaf3007e431b1f
      5045773a
  23. May 04, 2017
    • Mikhail Naganov's avatar
      hal_audio: Allow writing dump info into pipes when capturing BR · 9686cbcd
      Mikhail Naganov authored
      The following HAL methods use file descriptors to write dump
      info comprising audioflinger debug dump:
      
      IDevice.debugDump
      IEffectsFactory.debugDump
      IStream.debugDump
      
      Bug: 37993476
      Test: check contents of media.audio_flinger section in
            a bugreport captured on Pixel device
      
      Change-Id: I77d347c019ac93c3ba0d54ce50f0fdc243b04685
      9686cbcd
    • Dimitry Ivanov's avatar
      Allow getattr on tempfs files · bf030965
      Dimitry Ivanov authored
      This is needed by linker to be able to load libraries from memfd
      which currently generated following denial:
      avc: denied { getattr } for path=2F6D656D66643A666F6F626172202864656C6574656429 dev="tmpfs" ino=902079 scontext=u:r:shell:s0 tcontext=u:object_r:shell_tmpfs:s0 tclass=file permissive=0
      
      Bug: http://b/37245203
      Bug: http://b/37916741
      Test: builds
      Change-Id: I5b57b6cada50a62657c8daaaaaa56f1ee9cdb376
      (cherry picked from commit a0d3ff8e)
  24. May 03, 2017
    • William Roberts's avatar
      storaged: add permissions for dumpstate · fd8f305b
      William Roberts authored
      
      The service "storaged" implememnts a dump() interface for
      dumpsys, and thus it needs to write its state to the fd
      provided by dumpstate.
      
      To correct this, and fix dumpstate, allow the permission.
      
      Fixes:
      avc: denied { use } for pid=3298 comm="dumpsys" path="pipe:[33470]" dev="pipefs" ino=33470 scontext=u:r:storaged:s0 tcontext=u:r:dumpstate:s0 tclass=fd permissive=0
      
      Test:
      With a device that has storaged, issue the command:
      $ adb shell dumpstate
      
      Change-Id: I515e20f0328b6edc01ea2a7c53b1d3c4ca0e72ac
      Signed-off-by: default avatarWilliam Roberts <william.c.roberts@intel.com>
      fd8f305b
  25. May 01, 2017
Loading