Skip to content
Snippets Groups Projects
  1. Feb 23, 2018
    • Nick Kralevich's avatar
      Thank you · 46eaa82e
      Nick Kralevich authored
      After 9 amazing years with Android, it's time to try something new.
      I've moved over to Fuchsia (https://en.wikipedia.org/wiki/Google_Fuchsia)
      where I'll be helping define security for a new, experimental operating
      system.
      
      My time in Android has been the most rewarding of my life. I couldn't
      be more proud of our work in creating a trustworthy operating system
      used by billions(!) of people, from rich to poor. It's quotes like this
      which give me the warm fuzzies:
      
        https://threatpost.com/whats-new-in-android-8-0-oreo-security/128061/
      
        "Android O is a big step forward," said Duo Security’s Lady.
        He said with O, Google closes the security gap on the iPhone.
        "It used to be if you cared about security you had to pay a
        premium and buy an iPhone. Soon, even a $50 Android device
        running O will be on par with a $1,000 iPhone X when it comes
        to security."
      
      The platform team is in good hands, with Rene Mayrhofer now leading the
      charge to make Android the most secure, privacy preserving operating
      system in existence. And thank you to the rest of the team for making
      my time in Android so wonderful.
      
      And a special thank you to Stephen Smalley of the Trusted Systems
      Research Group for his leadership and guidance. Android Security would
      not be where it is today without you.
      
      =====
      
      Keeping with the principle of least privilege, this change removes
      myself from the OWNERS file for system/sepolicy. Let us always strive to
      build systems so strong that we ourselves cannot even break into them,
      and so private that people can trust us with their most sensitive data.
      
      =====
      
      Test: Tested every day by billions of users. ;-)
      Change-Id: Ia7d0f3f75fdbd69cc720d02fd5a9b9e92ae607ae
      46eaa82e
    • Robert Sesek's avatar
      Remove rules for starting the webview_zygote as a child of init. · 869562e9
      Robert Sesek authored
      The webview_zygote is now launched as a child-zygote process from the
      main zygote process.
      
      Bug: 63749735
      Test: m
      Test: Launch "Third-party licenses" activity from Settings, and it
            renders correctly via the WebView.
      Merged-In: I9c948b58a969d35d5a5add4b6ab62b8f990645d1
      Change-Id: I153476642cf14883b0dfea0d9f5b3b5e30ac1c08
      869562e9
    • Jeff Vander Stoep's avatar
      Useful neverallow errors · 7636d607
      Jeff Vander Stoep authored
      Neverallow errors include the file name and line number of the
      violated rule. However, if multiple neverallow rules are included
      within a single macro, then the line number is for the entire macro,
      not the individual neverallow rule that is violated. To fix this,
      only include one neverallow rule per macro.
      
      This changes nothing on device, nor does it change the results of
      compilation, it only makes the printed errors more useful.
      
      Bug: 69139821
      Test: build aosp_taimen-userdebug (neverallow rules are build time
          tests)
      
      Change-Id: Id0fc5906431db20e71265c7e9d55fbee4bdf53db
      7636d607
  2. Feb 22, 2018
    • Sandeep Patil's avatar
      Add label for kernel test files and executables · 34e35e9e
      Sandeep Patil authored
      
      This required for kernel to do loopback mounts on filesystem
      images created by the kernel system call tests in LTP.
      
      Add a corresponding neverallow to stop all domains from accessing
      the location at /data/local/tmp/ltp.
      
      Bug: 73220071
      Test: Boot sailfish successfully
      Test: run vts-kernel -m VtsKernelLtp -t syscalls.fchown04
      
      Change-Id: I73f5f14017e22971fc246a05751ba67be4653bca
      Signed-off-by: default avatarSandeep Patil <sspatil@google.com>
      34e35e9e
  3. Feb 21, 2018
    • Robert Sesek's avatar
      Allow zygote to setpgid on webview_zygote. · 63bcf4de
      Robert Sesek authored
      Bug: 73720684
      Bug: 73720684
      Test: m
      Test: BootTest on taimen
      Change-Id: I5a58fd1cce568cc50ba791f445f5c148eb87b474
      63bcf4de
    • Treehugger Robot's avatar
      ba0310ad
    • Primiano Tucci's avatar
      perfetto: Make producer socket MLS-aware · 5ef6669b
      Primiano Tucci authored
      The previous selinux rules obtained via audit2allow didn't really
      work with the case of apps connecting to the producer socket,
      despite all the allow rules being correctly in place.
      This was failing our CTS tests.
      
      The reason for the failure (see denials pasted below) is due to
      Multi Level Security (for multi-user), which was still preventing
      apps form a different level to connect to the traced producer
      socket and write to the shmem buffers they get passed back.
      This CL tags the objects being accessed as mlstrusted.
      CTS tests pass with this CL.
      
      Denials:
      avc: denied { write } for pid=8545 comm="traced_probes" name="traced_producer" dev="tmpfs" ino=23629 scontext=u:r:untrusted_app_25:s0:c512,c768 tcontext=u:object_r:traced_producer_socket:s0 tclass=sock_file permissive=1
      avc: denied { write } for pid=8545 comm="traced_probes" name="traced_producer" dev="tmpfs" ino=23629 scontext=u:r:untrusted_app_25:s0:c512,c768 tcontext=u:object_r:traced_producer_socket:s0 tclass=sock_file permissive=1
      avc: denied { connectto } for pid=8545 comm="traced_probes" path="/dev/socket/traced_producer" scontext=u:r:untrusted_app_25:s0:c512,c768 tcontext=u:r:traced:s0 tclass=unix_stream_socket permissive=1
      avc: denied { connectto } for pid=8545 comm="traced_probes" path="/dev/socket/traced_producer" scontext=u:r:untrusted_app_25:s0:c512,c768 tcontext=u:r:traced:s0 tclass=unix_stream_socket permissive=1
      avc: denied { write } for pid=8545 comm="traced_probes" path=2F6D656D66643A706572666574746F5F73686D656D202864656C6574656429 dev="tmpfs" ino=104483 scontext=u:r:untrusted_app_25:s0:c512,c768 tcontext=u:object_r:traced_tmpfs:s0 tclass=file permissive=1
      
      Change-Id: I1598bc0b07bf39b8d0420b66caf06a4ca884f383
      Bug: 73340039
      Test: CtsPerfettoTestCases
      5ef6669b
    • Carmen Jackson's avatar
      Allow Traceur app to remove trace files. · fa0bf19b
      Carmen Jackson authored
      Bug: 73660835
      Test: With the other commit on this topic, clearing all trace files via
      the app works properly.
      
      Change-Id: I27a4a5a14d9afe817683f1b046a644648a84badc
      fa0bf19b
  4. Feb 16, 2018
  5. Feb 15, 2018
    • Joel Galenson's avatar
      Dontaudit denials caused by race with labeling. · f7ec4138
      Joel Galenson authored
      These denials seem to be caused by a race with the process that labels
      the files.  While we work on fixing them, hide the denials.
      
      Bug: 68864350
      Bug: 70180742
      Test: Built policy.
      Change-Id: I58a32e38e6384ca55e865e9575dcfe7c46b2ed3c
      f7ec4138
    • Robert Sesek's avatar
      SELinux changes to accomodate starting the webview_zygote as a child of the zygote. · febdfa4e
      Robert Sesek authored
      In this architecture, the system_server instructs the zygote to fork a
      child-zygote to be the webview_zygote. The system_server tells this new
      zygote to listen for fork requests on a random abstract unix socket of
      its choosing.
      
      A follow-up CL will remove the rules for starting webview_zygote via
      init.
      
      Bug: 63749735
      Test: m
      Test: Launch "Third-party licenses" activity from Settings, and it
            renders correctly via the WebView.
      Merged-In: I864743943c11c18de386010ecd4b616721cb9954
      Change-Id: I1c352e47b66eca3a3fa641daa6ecc3e7a889b54e
      febdfa4e
  6. Feb 14, 2018
  7. Feb 13, 2018
    • Treehugger Robot's avatar
      1f447485
    • Treehugger Robot's avatar
      5670dd1f
    • Christopher Ferris's avatar
      Allow read-only of new property for malloc hooks. · 6766543a
      Christopher Ferris authored
      Bug: 30561479
      
      Test: Booted on walleye and verified that read denials of the property
      Test: do not generate warnings.
      Change-Id: I61a4a7d3a360a6d27d8986eb8f3f9662272233b1
      (cherry picked from commit 2f35f5ca)
      6766543a
    • Jeff Vander Stoep's avatar
      OWNERS: add tomcherry and bowgotsai · 31e1ddd6
      Jeff Vander Stoep authored
      Test: n/a
      Change-Id: I7041cc0f17ece86c01db1d9c17f68b58473cf27c
      31e1ddd6
    • Treehugger Robot's avatar
    • Bookatz's avatar
      Statsd allow shell in selinux policy · 022ab0e7
      Bookatz authored
      CTS tests need to be able to call, from hostside:
      adb shell cmd stats dump-report (and others)
      On a user build, this will fail because of an selinux policy violation
      from shell. This cl fixes this by granting shell permission.
      
      Similarly, Settings needs to communicate with statsd, so
      system_app-statsd binder calls are given permission.
      
      Bug: 72961153
      Bug: 73255014
      Test: run cts-dev -m CtsStatsdHostTestCases -t android.cts.statsd.atom.HostAtomTests
      Test: manual confirmation
      Change-Id: I6589ab4ef5c91a4a7f78eb97b63d9bb43e3d8f02
      022ab0e7
    • Primiano Tucci's avatar
      Allow perfetto traced_probes to access tracefs on user · b4b31f9d
      Primiano Tucci authored
      Allows the traced_probes daemon to access the core ftrace
      functionalities on user builds. Specifically this involves:
      - Whitelisting the per_cpu/ subdirectory to access:
        1) trace_pipe_raw file to allow perfetto to read the raw
           ftrace buffer (rather than the text-based /trace endpoint)
        2) cpuX/stats and cpuX/buffer_size_kb that allow to
           tune the buffer size per-cpu pipe and to get basic
           statistics about the ftrace buffer (#events, overruns)
      - Whitelistiing the full event directories rather than the
        /enable files. This gives also access to the /format files
        for the events that are already enabled on user builds.
        /format files simply describe the memory layout
        of the binary logs. Example: https://ghostbin.com/paste/f8m4k
      
      This still does NOT allow enabling the events labeled as
      "_debug" (mostly events that return activity on inodes).
      We'll deal with that separately as soon as we get a POC
      of inode resolution and a sensible blacklist/whitelist model.
      
      Bug: 70942310
      Change-Id: Ic15cca0a9d7bc0e45aa48097a94eadef44c333f8
      b4b31f9d
  8. Feb 12, 2018
  9. Feb 09, 2018
  10. Feb 08, 2018
  11. Feb 07, 2018
Loading