Skip to content
Snippets Groups Projects
  1. Feb 14, 2018
    • Jeff Vander Stoep's avatar
      Use SELINUX_IGNORE_NEVERALLOWS flag to disable all tests · 3d4965b2
      Jeff Vander Stoep authored
      The intent of this flag is to disable tests during early device
      bringup so that vendor drops can occur without build breakages.
      When SELINUX_IGNORE_NEVERALLOWS=true also disable labeling tests
      sepolicy_tests, and treble_sepolicy_tests.
      
      Bug: 73322735
      Test: build, verify known tests failures do not cause build breakage.
      Change-Id: I3e7165938d4e34c066bfa0a20e68b7e02dae4a24
      3d4965b2
  2. Feb 07, 2018
  3. Feb 06, 2018
  4. Feb 05, 2018
    • Jaekyun Seok's avatar
      Add tests for compatible property (1/2) · 64ade65d
      Jaekyun Seok authored
      The feature of compatible property has its own neverallow rules and it
      is enforced on devices launchig with Android P.
      
      This CL changes hal_nfc to hal_nfc_server in neverallow rules because
      sepolicy-analyze doesn't recognize it. Additionally one more neverallow
      rule is added to restrict reading nfc_prop.
      
      Bug: 72013705
      Bug: 72678352
      Test: 'run cts -m CtsSecurityHostTestCases' on walleye with
      ro.product.first_api_level=28
      
      Change-Id: I753cc81f7ca0e4ad6a2434b2a047052678f57671
      64ade65d
    • Bowgo Tsai's avatar
      Using a python script to build sepolicy · 741a70a0
      Bowgo Tsai authored
      Current sepolicy CIL files are built by several command-line tools
      in Android.mk. This change extracts some of the build logic into a
      python script to relief the effort in Android.mk.
      
      The first command is `build_sepolicy build_cil`. It's possible to add
      more sub-commands under the build_sepolicy script in the future.
      
      Bug: 64240127
      Test: build bullhead/taimen
      Change-Id: Ie0ae4fc5256a550c72954cde5d5dd213a22d159a
      741a70a0
    • Bowgo Tsai's avatar
      Renames nonplat_* to vendor_* · afbcf21b
      Bowgo Tsai authored
      This change renames the non-platform sepolicy files on a DUT from
      nonplat_* to vendor_*.
      
      It also splits the versioned platform sepolicy from vendor_sepolicy.cil
      to a new file /vendor/etc/selinux/plat_pub_versioned.cil. And only keeps
      vendor customizations in vendor_sepolicy.cil.
      
      Build variable BOARD_SEPOLICY_DIRS is also renamed to
      BOARD_VENDOR_SEPOLICY_DIRS.
      
      Bug: 64240127
      Test: boot bullhead/taimen
      Change-Id: Iea2210c9c8ab30c9ecbcd8146f074e76e90e6943
      afbcf21b
  5. Feb 02, 2018
  6. Jan 31, 2018
    • Bowgo Tsai's avatar
      Using a python script to build sepolicy · 3506ad3f
      Bowgo Tsai authored
      Current sepolicy CIL files are built by several command-line tools
      in Android.mk. This change extracts some of the build logic into a
      python script to relief the effort in Android.mk.
      
      The first command is `build_sepolicy build_cil`. It's possible to add
      more sub-commands under the build_sepolicy script in the future.
      
      Bug: 64240127
      Test: build and boot a device
      Test: checks the content of $OUT/vendor/etc/selinux/vendor_sepolicy.cil
            is the same as before
      Change-Id: I0b64f1088f413172e97b579b4f7799fa392762df
      3506ad3f
    • Bowgo Tsai's avatar
      Renames nonplat_* to vendor_* · 9aa8496f
      Bowgo Tsai authored
      This change renames the non-platform sepolicy files on a DUT from
      nonplat_* to vendor_*.
      
      It also splits the versioned platform sepolicy from vendor_sepolicy.cil
      to a new file /vendor/etc/selinux/plat_pub_versioned.cil. And only keeps
      vendor customizations in vendor_sepolicy.cil.
      
      Build variable BOARD_SEPOLICY_DIRS is also renamed to
      BOARD_VENDOR_SEPOLICY_DIRS.
      
      Bug: 64240127
      Test: boot an existing device
      Change-Id: Iea87a502bc6191cfaf8a2201f29e4a2add4ba7bf
      9aa8496f
  7. Jan 12, 2018
    • Joel Galenson's avatar
      Improve neverallow error messages and allow disabling them on userdebug builds. · 5988b565
      Joel Galenson authored
      This patch adds a flag that can be used to ignore neverallow rules.
      By adding
      SELINUX_IGNORE_NEVERALLOWS := true
      into the BoardConfig.mk file, neverallow violations will be ignored
      silently.  This flag can only be enabled on userdebug and eng builds.
      
      Users of this flag should be very careful.  Since it does not work on
      user builds, it must be disabled to pass CTS, and enabling it for
      too long could hide issues that need to be addressed.
      
      As a happy side effect, this patch should also improve the error
      messages when violating a neverallow rules.  Specifically, the file
      and line number should be correct.
      
      Bug: 70950899
      Bug: 33960443
      Test: Built walleye-{user,eng} with and without this new option and
      a neverallow violation.  Built policy for all targets.
      
      Change-Id: Id0d65123cdd230d6b90faa6bb460d544054bb906
      5988b565
  8. Jan 10, 2018
    • Jaekyun Seok's avatar
      Whitelist exported platform properties · e4971454
      Jaekyun Seok authored
      This CL lists all the exported platform properties in
      private/exported_property_contexts.
      
      Additionally accessing core_property_type from vendor components is
      restricted.
      Instead public_readable_property_type is used to allow vendor components
      to read exported platform properties, and accessibility from
      vendor_init is also specified explicitly.
      
      Note that whitelisting would be applied only if
      PRODUCT_COMPATIBLE_PROPERTY is set on.
      
      Bug: 38146102
      Test: tested on walleye with PRODUCT_COMPATIBLE_PROPERTY=true
      Change-Id: I304ba428cc4ca82668fec2ddeb17c971e7ec065e
      e4971454
  9. Jan 04, 2018
    • Tom Cherry's avatar
      Use property_info_checker instead of checkfc and fc_sort for properties · f68b4c67
      Tom Cherry authored
      1) fc_sort is not needed as there is no reason to sort system
         properties, so this is removed and replaced with a simply copy
      2) Use the new property_info_checker instead of checkfc for
         validating property information.  This supports exact match
         properties and will be extended to verify property schemas in the
         future.
      
      Bug: 36001741
      Test: verify bullhead's property contexts correct
      Test: verify faulty property contexts result in failures
      Change-Id: Id9bbf401f385206e6907449a510e3111424ce59e
      f68b4c67
  10. Dec 07, 2017
    • Bo Hu's avatar
      Revert "Renames nonplat_* to vendor_*" · 283dd9eb
      Bo Hu authored
      This reverts commit 8b562206.
      
      Reason for revert: broke mac build
      
      b/70273082
      
      FAILED: out/target/product/generic_x86/obj/ETC/vendor_sepolicy.cil_intermediates/vendor_sepolicy.cil
      /bin/bash -c "(out/host/darwin-x86/bin/version_policy -b out/target/product/generic_x86/obj/FAKE/selinux_policy_intermediates/plat_pub_policy.cil -t out/target/product/generic_x86/obj/ETC/vendor_sepolicy.cil_intermediates/vendor_policy_raw.cil -n 10000.0 -o out/target/product/generic_x86/obj/ETC/vendor_sepolicy.cil_intermediates/vendor_sepolicy.cil.tmp ) && (grep -Fxv -f out/target/product/generic_x86/obj/ETC/plat_pub_versioned.cil_intermediates/plat_pub_versioned.cil out/target/product/generic_x86/obj/ETC/vendor_sepolicy.cil_intermediates/vendor_sepolicy.cil.tmp > out/target/product/generic_x86/obj/ETC/vendor_sepolicy.cil_intermediates/vendor_sepolicy.cil ) && (out/host/darwin-x86/bin/secilc -m -M true -G -N -c 30 		out/target/product/generic_x86/obj/ETC/plat_sepolicy.cil_intermediates/plat_sepolicy.cil out/target/product/generic_x86/obj/ETC/plat_pub_versioned.cil_intermediates/plat_pub_versioned.cil out/target/product/generic_x86/obj/ETC/10000.0.cil_intermediates/10000.0.cil out/target/product/generic_x86/obj/ETC/vendor_sepolicy.cil_intermediates/vendor_sepolicy.cil -o /dev/null -f /dev/null )"
      Parsing out/target/product/generic_x86/obj/FAKE/selinux_policy_intermediates/plat_pub_policy.cil
      Parsing out/target/product/generic_x86/obj/ETC/vendor_sepolicy.cil_intermediates/vendor_policy_raw.cil
      grep: out of memory
      
      Change-Id: I14f0801fdd6b9be28e53dfcc0f352b844005db59
      283dd9eb
  11. Dec 06, 2017
    • kaichieh's avatar
      Renames nonplat_* to vendor_* · 8b562206
      kaichieh authored
      This change renames the non-platform sepolicy files on a DUT from
      nonplat_* to vendor_*.
      
      It also splits the versioned platform sepolicy from vendor_sepolicy.cil
      to a new file /vendor/etc/selinux/plat_pub_versioned.cil. And only keeps
      vendor customizations in vendor_sepolicy.cil.
      
      Build variable BOARD_SEPOLICY_DIRS is also renamed to
      BOARD_VENDOR_SEPOLICY_DIRS.
      
      Bug: 64240127
      Test: boot an existing device
      Change-Id: I53a9715b2f9ddccd214f4cf9ef081ac426721612
      8b562206
  12. Nov 20, 2017
  13. Nov 10, 2017
  14. Oct 18, 2017
    • Dan Cashman's avatar
      Include 26.0 compat file on system image. · c96721ea
      Dan Cashman authored
      This file is necessary for using an mr1 system image in conjunction
      with an oc-dev vendor image.  This is currently needed by GSI testing,
      for example.
      
      (cherry-pick of commit: 03596f28)
      
      Bug: 66358348
      Test: File is included on system image.
      Change-Id: Ie694061d08acf17453feb596480e42974f8c714c
      c96721ea
  15. Oct 07, 2017
    • Jeff Vander Stoep's avatar
      Allow redeclaring typeattributes · 74b7071b
      Jeff Vander Stoep authored
      Allows partners to add a new attribute definition to their public
      policy without causing a compatibility failure with the AOSP system
      image.
      
      Bug: 67092827
      Bug: 37915794
      Test: build and boot aosp_sailfish with new type declared in public
          policy
      
      Change-Id: I015c26fa7c399423e8a6e7079b5689007d031479
      74b7071b
  16. Oct 05, 2017
    • Jeff Vander Stoep's avatar
      Fix typo and Mac build · e06e4c1e
      Jeff Vander Stoep authored
      FAILED:
      out/target/product/sailfish/obj/ETC/treble_sepolicy_tests_intermediates/treble_sepolicy_tests
      Error: library-path out/host/darwin-x86/lib64/libsepolwrap.so
      does not exist
      
      Note, fixing here instead of reverting to avoid reverting
      changes in CTS.
      
      Test: ctate testing on Mac
      Change-Id: I95f483b152d9bece1a16267cbc49eedb1f902990
      e06e4c1e
  17. Oct 04, 2017
  18. Oct 03, 2017
  19. Oct 02, 2017
  20. Sep 28, 2017
    • Dan Cashman's avatar
      Include 26.0 compat file on system image. · 03596f28
      Dan Cashman authored
      This file is necessary for using an mr1 system image in conjunction
      with an oc-dev vendor image.  This is currently needed by GSI testing,
      for example.
      
      Bug: 66358348
      Test: File is included on system image.
      Change-Id: I3a6b7ed5edf1c07941bbf835e70f2ae8d03fee25
      03596f28
    • Dan Cashman's avatar
      Sync internal master and AOSP sepolicy. · df5469d8
      Dan Cashman authored
      Bug: 37916906
      Test: Builds 'n' boots.
      Change-Id: Ia1d86264446ebecc1ca79f32f11354921bc77668
      Merged-In: I208ec6a864127a059fb389417a9c6b259d7474cb
      df5469d8
  21. Sep 27, 2017
    • William Roberts's avatar
      nonplat_property_contexts: use fc_sort vs sort · 3949fe23
      William Roberts authored
      sort respects locale settings, so the value of LC_ALL can affect
      how sort orders things. This can cause labeling issues.
      
      More information on locale and sort can be found via:
        * locale(1) - man 1 locale
        * sort(1) - man 1 sort
        * https://debbugs.gnu.org/cgi/bugreport.cgi?bug=28539
      
      
      
      Rather than deal with this locale setting use fc_sort on
      property contexts. This also has the side-effect of
      stripping comments, and thus sed can be dropped.
      
      Test: This was tested by:
        * comparing outputs to previous runs
        * compile tested *only*.
      
      Change-Id: I1e1eb4dff76f717b5f82f697e677a108abb69892
      Signed-off-by: default avatarWilliam Roberts <william.c.roberts@intel.com>
      3949fe23
    • William Roberts's avatar
      plat_property_contexts: use fc_sort vs sort · 4b44d249
      William Roberts authored
      sort respects locale settings, so the value of LC_ALL can affect
      how sort orders things. Issues have surfaced when CTS build
      servers locale differs from image build server locale. And thus
      the prologue of property_contexts differs with what CTS was
      expecting.
      
      More information on locale and sort can be found via:
        * locale(1) - man 1 locale
        * sort(1) - man 1 sort
        * https://debbugs.gnu.org/cgi/bugreport.cgi?bug=28539
      
      
      
      Rather than deal with this locale setting use fc_sort on
      property contexts. This also has the side-effect of
      stripping comments, and thus sed can be dropped.
      
      Test: This was tested by:
        * comparing outputs to previous runs
        * booting the x86-64 emulator
      
      Change-Id: I144ef549cc11d9c61849ffc0e1b1b000f1b8d1a8
      Signed-off-by: default avatarWilliam Roberts <william.c.roberts@intel.com>
      4b44d249
  22. Sep 26, 2017
  23. Sep 25, 2017
  24. Sep 23, 2017
  25. Sep 06, 2017
  26. Aug 25, 2017
  27. Aug 23, 2017
    • Michael Wright's avatar
      O MR1 is API 27 · a9bfbbfe
      Michael Wright authored
      Bug: 64982450
      Test: manual
      Change-Id: Ic5d25b8a12271e5bfa71e30843a36fb643b914ff
      a9bfbbfe
    • Jeff Vander Stoep's avatar
      move build dependencies to sepolicy · 13fb5ed3
      Jeff Vander Stoep authored
      Some selinux build packages are defined in embedded.mk,
      others are defined in system/sepolicy/Android.mk. Move all
      to sepolicy as a dependency of the phony package selinux_policy
      which is defined in embedded.mk.
      
      Test: build Marlin (Treble) and Angler (non-Treble)
      Merged-In: Ib0443ad3da600447fbb51f2e9f91de04dcf5f9f6
      Change-Id: Ib0443ad3da600447fbb51f2e9f91de04dcf5f9f6
      13fb5ed3
  28. Aug 14, 2017
    • Dan Cashman's avatar
      Move compatibility files out of prebuilts dir. · 78b3d573
      Dan Cashman authored
      The treble compatibility tests check for policy differences between old
      and new policy.  To do this correctly, we must not modify the policy which
      represents the older policies.  Move the files meant to be changed to a
      different location from the ones that are not meant to be touched to avoid
      any undesired changes to old policy, e.g. commit:
      2bdefd65078d890889672938c6f0d2accdd25bc5
      
      Bug: 36899958
      Test: Build-time tests build.
      Change-Id: I8fa3947cfae756f37556fb34e1654382e2e48372
      78b3d573
  29. Aug 08, 2017
    • Dan Cashman's avatar
      Add 26.0 api compatibility check infrastructure. · 7f7c3b82
      Dan Cashman authored
      Add support to the treble_sepolicy_tests suite that explicitly look at
      the old and current policy versions, as well as the compatibility file,
      to determine if any new types have been added without a compatibility
      entry.  This first test catches the most common and likely changes that
      could change the type label of an object for which vendor policy may have
      needed access.  It also should prove the basis for additional compatibility
      checks between old and new policies.
      
      Bug: 36899958
      Test: Policy builds and tests pass.
      Change-Id: I609c913e6354eb10a04cc1a029ddd9fa0e592a4c
      7f7c3b82
  30. Jul 11, 2017
Loading