Skip to content
Snippets Groups Projects
  1. Apr 10, 2018
    • Joel Galenson's avatar
      Hide sys_rawio SELinux denials. · bf4afae1
      Joel Galenson authored
      We often see the following denials:
      
      avc: denied { sys_rawio } for comm="update_engine" capability=17 scontext=u:r:update_engine:s0 tcontext=u:r:update_engine:s0 tclass=capability permissive=0
      avc: denied { sys_rawio } for comm="boot@1.0-servic" capability=17 scontext=u:r:hal_bootctl_default:s0 tcontext=u:r:hal_bootctl_default:s0 tclass=capability permissive=0
      
      These are benign, so we are hiding them.
      
      Bug: 37778617
      Test: Boot device.
      Change-Id: Iac196653933d79aa9cdeef7670076f0efc97b44a
      bf4afae1
    • Joel Galenson's avatar
      Widen crash_dump dontaudit. · a3b3bdbb
      Joel Galenson authored
      We have seen crash_dump denials for radio_data_file,
      shared_relro_file, shell_data_file, and vendor_app_file.  This commit
      widens an existing dontaudit to include them as well as others that we
      might see.
      
      Test: Boot device.
      Change-Id: I9ad2a2dafa8e73b13c08d0cc6886274a7c0e3bac
      a3b3bdbb
  2. Apr 09, 2018
    • Max Bires's avatar
      Adding labeling for vendor security patch prop · 5cac1aa9
      Max Bires authored
      This will allow adb shell getprop ro.vendor.build.security_patch to
      properly return the correct build property, whereas previously it was
      offlimits due to lack of label.
      
      Test: adb shell getprop ro.vendor.build.security_patch successfully
      returns whatever VENDOR_SECURITY_PATCH is defined to be in the Android
      .mk files
      
      Change-Id: Ie8427738125fc7f909ad8d51e4b76558f5544d49
      5cac1aa9
    • Alan Stokes's avatar
      Installd doesn't need to create cgroup files. · 06bac37f
      Alan Stokes authored
      cgroupfs doesn't allow files to be created, so this can't be needed.
      
      Also remove redundant neverallow and dontaudit rules. These are now
      more broadly handled by domain.te.
      
      Bug: 74182216
      
      Test: Denials remain silenced.
      
      Change-Id: If7eb0e59f567695d987272a2fd36dbc251516e9f
      
      (cherry picked from commit 8e8c1093)
      06bac37f
  3. Apr 06, 2018
    • Yifan Hong's avatar
      hal_health: allow to write kernel logs. · 5ef48cf8
      Yifan Hong authored
      This is originally allowed in healthd but the permission
      was not transfered to health HAL. A typical health HAL
      implementation is likely to write battery info to kernel
      logs.
      
      Test: device has battery kernel logs with health HAL
            but without healthd
      
      Bug: 77661605
      
      Change-Id: Ib3b5d3fe6bdb3df2a240c85f9d27b863153805d2
      5ef48cf8
  4. Apr 04, 2018
  5. Apr 03, 2018
    • Jeff Vander Stoep's avatar
      Rename qtaguid_proc to conform to name conventions · bdf2a9c4
      Jeff Vander Stoep authored
      Test: build
      Bug: 68774956
      Change-Id: I0f9fd87eb41e67e14f35e49eba13e3d1de745250
      bdf2a9c4
    • Chenbo Feng's avatar
      Block SDK 28 app from using proc/net/xt_qtaguid · c411ff70
      Chenbo Feng authored
      The file under /proc/net/xt_qtaguid is going away in future release.
      Apps should use the provided public api instead of directly reading the
      proc file. This change will block apps that based on SDK 28 or above to
      directly read that file and we will delete that file after apps move
      away from it.
      
      Test: Flashed with master branch on marlin, verified phone boot, can
            browse web, watch youtube video, make phone call and use google
            map for navigation with wifi on and off.
            run cts -m CtsNetTestCases -t android.net.cts.TrafficStatsTest
            run cts -m CtsAppSecurityHostTestCases -t \
            		android.appsecurity.cts.AppSecurityTests
      
      Change-Id: I4c4d6c9ab28b426acef23db53f171de8f20be1dc
      (cherry picked from commit 5ec8f843)
      c411ff70
    • Jeff Vander Stoep's avatar
      Add untrusted_app_27 · 3aa7ca56
      Jeff Vander Stoep authored
      This is a partial cherry pick of commit 6231b4d9
      'Enforce per-app data protections for targetSdk 28+'.
      
      Untrusted_app_27 remains unreachable, but it's existence
      prevents future merge conflicts.
      
      Bug: 63897054
      Test: build/boot aosp_walleye-userdebug
      Change-Id: I64b013874fe87b55f47e817a1279e76ecf86b7c0
      Merged-In: I64b013874fe87b55f47e817a1279e76ecf86b7c0
      (cherry picked from commit 6231b4d9)
      3aa7ca56
    • Jeff Vander Stoep's avatar
      Remove deprecated tagSocket() permissions · 0d1e52a5
      Jeff Vander Stoep authored
      tagSocket() now results in netd performing these actions on behalf
      of the calling process.
      
      Remove direct access to:
      /dev/xt_qtaguid
      /proc/net/xt_qtaguid/ctrl
      
      Bug: 68774956
      Test: -m CtsAppSecurityHostTestCases -t android.appsecurity.cts.AppSecurityTests
          -m CtsNativeNetTestCases
      Test: stream youtube, browse chrome
      Test: go/manual-ab-ota
      Change-Id: I6a044f304c3ec4e7c6043aebeb1ae63c9c5a0beb
      0d1e52a5
  6. Apr 02, 2018
    • Andreas Gampe's avatar
      Selinux: Fix perfprofd policy · c8fe29ff
      Andreas Gampe authored
      Update for debugfs labeling changes.
      
      Update for simpleperf behavior with stack traces (temp file).
      
      Bug: 73175642
      Test: m
      Test: manual - run profiling, look for logs
      Change-Id: Ie000a00ef56cc603f498d48d89001f566c03b661
      c8fe29ff
    • Jaekyun Seok's avatar
      Allow vendor_init_settable for persist.sys.sf.native_mode · 0dc35873
      Jaekyun Seok authored
      A default value of persist.sys.sf.native_mode could be set by SoC
      partners in some devices including some pixels.
      So it should have vendor_init_settable accessibility.
      
      Bug: 74266614
      Test: succeeded building and tested with a pixel device with
      PRODUCT_COMPATIBLE_PROPERTY_OVERRIDE=true.
      
      Change-Id: I5d7a029f82505983d21dc722541fb55761a8714d
      0dc35873
    • Jiyong Park's avatar
      Reland "Allow dexopt to follow /odm/lib(64) symlinks."" · a6d9d6b6
      Jiyong Park authored
      This reverts commit 942500b9.
      
      Bug: 75287236
      Test: boot a device
      Change-Id: If81a2d2a46979ffbd536bb95528c3b4ebe3483df
      a6d9d6b6
  7. Mar 30, 2018
    • Florian Mayer's avatar
      SELinux changes for I/O tracing. · 9fcf22bb
      Florian Mayer authored
      See also go/perfetto-io-tracing-security.
      
      * Grant CAP_DAC_READ_SEARCH to traced_probes.
      * Allow traced_probes to list selected labels.
      * Change ext4 and f2fs events to be available on user builds.
      
      Bug: 74584014
      Change-Id: I891a0209be981d760a828a69e4831e238248ebad
      9fcf22bb
  8. Mar 29, 2018
    • Alan Stokes's avatar
      Suppress harmless denials for file creation in cgroupfs. · 832a7042
      Alan Stokes authored
      The kernel generates file creation audits when O_CREAT is passed even
      if the file already exists - which it always does in the cgroup cases.
      
      We add neverallow rules to prevent mistakenly allowing unnecessary
      create access. We also suppress these denials, which just add noise to
      the log, for the more common culprits.
      
      Bug: 72643420
      Bug: 74182216
      
      Test: Ran build_policies.sh and checked failures were unrelated.
      Test: Device still boots, denials gone.
      Change-Id: I034b41ca70da1e73b81fe90090e656f4a3b542dc
      (cherry picked from commit 92c149d0)
      832a7042
    • Alan Stokes's avatar
      Stop O_CREAT logspam in permissive mode. · 19425d3e
      Alan Stokes authored
      In permissive mode we get more spurious denials when O_CREAT is used
      with an already-existing file. They're harmless so we don't need to
      audit them.
      
      Example denials:
      denied { add_name } for name="trigger" scontext=u:r:init:s0 tcontext=u:object_r:sysfs_leds:s0 tclass=dir permissive=1
      denied { create } for name="trigger" scontext=u:r:init:s0 tcontext=u:object_r:sysfs_leds:s0 tclass=file permissive=1
      
      Bug: 72643420
      Bug: 74182216
      
      Test: Device boots, denials gone.
      Change-Id: I54b1a0c138ff5167f1d1d12c4b0b9e9afaa5bca0
      (cherry picked from commit 7d4294cb)
      19425d3e
  9. Mar 28, 2018
  10. Mar 27, 2018
    • Tri Vo's avatar
      Fix aosp healthd. · dd7d5a70
      Tri Vo authored
      We only need this change for aosp devices. Internal sepolicy for healthd
      domain is different and does not need this.
      
      Addresses this denial:
      avc: denied { open } for path="/sys/class/power_supply" dev="sysfs"
      ino=25340 scontext=u:r:healthd:s0 tcontext=u:object_r:sysfs:s0
      tclass=dir permissive=1
      
      Test: $OUT/vendor/etc/selinux/precompiled_sepolicy contains the new
      permission.
      Change-Id: Ie47c231af800026fd9d8a1f752253bb338768c13
      dd7d5a70
    • Janis Danisevskis's avatar
      Keystore needs to be able to call apps · 3de9cd95
      Janis Danisevskis authored
      The ConfirmationUI API has a callback interface by which confirmation
      results are presented to the calling app. This requires keystore to call
      into apps.
      
      Test: Device boots and no more denials when call back is delivered to
            apps.
      Bug: 63928580
      Change-Id: Ie23211aeb74c39956c3c3b8b32843d35afa1315a
      3de9cd95
    • Andreas Gampe's avatar
      Statsd: Allow statsd to contact perfprofd in userdebug · 488030ee
      Andreas Gampe authored
      Give statsd rights to connect to perfprofd in userdebug.
      
      Test: mmma system/extras/perfprofd
      Change-Id: Idea0a6b757d1b16ec2e6c8719e24900f1e5518fd
      488030ee
    • Jaekyun Seok's avatar
      Allow vendor-init-settable to persist.radio.multisim.config · ac8c6e3d
      Jaekyun Seok authored
      A default value of persist.radio.multisim.config can be set by SoC
      vendors, and so vendor-init-settable should be allowed to it.
      
      Bug: 73871799
      Test: succeeded building and tested with taimen
      Change-Id: Ie62b91e7e3d7e05425b742838417f1cab7b3fed4
      ac8c6e3d
  11. Mar 26, 2018
    • Jeff Vander Stoep's avatar
      crashdump: cleanup logs · 627ba82b
      Jeff Vander Stoep authored
      Suppress WAI denials from crashdump.
      
      Test: build/flash Taimen. Verify no new denials.
      Bug: 68319037
      Change-Id: If39d057cb020def7afe89fd95e049e45cce2ae16
      (cherry picked from commit cc0304cf)
      627ba82b
    • Primiano Tucci's avatar
      Revert "Allow system server to set persist.traced.enable" · 4f673cf4
      Primiano Tucci authored
      This reverts commit 6f2040f8.
      
      Reason for revert: not needed anymore after ag/3773705
      This was meant to allow system_server toggling the property on/off.
      Later we realized that we needed a separate property for that 
      (see discussion in b/76077784) and system server happens to
      have already permissions to write to sys.* properties even without
      this CL.
      Reverting because at this point this creates just unnecessary clutter.
      
      Change-Id: Ia73d000aad3c4288a5652047dfe10896e231b0b1
      Test: perfetto_integrationtests
      Bug: 76077784
      4f673cf4
  12. Mar 23, 2018
    • Jong Wook Kim's avatar
      Wifi HAL SIOCSIFHWADDR sepolicy · 04133651
      Jong Wook Kim authored
      Add sepolicy rule to grant Wifi HAL permission to use SIOCSIFHWADDR
      ioctl. This permission is needed to dynamically change MAC address of
      the device.
      
      We are moving the implementation of setting the MAC address from
      WifiCond to Vendor HAL to give vendors flexibility in supporting
      Connected MAC Randomization. Will clean up WifiCond sepolicy afterwards.
      
      Bug: 74347653
      Test: Verified manually
      Change-Id: I334cefddf385ecb1ee169eb692c4e0060c26d6d9
      04133651
    • Jaekyun Seok's avatar
      Allow vendor-init-settable and public-readable to ro.config.low_ram · 7dd2e025
      Jaekyun Seok authored
      ro.config.low_ram should be set on Android Go devices by SoC vendors,
      and the value can be read by vendor components.
      
      Bug: 76132948
      Bug: 75987246
      Test: succeeded building and tested with taimen
      Change-Id: I6ac98fa58cf641da4565d6277898fc5e5e6ceca1
      7dd2e025
  13. Mar 21, 2018
  14. Mar 20, 2018
  15. Mar 19, 2018
    • Tri Vo's avatar
      silence innocuous denials to /proc and /sys · 09b1d962
      Tri Vo authored
      Bug: 74182216
      Test: build policy
      Change-Id: Idf90c1a96943266d52508ce72b8554d8b5c594c9
      09b1d962
    • Tri Vo's avatar
      proc_type attribute for files under /proc. · 41bf08e5
      Tri Vo authored
      With this attribute it will be easier to reference /proc files.
      
      Bug: 74182216
      Test: policy builds
      Change-Id: I5b7da508d821e45f122832261a742a201e8fdf2c
      41bf08e5
    • Hector Dearman's avatar
      Allow system server to set persist.traced.enable · 6f2040f8
      Hector Dearman authored
      To enable/disable the traced and traced_probes deamons remotely we would
      like system server to be able to set persist.traced.enable.
      See also ag/3736001.
      
      Denial:
      selinux: avc: denied { set } for
      property=persist.traced.enable
      pid=1606 uid=1000 gid=1000
      scontext=u:r:system_server:s0
      tcontext=u:object_r:default_prop:s0 tclass=property_service
      permissive=0\x0a
      
      Run:
      $ adb shell 'ps -A | grep traced'
      Should see traced.
      $ adb shell 'settings put global sys_traced 0'
      $ adb shell 'ps -A | grep traced'
      Should no longer see traced.
      
      Test: See above.
      Change-Id: I245b7df3853cabeb0e75db41fb4facaa178ab8f1
      6f2040f8
    • Bowgo Tsai's avatar
      Allow dexopt to follow /odm/lib(64) symlinks. · 88cd813f
      Bowgo Tsai authored
      Several /odm/* symlinks are added in the following change, to fallback
      to /vendor/odm/* when there is no /odm partition on the device.
      
        https://android-review.googlesource.com/#/c/platform/system/sepolicy/+/638159/
      
      This change allows dexopt operations to 'getattr' those symlinks during
      OTA.
      
      Bug: 75287236
      Test: boot a device
      Change-Id: I2710ce5e2c47eb1a3432123ab49f1b6f3dcb4ffe
      88cd813f
  16. Mar 16, 2018
  17. Mar 15, 2018
    • padarshr's avatar
      Init: Enable init to relabel symlinks for recovery_block_device. · bc14ee3c
      padarshr authored
      Allow init the ability to relabel recovery block devices. In the case
      where we have recovery as a chain partition, due to its presence in
      early mount node, init, in first stage itself would require relabel
      permissions for the restorecon operation on recovery block device.
      
      Bug: 73642793
      Test: On bootup, recovery partition gets the appropriate se-label.
            Perform OTA on non-A/B device with recovery as chain partition,
            now the recovery partition gets upgraded successfully, now that
            it has the correct se-label.
      
      Change-Id: I370c510320e78ab78c9c55573073415b4983d0f6
      bc14ee3c
    • Bowgo Tsai's avatar
      Mark some odm properties as vendor-init-settable · a47a1c25
      Bowgo Tsai authored
      Bug: 64195575
      Test: boot a device
      Change-Id: I7f7deb5e2c5c6e0a75cf22eb610a7973b5be0d7e
      a47a1c25
Loading