Skip to content
Snippets Groups Projects
  1. Mar 09, 2015
    • dcashman's avatar
      Only allow system_server to send commands to zygote. · 8f81dcad
      dcashman authored
      Add neverallow rules to ensure that zygote commands are only taken from
      system_server.
      
      Also remove the zygote policy class which was removed as an object manager in
      commit: ccb3424639821b5ef85264bc5836451590e8ade7
      
      Bug: 19624279
      
      Change-Id: I1c925d7facf19b3953b5deb85d992415344c4c9f
      8f81dcad
    • Nick Kralevich's avatar
      system_server: allow handling app generated unix_stream_sockets · 0560e75e
      Nick Kralevich authored
      Allow system server to handle already open app unix_stream_sockets.
      This is needed to support system_server receiving a socket
      created using socketpair(AF_UNIX, SOCK_STREAM) and
      socketpair(AF_UNIX, SOCK_SEQPACKET). Needed for future Android
      functionality.
      
      Addresses the following denial:
      
        type=1400 audit(0.0:9): avc: denied { read write } for path="socket:[14911]" dev="sockfs" ino=14911 scontext=u:r:system_server:s0 tcontext=u:r:platform_app:s0:c512,c768 tclass=unix_stream_socket permissive=0
      
      Bug: 19648474
      Change-Id: I4644e318aa74ada4d98b7f49a41d13a9b9584f39
      0560e75e
  2. Mar 05, 2015
    • Nick Kralevich's avatar
      Eliminate CAP_SYS_MODULE from system_server · 92b10ddb
      Nick Kralevich authored
      Right now, the system_server has the CAP_SYS_MODULE capability.  This allows the
      system server to install kernel modules.  Effectively, system_server is one
      kernel module load away from full root access.
      
      Most devices don't need this capability. Remove this capability from
      the core SELinux policy. For devices which require this capability,
      they can add it to their device-specific SELinux policy without making
      any framework code changes.
      
      In particular, most Nexus devices ship with monolithic kernels, so this
      capability isn't needed on those devices.
      
      Bug: 7118228
      Change-Id: I7f96cc61da8b2476f45ba9570762145778d68cb3
      92b10ddb
  3. Mar 03, 2015
    • dcashman's avatar
      Record observed system_server servicemanager service requests. · 23f33615
      dcashman authored
      Also formally allow dumpstate access to all services and grant system_server
      access to address the following non-system_server_service entries:
      
      avc:  granted  { find } for service=drm.drmManager scontext=u:r:system_server:s0 tcontext=u:object_r:drmserver_service:s0 tclass=service_manager
      avc:  granted  { find } for service=nfc scontext=u:r:system_server:s0 tcontext=u:object_r:nfc_service:s0 tclass=service_manager
      
      Bug: 18106000
      Change-Id: Iad16b36acf44bce52c4824f8b53c0e7731c25602
      23f33615
  4. Feb 25, 2015
    • Nick Kralevich's avatar
      Revert /proc/net related changes · 5cf3994d
      Nick Kralevich authored
      Revert the tightening of /proc/net access. These changes
      are causing a lot of denials, and I want additional time to
      figure out a better solution.
      
      Addresses the following denials (and many more):
      
        avc: denied { read } for comm="SyncAdapterThre" name="stats" dev="proc" ino=X scontext=u:r:untrusted_app:s0:c512,c768 tcontext=u:object_r:proc_net:s0 tclass=file
        avc: denied { read } for comm="facebook.katana" name="iface_stat_fmt" dev="proc" ino=X scontext=u:r:untrusted_app:s0:c512,c768 tcontext=u:object_r:proc_net:s0 tclass=file
        avc: denied { read } for comm="IntentService[C" name="if_inet6" dev="proc" ino=X scontext=u:r:untrusted_app:s0:c512,c768 tcontext=u:object_r:proc_net:s0 tclass=file
        avc: denied { read } for comm="dumpstate" name="iface_stat_all" dev="proc" ino=X scontext=u:r:dumpstate:s0 tcontext=u:object_r:proc_net:s0 tclass=file
      
      This reverts commit 0f0324cc
      and commit 99940d1a
      
      Bug: 9496886
      Bug: 19034637
      Change-Id: I436a6e3638ac9ed49afbee214e752fe2b0112868
      5cf3994d
  5. Jan 30, 2015
    • Nick Kralevich's avatar
      system_server: neverallow dex2oat exec · 361cdaff
      Nick Kralevich authored
      system_server should never be executing dex2oat. This is either
      a bug (for example, bug 16317188), or represents an attempt by
      system server to dynamically load a dex file, something we don't
      want to allow.
      
      This change adds a compile time assertion which will detect
      if an allow rule granting this access is ever added.
      No new rules are added or deleted as a result of this change.
      This neverallow rule is automatically enforced via CTS.
      
      Bug: 16317188
      Change-Id: Id783e05d9f48d48642dbb89d9c78be4aae8af70c
      361cdaff
  6. Jan 17, 2015
    • dcashman's avatar
      Record service accesses. · 566e8fe2
      dcashman authored
      Reduce logspam and record further observed service connections.
      
      Bug: 18106000
      Change-Id: I9a57e4bb8f1c8e066861719fb208c691498842a8
      566e8fe2
  7. Jan 15, 2015
    • dcashman's avatar
      Remove known system_server service accesses from auditing. · c631ede7
      dcashman authored
      Address observed  audit logs of the form:
      granted  { find } for service=XXX scontext=u:r:YYY:s0:c512,c768 tcontext=u:object_r:XXX_service:s0 tclass=service_manager
      
      in order to record existing relationships with services.
      
      Bug: 18106000
      Change-Id: I99a68f329c17ba67ebf3b87729b8405bdc925ef4
      c631ede7
  8. Jan 14, 2015
    • Nick Kralevich's avatar
      remove /proc/net read access from domain.te · 99940d1a
      Nick Kralevich authored
      SELinux domains wanting read access to /proc/net need to
      explicitly declare it.
      
      TODO: fixup the ListeningPortsTest cts test so that it's not
      broken.
      
      Bug: 9496886
      Change-Id: Ia9f1214348ac4051542daa661d35950eb271b2e4
      99940d1a
    • dcashman's avatar
      Make system_server_service an attribute. · 4a89cdfa
      dcashman authored
      Temporarily give every system_server_service its own
      domain in preparation for splitting it and identifying
      special services or classes of services.
      
      Change-Id: I81ffbdbf5eea05e0146fd7fd245f01639b1ae0ef
      4a89cdfa
  9. Dec 15, 2014
    • dcashman's avatar
      Restrict service_manager find and list access. · cd82557d
      dcashman authored
      All domains are currently granted list and find service_manager
      permissions, but this is not necessary.  Pare the permissions
      which did not trigger any of the auditallow reporting.
      
      Bug: 18106000
      Change-Id: Ie0ce8de2af8af2cbe4ce388a2dcf4534694c994a
      cd82557d
  10. Nov 18, 2014
  11. Oct 23, 2014
    • Nick Kralevich's avatar
      system_server: assert app data files never opened directly · b519949d
      Nick Kralevich authored
      Add a compile time assertion that app data files are never
      directly opened by system_server. Instead, system_server always
      expects files to be passed via file descriptors.
      
      This neverallow rule will help prevent accidental regressions and
      allow us to perform other security tightening, for example
      bug 7208882 - Make an application's home directory 700
      
      Bug: 7208882
      Change-Id: I49c725982c4af0b8c76601b2a5a82a5c96df025d
      b519949d
  12. Oct 15, 2014
    • Robin Lee's avatar
      Pull keychain-data policy out of system-data · 51bfecf4
      Robin Lee authored
      Migrators should be allowed to write to /data/misc/keychain in order
      to remove it. Similarly /data/misc/user should be writable by system
      apps.
      
      TODO: Revoke zygote's rights to read from /data/misc/keychain on
      behalf of some preloaded security classes.
      
      Bug: 17811821
      Change-Id: I9e9c6883cff1dca3755732225404909c16a0e547
      51bfecf4
  13. Oct 10, 2014
  14. Sep 20, 2014
    • dcashman's avatar
      Add support for factory reset protection. · f37ce3f3
      dcashman authored
      Address the following denials:
      <12>[  417.732129] type=1400 audit(365340.189:47): avc: denied { read } for pid=1737 comm="Binder_2" name="mmcblk0p18" dev="tmpfs" ino=12406 scontext=u:r:system_server:s0 tcontext=u:object_r:block_device:s0 tclass=blk_file permissive=0
      <12>[  417.882126] type=1400 audit(365340.339:48): avc: denied { read } for pid=1737 comm="Binder_2" name="mmcblk0p18" dev="tmpfs" ino=12406 scontext=u:r:system_server:s0 tcontext=u:object_r:block_device:s0 tclass=blk_file permissive=0
      
      (cherrypick of commit 47bd7300)
      
      Bug: 16710840
      Change-Id: I8cb5b4b17dffe14f0bf05d63eb8f6ab8d5c09f53
      f37ce3f3
  15. Sep 11, 2014
  16. Sep 08, 2014
    • dcashman's avatar
      Add support for factory reset protection. · 47bd7300
      dcashman authored
      Address the following denials:
      <12>[  417.732129] type=1400 audit(365340.189:47): avc: denied { read } for pid=1737 comm="Binder_2" name="mmcblk0p18" dev="tmpfs" ino=12406 scontext=u:r:system_server:s0 tcontext=u:object_r:block_device:s0 tclass=blk_file permissive=0
      <12>[  417.882126] type=1400 audit(365340.339:48): avc: denied { read } for pid=1737 comm="Binder_2" name="mmcblk0p18" dev="tmpfs" ino=12406 scontext=u:r:system_server:s0 tcontext=u:object_r:block_device:s0 tclass=blk_file permissive=0
      
      Bug: 16710840
      Change-Id: I8cb5b4b17dffe14f0bf05d63eb8f6ab8d5c09f53
      47bd7300
  17. Aug 29, 2014
  18. Jul 28, 2014
  19. Jul 25, 2014
    • Nick Kralevich's avatar
      Resync lmp-dev-plus-aosp with master · d065f048
      Nick Kralevich authored
      A DO NOT MERGE change merged from lmp-dev to lmp-dev-plus-aosp.
      This is expected, but it's causing unnecessary merge conflicts
      when handling AOSP contributions.
      
      Resolve those conflicts.
      
      This is essentially a revert of bf696327
      for lmp-dev-plus-aosp only.
      
      Change-Id: Icc66def7113ab45176ae015f659cb442d53bce5c
      d065f048
    • Narayan Kamath's avatar
      Revert "fix system_server dex2oat exec" · aa8e657e
      Narayan Kamath authored
      This reverts commit 10370f5f.
      
      The underlying issue has been fixed and the system_server
      will now go via installd to get stuff compiled, if required.
      
      bug: 16317188
      
      Change-Id: I77a07748a39341f7082fb9fc9792c4139c90516d
      aa8e657e
  20. Jul 24, 2014
  21. Jul 18, 2014
  22. Jul 16, 2014
    • Riley Spahn's avatar
      Remove auditallow from system_server. · d2635764
      Riley Spahn authored
      system_server auditallow statements were causing logspam and
      there is not a good way to negate services from specific devices
      so as a fix we are removing all system_server auditallows. These
      logs may not be useful anyway because I suspsect that system_server
      will probe for most all services anyway.
      
      (cherry picked from commit 5a25fbf7)
      
      Change-Id: Ibadf1ce5e66f279fc49fd8fa20dfc64c960dd57f
      d2635764
    • Riley Spahn's avatar
      Remove auditallow from system_server. · 5a25fbf7
      Riley Spahn authored
      system_server auditallow statements were causing logspam and
      there is not a good way to negate services from specific devices
      so as a fix we are removing all system_server auditallows. These
      logs may not be useful anyway because I suspsect that system_server
      will probe for most all services anyway.
      
      Change-Id: I27a05761c14def3a86b0749cdb895190bdcf9d71
      5a25fbf7
  23. Jul 15, 2014
    • Riley Spahn's avatar
      Add access control for each service_manager action. · 344fc109
      Riley Spahn authored
      Add SELinux MAC for the service manager actions list
      and find. Add the list and find verbs to the
      service_manager class. Add policy requirements for
      service_manager to enforce policies to binder_use
      macro.
      
      (cherry picked from commit b8511e0d)
      
      Change-Id: I980d4a8acf6a0c6e99a3a7905961eb5564b1be15
      344fc109
    • Nick Kralevich's avatar
      fix system_server dex2oat exec · 10370f5f
      Nick Kralevich authored
      Addresses the following denial:
      
        W/system_server( 2697): type=1400 audit(0.0:9): avc: denied { execute } for name="dex2oat" dev="mmcblk0p31" ino=118 scontext=u:r:system_server:s0 tcontext=u:object_r:dex2oat_exec:s0 tclass=file permissive=0
      
      Bug: 16317188
      Change-Id: I168842b3e281efcb0632049632ed3817c2025e4d
      10370f5f
    • Ed Heyl's avatar
      reconcile aosp (3a8c5dc0) after branching. Please do not merge. · 81839dfb
      Ed Heyl authored
      Change-Id: Ic8ee83ed6ffef02bddd17e1175416fc2481db7b2
      81839dfb
  24. Jul 14, 2014
    • Nick Kralevich's avatar
      fix system_server dex2oat exec · 8395bb4a
      Nick Kralevich authored
      Addresses the following denial:
      
        W/system_server( 2697): type=1400 audit(0.0:9): avc: denied { execute } for name="dex2oat" dev="mmcblk0p31" ino=118 scontext=u:r:system_server:s0 tcontext=u:object_r:dex2oat_exec:s0 tclass=file permissive=0
      
      Change-Id: I168842b3e281efcb0632049632ed3817c2025e4d
      8395bb4a
    • Riley Spahn's avatar
      Add access control for each service_manager action. · b8511e0d
      Riley Spahn authored
      Add SELinux MAC for the service manager actions list
      and find. Add the list and find verbs to the
      service_manager class. Add policy requirements for
      service_manager to enforce policies to binder_use
      macro.
      
      Change-Id: I224b1c6a6e21e3cdeb23badfc35c82a37558f964
      b8511e0d
  25. Jul 11, 2014
  26. Jul 10, 2014
  27. Jul 09, 2014
  28. Jul 08, 2014
    • Jeff Sharkey's avatar
      Rules to allow installing package directories. · c02c98d3
      Jeff Sharkey authored
      Earlier changes had extended the rules, but some additional changes
      are needed.
      
      avc: denied { relabelfrom } for name="vmdl-723825123.tmp"
          dev="mmcblk0p28" ino=162910 scontext=u:r:system_server:s0
          tcontext=u:object_r:apk_data_file:s0 tclass=dir
      
      Bug: 14975160
      Change-Id: Ia644c73ec10460a2a529fe197ade6afe46694651
      c02c98d3
  29. Jul 07, 2014
    • Jeff Sharkey's avatar
      Rules to allow installing package directories. · be092af0
      Jeff Sharkey authored
      Earlier changes had extended the rules, but some additional changes
      are needed.
      
      avc: denied { relabelfrom } for name="vmdl-723825123.tmp"
          dev="mmcblk0p28" ino=162910 scontext=u:r:system_server:s0
          tcontext=u:object_r:apk_data_file:s0 tclass=dir
      
      Bug: 14975160
      Change-Id: I875cfc3538d4b098d27c7c7b756d1868a54cc976
      be092af0
  30. Jul 04, 2014
    • Nick Kralevich's avatar
      system_server: bring back sdcard_type neverallow rule · d00eff47
      Nick Kralevich authored
      We had disabled the neverallow rule when system_server was
      in permissive_or_unconfined(), but forgot to reenable it.
      Now that system_server is in enforcing/confined, bring it
      back.
      
      Change-Id: I6f74793d4889e3da783361c4d488b25f804ac8ba
      d00eff47
  31. Jul 01, 2014
Loading