Skip to content
Snippets Groups Projects
  1. Apr 09, 2018
    • Max Bires's avatar
      Adding labeling for vendor security patch prop · 5cac1aa9
      Max Bires authored
      This will allow adb shell getprop ro.vendor.build.security_patch to
      properly return the correct build property, whereas previously it was
      offlimits due to lack of label.
      
      Test: adb shell getprop ro.vendor.build.security_patch successfully
      returns whatever VENDOR_SECURITY_PATCH is defined to be in the Android
      .mk files
      
      Change-Id: Ie8427738125fc7f909ad8d51e4b76558f5544d49
      5cac1aa9
    • Alan Stokes's avatar
      Revert "Add /sys/kernel/memory_state_time to sysfs_power." · 12e73685
      Alan Stokes authored
      This reverts commit db83323a.
      
      Reason for revert: breaks some builds due to duplicate genfs entries
      
      Change-Id: I47813bd84ff10074a32cf483501a9337f556e92a
      12e73685
    • Alan Stokes's avatar
      Installd doesn't need to create cgroup files. · 06bac37f
      Alan Stokes authored
      cgroupfs doesn't allow files to be created, so this can't be needed.
      
      Also remove redundant neverallow and dontaudit rules. These are now
      more broadly handled by domain.te.
      
      Bug: 74182216
      
      Test: Denials remain silenced.
      
      Change-Id: If7eb0e59f567695d987272a2fd36dbc251516e9f
      
      (cherry picked from commit 8e8c1093)
      06bac37f
    • Alan Stokes's avatar
      Add /sys/kernel/memory_state_time to sysfs_power. · db83323a
      Alan Stokes authored
      This allows system_server to access it for determining battery stats
      (see KernelMemoryBandwidthStats.java).
      
      batterystats-wo: type=1400 audit(0.0:429): avc: denied { read } for name="show_stat" dev="sysfs" ino=48071 scontext=u:r:system_server:s0 tcontext=u:object_r:sysfs:s0 tclass=file permissive=0
      
      Bug: 72643420
      Bug: 73947096
      
      Test: Denial is no longer present.
      Change-Id: Ibe46aee48eb3f78fa5a9d1f36602c082c33036f7
      
      (cherry picked from commit a8b3634d)
      db83323a
  2. Apr 06, 2018
    • Mikhail Naganov's avatar
      Add shell:fifo_file permission for audioserver · 05e12dba
      Mikhail Naganov authored
      Bug: 73405145
      Test: cts-tradefed run cts -m CtsMediaTestCases -t android.media.cts.AudioRecordTest#testRecordNoDataForIdleUids
      Change-Id: I09bdb74c9ecc317ea090643635ca26165efa423a
      (cherry picked from commit c5815891)
      Merged-In: I09bdb74c9ecc317ea090643635ca26165efa423a
      05e12dba
    • Florian Mayer's avatar
      Grant traced_probes search on directories. · ff146962
      Florian Mayer authored
      This is needed to be able to scan the labels we have
      permission on.
      
      Denial:
      
      04-06 12:52:22.674   874   874 W traced_probes: type=1400 audit(0.0:10314): avc: denied { search } for name="backup" dev="sda45" ino=6422529 scontext=u:r:traced_probes:s0 tcontext=u:object_r:backup_data_file:s0 tclass=dir permissive=0
      
      Bug: 73625480
      ff146962
  3. Apr 05, 2018
  4. Apr 04, 2018
  5. Apr 03, 2018
    • Nathan Harold's avatar
      Allow getsockopt and setsockopt for Encap Sockets · 252b0153
      Nathan Harold authored
      Because applications should be able to set the receive
      timeout on UDP encapsulation sockets, we need to allow
      setsockopt(). getsockopt() is an obvious allowance as
      well.
      
      Bug: 68689438
      Test: compilation
      Merged-In: I2eaf72bcce5695f1aee7a95ec03111eca577651c
      Change-Id: I2eaf72bcce5695f1aee7a95ec03111eca577651c
      252b0153
    • Jeff Vander Stoep's avatar
      Rename qtaguid_proc to conform to name conventions · bdf2a9c4
      Jeff Vander Stoep authored
      Test: build
      Bug: 68774956
      Change-Id: I0f9fd87eb41e67e14f35e49eba13e3d1de745250
      bdf2a9c4
    • Jeff Vander Stoep's avatar
      Add untrusted_app_27 · 3aa7ca56
      Jeff Vander Stoep authored
      This is a partial cherry pick of commit 6231b4d9
      'Enforce per-app data protections for targetSdk 28+'.
      
      Untrusted_app_27 remains unreachable, but it's existence
      prevents future merge conflicts.
      
      Bug: 63897054
      Test: build/boot aosp_walleye-userdebug
      Change-Id: I64b013874fe87b55f47e817a1279e76ecf86b7c0
      Merged-In: I64b013874fe87b55f47e817a1279e76ecf86b7c0
      (cherry picked from commit 6231b4d9)
      3aa7ca56
    • Jeff Vander Stoep's avatar
      Remove deprecated tagSocket() permissions · 0d1e52a5
      Jeff Vander Stoep authored
      tagSocket() now results in netd performing these actions on behalf
      of the calling process.
      
      Remove direct access to:
      /dev/xt_qtaguid
      /proc/net/xt_qtaguid/ctrl
      
      Bug: 68774956
      Test: -m CtsAppSecurityHostTestCases -t android.appsecurity.cts.AppSecurityTests
          -m CtsNativeNetTestCases
      Test: stream youtube, browse chrome
      Test: go/manual-ab-ota
      Change-Id: I6a044f304c3ec4e7c6043aebeb1ae63c9c5a0beb
      0d1e52a5
  6. Mar 30, 2018
  7. Mar 29, 2018
    • Joel Galenson's avatar
      Label /proc/sys/kernel/sched_schedstats. · 4b625e4a
      Joel Galenson authored
      This allows init to write to it, which it does for atrace.
      
      Bug: 72643420
      Test: Boot two devices, observe no denials, test atrace.
      Change-Id: I6810e5dcdfaff176bd944317e66d4fe612ccebed
      (cherry picked from commit dce07413)
      4b625e4a
    • Chenbo Feng's avatar
      Allow netutils_wrapper to use pinned bpf program · 2623ebcf
      Chenbo Feng authored
      The netutils_wrapper is a process used by vendor code to update the
      iptable rules on devices. When it update the rules for a specific chain.
      The iptable module will reload the whole chain with the new rule. So
      even the netutils_wrapper do not need to add any rules related to xt_bpf
      module, it will still reloading the existing iptables rules about xt_bpf
      module and need pass through the selinux check again when the rules are
      reloading. So we have to grant it the permission to reuse the pinned
      program in fs_bpf when it modifies the corresponding iptables chain so
      the vendor module will not crash anymore.
      
      Test: device boot and no more denials from netutils_wrapper
      Bug: 72111305
      Change-Id: I62bdfd922c8194c61b13e2855839aee3f1e349be
      2623ebcf
    • Alan Stokes's avatar
      Suppress harmless denials for file creation in cgroupfs. · 832a7042
      Alan Stokes authored
      The kernel generates file creation audits when O_CREAT is passed even
      if the file already exists - which it always does in the cgroup cases.
      
      We add neverallow rules to prevent mistakenly allowing unnecessary
      create access. We also suppress these denials, which just add noise to
      the log, for the more common culprits.
      
      Bug: 72643420
      Bug: 74182216
      
      Test: Ran build_policies.sh and checked failures were unrelated.
      Test: Device still boots, denials gone.
      Change-Id: I034b41ca70da1e73b81fe90090e656f4a3b542dc
      (cherry picked from commit 92c149d0)
      832a7042
  8. Mar 28, 2018
    • Jeff Vander Stoep's avatar
      Improve neverallows on /proc and /sys · 886aa54b
      Jeff Vander Stoep authored
      Access to these files was removed in Oreo. Enforce that access is not
      granted by partners via neverallow rule.
      
      Also disallow most untrusted app access to net.dns.* properties.
      
      Bug: 77225170
      Test: system/sepolicy/tools/build_policies.sh
      Change-Id: I85b634af509203393dd2d9311ab5d30c65f157c1
      886aa54b
    • Joel Galenson's avatar
      Hide some denials. · d93ef542
      Joel Galenson authored
      These denials occur fairly often, causing some logspam.
      
      Bug: 77225170
      Test: Boot device.
      Merged-In: Icd73a992aee44007d0873743f706758f9a19a112
      Change-Id: Icd73a992aee44007d0873743f706758f9a19a112
      (cherry picked from commit a66d1a45)
      d93ef542
  9. Mar 27, 2018
  10. Mar 26, 2018
    • Jeff Vander Stoep's avatar
      crashdump: cleanup logs · 627ba82b
      Jeff Vander Stoep authored
      Suppress WAI denials from crashdump.
      
      Test: build/flash Taimen. Verify no new denials.
      Bug: 68319037
      Change-Id: If39d057cb020def7afe89fd95e049e45cce2ae16
      (cherry picked from commit cc0304cf)
      627ba82b
    • Primiano Tucci's avatar
      Revert "Allow system server to set persist.traced.enable" · 4f673cf4
      Primiano Tucci authored
      This reverts commit 6f2040f8.
      
      Reason for revert: not needed anymore after ag/3773705
      This was meant to allow system_server toggling the property on/off.
      Later we realized that we needed a separate property for that 
      (see discussion in b/76077784) and system server happens to
      have already permissions to write to sys.* properties even without
      this CL.
      Reverting because at this point this creates just unnecessary clutter.
      
      Change-Id: Ia73d000aad3c4288a5652047dfe10896e231b0b1
      Test: perfetto_integrationtests
      Bug: 76077784
      4f673cf4
    • Primiano Tucci's avatar
      perfetto: allow traced to write into FDs received by the client · 5d317326
      Primiano Tucci authored
      This allows an optimization that consists in the "perfetto" cmdline
      client passing directly the file descriptor for the output trace
      to traced (as opposite to having traced streaming back the trace
      data to "perfetto" and having that one doing the write() into file).
      This reduces sensibly the memory traffic and CPU overhead of traces
      with a minor change.
      
      Bug: 73625179
      Test: builds + perfetto_integrationtests w/ long_trace.cfg
      Change-Id: I81f5a230338ced20dc543fd91c5a0bd0e58725f2
      5d317326
  11. Mar 23, 2018
    • Chenbo Feng's avatar
      Allow system server to access bpf fs · f83bbd17
      Chenbo Feng authored
      The permission to allow system_server to access sys/fs/bpf/ directory
      is missing. Add it back so it can get the bpf maps from the bpf_fs.
      
      Test: device boot and no more denial information of system_server try to
      searcg in fs_bpf
            atest android.net.cts.TrafficStatsTest
      Bug: 75285088
      
      Change-Id: I1040cde6c038eccc4e91c69a10b20aa7a18b19f6
      f83bbd17
  12. Mar 22, 2018
    • Mikhail Naganov's avatar
      Allow system_server to update timerslack_ns for hal_audio_default · e6293b1c
      Mikhail Naganov authored
      Based on the following audit message:
      
      type=1400 audit(1521738979.005:385): avc: denied { write } for pid=1269
      comm="Binder:1269_B" name="timerslack_ns" dev="proc" ino=254190
      scontext=u:r:system_server:s0 tcontext=u:r:hal_audio_default:s0
      tclass=file permissive=1
      
      Bug: 74110604
      Test: adb shell dmesg | grep hal_audio_default
      Change-Id: I4c2e787588eb9d223d5e50e1bc8f67876de97c2e
      e6293b1c
    • Primiano Tucci's avatar
      Fix selinux brekage on user for atrace · 68240241
      Primiano Tucci authored
      Follow up to aosp/635599. It broke user builds again
      despite being tree hugged because of b/74344625.
      Adding missing ignore entries.
      
      Bug: b/73340039
      Change-Id: Iba195d571aec9579195d79d4970f760e417608c6
      68240241
    • Primiano Tucci's avatar
      Reland: perfetto: allow traced_probes to execute atrace · feaf22b1
      Primiano Tucci authored
      This CL adds the SELinux permissions required to execute
      atrace and get userspace tracing events from system services.
      This is to enable tracing of events coming from surfaceflinger,
      audio HAL, etc.
      atrace, when executed, sets a bunch of debug.atrace. properties
      and sends an IPC via binder/hwbinder to tell the services to
      reload that property.
      
      This CL does NOT affect systrace. In that case (i.e. when
      atrace is executed from adb/shell) atrace still runs in
      the shell domain and none of those changes apply.
      
      Change-Id: I11b096d5c5c5593f18bce87f06c1a7b1ffa7910e
      Bug: b/73340039
      feaf22b1
  13. Mar 21, 2018
    • Chenbo Feng's avatar
      Allow netd to setup xt_bpf iptable rules · 5c95c168
      Chenbo Feng authored
      To better record the network traffic stats for each network interface.
      We use xt_bpf netfilter module to do the iface stats accounting instead
      of the cgroup bpf filter we currently use for per uid stats accounting.
      The xt_bpf module will take pinned eBPF program as iptables rule and run
      the program when packet pass through the netfilter hook. To setup the
      iptables rules. netd need to be able to access bpf filesystem and run the
      bpf program at boot time. The program used will still be created and
      pinned by the bpfloader process.
      
      Test: With selinux enforced, run "iptables -L -t raw" should show the
      xt_bpf related rule present in bw_raw_PREROUTING chain.
      Bug: 72111305
      
      Change-Id: I11efe158d6bd5499df6adf15e8123a76cd67de04
      5c95c168
  14. Mar 20, 2018
  15. Mar 19, 2018
    • Tri Vo's avatar
      proc_type attribute for files under /proc. · 41bf08e5
      Tri Vo authored
      With this attribute it will be easier to reference /proc files.
      
      Bug: 74182216
      Test: policy builds
      Change-Id: I5b7da508d821e45f122832261a742a201e8fdf2c
      41bf08e5
    • Chong Zhang's avatar
      allow mediaprovider to use media extractor · 8e3fef3d
      Chong Zhang authored
      When extraction exif info, certain file formats may requires
      parsing the container. Allow mediaprovider to use extractor
      to do the parsing.
      
      bug: 73978990
      Test: manually test the scenario in b/73978990 and verify
            the Exif is extracted correctly.
      
      Change-Id: I1cd46d793ebc9c38b816a3b63f361967e551d046
      8e3fef3d
    • Hector Dearman's avatar
      Allow system server to set persist.traced.enable · 6f2040f8
      Hector Dearman authored
      To enable/disable the traced and traced_probes deamons remotely we would
      like system server to be able to set persist.traced.enable.
      See also ag/3736001.
      
      Denial:
      selinux: avc: denied { set } for
      property=persist.traced.enable
      pid=1606 uid=1000 gid=1000
      scontext=u:r:system_server:s0
      tcontext=u:object_r:default_prop:s0 tclass=property_service
      permissive=0\x0a
      
      Run:
      $ adb shell 'ps -A | grep traced'
      Should see traced.
      $ adb shell 'settings put global sys_traced 0'
      $ adb shell 'ps -A | grep traced'
      Should no longer see traced.
      
      Test: See above.
      Change-Id: I245b7df3853cabeb0e75db41fb4facaa178ab8f1
      6f2040f8
  16. Mar 16, 2018
Loading