Skip to content
Snippets Groups Projects
  1. Jul 12, 2017
    • Peng Xu's avatar
      Allow system to dump sensor hal process · e4968f90
      Peng Xu authored
      Test: tested taking bugreport, sensor HAL traces show up in
            "VM TRACES JUST NOW"
      Test: tested trigger ANR by `adb shell am hang --allow-restart`,
            sensor HAL traces shows up in /data/anr/traces.txt
      Bug: 63096400
      Change-Id: I1d012b9d9810f987be7aaf9d68abfd9c3184ac5c
      e4968f90
  2. Jul 06, 2017
  3. Jul 05, 2017
    • Jeff Vander Stoep's avatar
      Preserve attributes needed for CTS · 5f5aa962
      Jeff Vander Stoep authored
      Change fb889f23 "Force expand all hal_* attributes" annotated all
      hal_* attributes to be expanded to their associated types. However
      some of these attributes are used in CTS for neverallow checking.
      Mark these attributes to be preserved.
      
      In addition, remove the hacky workaround introduced in oc-dev
      for b/62658302 where extraneous neverallow rules were introduced
      to prevent unused or negated attributes from being auto-expanded
      from policy.
      
      Bug: 62658302
      Bug: 63135903
      Test: cts-tradefed run cts -m CtsSecurityHostTestCases -t \
          android.cts.security.SELinuxNeverallowRulesTest
      
          armeabi-v7a CtsSecurityHostTestCases completed in 4s.
          501 passed, 0 failed, 0 not executed
      Merged-In: I989def70a16f66e7a18bef1191510793fbe9cb8c
      Change-Id: I989def70a16f66e7a18bef1191510793fbe9cb8c
      5f5aa962
    • Jin Qian's avatar
      remove mke2fs rules from global file_contexts · 0d32323c
      Jin Qian authored
      move them to device-specific files.
      
      Bug: 62908056
      Change-Id: I299819785d5a64e6ecdde1cd7da472477fe1e295
      Merged-In: If92352ea7a70780e9d81ab10963d63e16b793792
      0d32323c
    • Jin Qian's avatar
      move e2fs tools from /sbin to /system/bin · ae047956
      Jin Qian authored
      Test: let fs_mgr format a damaged /data partition
      Bug: 35219933
      Change-Id: I379567772c73e52f532a24acf640c21f2bab5c5b
      Merged-In: I379567772c73e52f532a24acf640c21f2bab5c5b
      ae047956
  4. Jun 30, 2017
  5. Jun 29, 2017
    • TreeHugger Robot's avatar
    • Jeff Vander Stoep's avatar
      hal_tetheroffload: Grant permissions · e58a8de5
      Jeff Vander Stoep authored
      avc: denied { read write } scontext=u:r:ipacm:s0
      tcontext=u:r:system_server:s0 tclass=netlink_netfilter_socket
      avc: denied { setopt } scontext=u:r:ipacm:s0
      tcontext=u:r:system_server:s0 tclass=netlink_netfilter_socket
      avc: denied { getattr } scontext=u:r:ipacm:s0
      tcontext=u:r:system_server:s0 tclass=netlink_netfilter_socket
      avc: denied { create } for scontext=u:r:system_server:s0
      tcontext=u:r:system_server:s0 tclass=netlink_netfilter_socket
      
      Bug: 29337859
      Bug: 32163131
      Test: adb shell getenforce
      Enforcing
      adb shell dumpsys connectivity tethering
      Tethering:
        ...
        Log:
          ...
          06-28 11:46:58.841 - SET master tether settings: ON
          06-28 11:46:58.857 - [OffloadController] tethering offload started
      And logs show some signs of happiness:
          06-28 11:46:58.853   816   947 I IPAHALService: IPACM was provided two FDs (18, 19)
          06-28 11:46:58.853  1200  1571 I zygote64: Looking for service android.hardware.tetheroffload.control@1.0::IOffloadControl/default
      Change-Id: I0c63bd2de334b4ca40e54efb9df4ed4904667e21
      e58a8de5
  6. Jun 27, 2017
  7. Jun 26, 2017
    • Jeff Vander Stoep's avatar
      Suppress su access to pdx sockets · 4b7cf4fb
      Jeff Vander Stoep authored
      Su runs in permissive mode and denials should be suppressed.
      
      avc: denied { getattr } for scontext=u:r:su:s0
      tcontext=u:object_r:pdx_display_client_endpoint_socket:s0
      tclass=unix_stream_socket permissive=1
      avc: denied { getattr } for scontext=u:r:su:s0
      tcontext=u:object_r:pdx_display_manager_endpoint_socket:s0
      tclass=unix_stream_socket permissive=1
      avc: denied { getattr } for scontext=u:r:su:s0
      tcontext=u:object_r:pdx_display_vsync_endpoint_socket:s0
      tclass=unix_stream_socket permissive=1
      avc: denied { getattr } for scontext=u:r:su:s0
      tcontext=u:object_r:pdx_bufferhub_client_endpoint_socket:s0
      tclass=unix_stream_socket permissive=1
      avc: denied { getattr } for scontext=u:r:su:s0
      tcontext=u:object_r:pdx_performance_client_endpoint_socket:s0
      tclass=unix_stream_socket permissive=1
      
      Bug: 35197529
      Test: policy builds
      Change-Id: Ia643c6e776e5e5bd473d857d523c3be91d32c40a
      4b7cf4fb
    • Jeff Vander Stoep's avatar
      dexoptanalyzer: suppress access(2) denial · 575e6270
      Jeff Vander Stoep authored
      A legitimate call to access(2) is generating a denial. Use the
      audit_access permission to suppress the denial on just the access()
      call.
      
      avc: denied { write } for name="verified_jars"
      scontext=u:r:dexoptanalyzer:s0
      tcontext=u:object_r:app_data_file:s0:c512,c768 tclass=dir
      
      Bug: 62597207
      Test: build policy
      Test: The following cmd succeeds but no longer generates a denial
          adb shell cmd package compile -r bg-dexopt --secondary-dex \
          com.google.android.googlequicksearchbox
      
      Change-Id: I7d03df2754c24c039bce11426bf8f317232f5e5f
      575e6270
    • Jeff Vander Stoep's avatar
      Add another extraneous neverallow rule to force attribute inclusion · a128aca6
      Jeff Vander Stoep authored
      am: c75aa50d
      
      Change-Id: I39eecd67a97de193d53ab298a1ef3e8443bb9391
      a128aca6
    • Jeff Vander Stoep's avatar
      Add another extraneous neverallow rule to force attribute inclusion · c75aa50d
      Jeff Vander Stoep authored
      Due to the massively increased number of attributes in SELinux policy
      as part of the treble changes, we have had to remove attributes from
      policy for performance reasons.  Unfortunately, some attributes are
      required to be in policy to ensure that our neverallow rules are being
      properly enforced.  Usually this is not a problem, since neverallow rules
      indicate that an attribute should be kept, but this is not currently the
      case when the attribute is part of a negation in a group.
      
      This is particularly problematic with treble since some attributes may
      exist for HALs that have no implementation, and thus no types.  In
      particular, this has caused an issue with the neverallows added in our
      macros.  Add an extraneous neverallow rule to each of those auto-generated
      neverallow rules to make sure that they are not removed from policy, until
      the policy compiler is fixed to avoid this.  Also add corresponding rules
      for other types which have been removed due to no corresponding rules.
      
      Bug: 62658302
      Bug: 62999603
      Test: Build Marlin policy.
      Test: verify attribute exists in policy using sepolicy-analyze.
          sepolicy-analyze $OUT/vendor/etc/selinux/precompiled_sepolicy \
          attribute hal_tetheroffload_server
      Test: CTS neverallow tests pass.
          cts-tradefed run cts -m CtsSecurityHostTestCases -t \
          android.cts.security.SELinuxNeverallowRulesTest
      Change-Id: I62596ba8198ffdcbb4315df639a834e4becaf249
      c75aa50d
  8. Jun 23, 2017
  9. Jun 22, 2017
  10. Jun 21, 2017
  11. Jun 20, 2017
  12. Jun 19, 2017
    • Tom Cherry's avatar
    • Tom Cherry's avatar
      Add getpgid to system_service and init · d5f0aba0
      Tom Cherry authored
      In libprocessgroup, we want to only send signals once to processes,
      particularly for SIGTERM.  We must send the signal both to all
      processes within a POSIX process group and a cgroup.  To ensure that
      we do not duplicate the signals being sent, we check the processes in
      the cgroup to see if they're in the POSIX process groups that we're
      killing.  If they are, we skip sending a second signal.  This requires
      getpgid permissions, hence this SELinux change.
      
      avc: denied { getpgid } for pid=797 comm="ActivityManager" scontext=u:r:system_server:s0 tcontext=u:r:untrusted_app_25:s0:c512,c768 tclass=process permissive=1
      avc: denied { getpgid } for pid=797 comm="ActivityManager" scontext=u:r:system_server:s0 tcontext=u:r:untrusted_app_25:s0:c512,c768 tclass=process permissive=1
      avc: denied { getpgid } for pid=797 comm="ActivityManager" scontext=u:r:system_server:s0 tcontext=u:r:system_app:s0 tclass=process permissive=1
      avc: denied { getpgid } for pid=797 comm="ActivityManager" scontext=u:r:system_server:s0 tcontext=u:r:system_app:s0 tclass=process permissive=1
      avc: denied { getpgid } for pid=1 comm="init" scontext=u:r:init:s0 tcontext=u:r:zygote:s0 tclass=process permissive=1
      avc: denied { getpgid } for pid=1 comm="init" scontext=u:r:init:s0 tcontext=u:r:zygote:s0 tclass=process permissive=1
      avc: denied { getpgid } for pid=1 comm="init" scontext=u:r:init:s0 tcontext=u:r:system_server:s0 tclass=process permissive=1
      avc: denied { getpgid } for pid=1 comm="init" scontext=u:r:init:s0 tcontext=u:r:system_server:s0 tclass=process permissive=1
      
      Bug: 37853905
      Bug: 62418791
      Test: Boot, kill zygote, reboot
      Change-Id: Ib6c265dbaac8833c47145ae28fb6594ca8545570
      (cherry picked from commit c59eb4d8)
      d5f0aba0
  13. Jun 16, 2017
Loading