Skip to content
Snippets Groups Projects
  1. Dec 15, 2016
  2. Dec 14, 2016
    • Nick Kralevich's avatar
      Assign a label to the ro.boottime.* properties · bb9a3888
      Nick Kralevich authored
      system/core commit 331cf2fb7c16b5b25064f8d2f00284105a9b413f created a
      number of new properties of the form:
      
        [ro.boottime.init]: [5294587604]
        [ro.boottime.InputEventFind]: [10278767840]
        [ro.boottime.adbd]: [8359267180]
        ...
      
      These properties were assigned the default_prop SELinux label because a
      better label did not exist. Properties labeled with the default_prop
      label are readable to any SELinux domain, which is overly broad.
      
        bullhead:/ $ getprop -Z ro.boottime.adbd
        u:object_r:default_prop:s0
      
      Instead, create a new label for the ro.boottime.* properties so we can
      apply more fine grain read access control to these properties.
      
        bullhead:/ $ getprop -Z ro.boottime.adbd
        u:object_r:boottime_prop:s0
      
      New SELinux property labels have minimal permissions by default. As a
      result, after this change, ro.boottime.* properties will only be
      readable to system_server, bootstat, init (because it manages the property
      space), and "adb root" (because no SELinux permissions are enforced there).
      
      Additional read access can be granted as-needed.
      
      This is part of a larger effort to implement fine-grain access control
      on the properties managed by init.
      
      Test: Device boots and no SELinux denials on boot.
      Change-Id: Ibf981cb81898f4356fdc5c1b6f15dd93c0d6d84d
      bb9a3888
    • Chad Brubaker's avatar
      Allow binder IPC between ephemeral app and appdomain · 641d5d8f
      Chad Brubaker authored
      Address denial type=1400 audit(0.0:42): avc: denied { call } for
      scontext=u:r:untrusted_app:s0:c512,c768
      tcontext=u:r:ephemeral_app:s0:c207,c258,c512,c768 tclass=binder
      
      Test: Above denial no longer happens
      Change-Id: I351269ee4671cfd51c981d3db5d0f3944d14e702
      641d5d8f
    • Treehugger Robot's avatar
    • Steven Moreland's avatar
      All hal policies expressed as attributes. · 29eed9fa
      Steven Moreland authored
      Bug: 32123421
      Bug: 32905206
      
      Test: compiles, nfc works
      Change-Id: Ibf72ef70255573e4df0863ea640354b3c37eb47d
      29eed9fa
    • Nick Kralevich's avatar
      Do not allow new additions to core_property_type · d310df20
      Nick Kralevich authored
      core_property_type is an attribute which was given to all existing
      properties known to core SELinux policy. Any property with this label is
      readable to all SELinux domains, which is overly broad. The long term
      goal is to remove the core_property_type attribute entirely.
      
      Add a neverallow rule prohibiting the introduction of new properties
      with the core_property_type attribute. Device specific properties, or
      new properties in core SELinux policy, should not have this attribute.
      
      Test: policy compiles
      Change-Id: Ie89a9f0d81c8561616001ff8451496ce2278dbb2
      d310df20
  3. Dec 13, 2016
  4. Dec 12, 2016
  5. Dec 10, 2016
    • Jeff Sharkey's avatar
    • Nick Kralevich's avatar
      Move hci_attach to hikey · 4394b2c0
      Nick Kralevich authored
      This is unused by core policy and by any device policy except for hikey.
      
      Test: device boots
      Test: no denials ever collected
      Change-Id: I36a6790499e4aeedd808457b43fd72370fa48e53
      4394b2c0
    • Nick Kralevich's avatar
      Whitespace fix · b56e6ef8
      Nick Kralevich authored
      Because I'm nitpicky.
      
      Test: policy compiles
      Change-Id: I4d886d0d6182d29d7b260cf1f142c47cd32eda29
      b56e6ef8
    • Nick Kralevich's avatar
      remove more domain_deprecated · 6a259ccd
      Nick Kralevich authored
      Test: no denials showing up in log collection
      Test: device boots
      Bug: 28760354
      Change-Id: I089cfcf486464952fcbb52cce9f6152caf662c23
      6a259ccd
    • Nick Kralevich's avatar
      debuggerd.te: remove domain_deprecated · 30603f1e
      Nick Kralevich authored
      Remove domain_deprecated and add denials picked up by log collection.
      
      Addresses the following auditallow messages:
      
        avc: granted { search } for comm="debuggerd" name="arm" dev="sda35"
        ino=57521 scontext=u:r:debuggerd:s0
        tcontext=u:object_r:apk_data_file:s0 tclass=dir
      
        avc: granted { read } for comm="debuggerd"
        path="/data/app/dji.pilot-Z6Q2X6YjYNN2Ag8otZTCdg==/lib/arm/libtpnsWatchdog.so"
        dev="sda35" ino=57854 scontext=u:r:debuggerd:s0
        tcontext=u:object_r:apk_data_file:s0 tclass=file
      
        avc: granted { getattr } for comm="debuggerd64"
        path="/data/app/com.google.android.youtube-2/lib/arm64/libcronet.so"
        dev="sda35" ino=1384657 scontext=u:r:debuggerd:s0
        tcontext=u:object_r:apk_data_file:s0 tclass=file
      
        avc: granted { read open } for comm="debuggerd"
        path="/data/app/dji.pilot-We9wJivxEqhzfdtQrNFvaA==/lib/arm/libtpnsWatchdog.so"
        dev="sda35" ino=57575 scontext=u:r:debuggerd:s0
        tcontext=u:object_r:apk_data_file:s0 tclass=file
      
      Bug: 28760354
      Test: Device boots
      Test: No unexpected denials in denial collection logs.
      Change-Id: I1ae6203e37ddd4a19551d8063d26071ac20f2f3e
      30603f1e
  6. Dec 09, 2016
    • Jeff Sharkey's avatar
      installd has moved on to Binder; goodbye socket! · 8b1d4520
      Jeff Sharkey authored
      After a series of recent commits, installd has fully migrated over
      to Binder, and all socket-based communication has been removed.
      
      Test: builds, boots, apps install fine, pre-OTA dexopt works
      Bug: 13758960, 30944031
      Change-Id: Ia67b6260de58240d057c99b1bbd782b44376dfb5
      8b1d4520
  7. Dec 08, 2016
  8. Dec 07, 2016
    • Nick Kralevich's avatar
      Add TCSETS to unpriv_tty_ioctls · 240f50e8
      Nick Kralevich authored
      Addresses the following denial:
      
      avc: denied { ioctl } for comm="top" path="/dev/pts/0" dev="devpts"
      ino=3 ioctlcmd=5402 scontext=u:r:shell:s0 tcontext=u:object_r:devpts:s0
      tclass=chr_file permissive=0
      
      Bug: 33073072
      Bug: 7530569
      Test: policy compiles.
      Change-Id: If9178d29f2295be46bb118df00ebf73a6ebc9f81
      240f50e8
    • Treehugger Robot's avatar
      a040aa12
    • Nick Kralevich's avatar
      priv_app.te: Drop auditallow app_data_file:file execute · 57475e5e
      Nick Kralevich authored
      This functionality is being used by priv_apps shipped as part of
      Android. Don't drop execute_no_trans as we haven't seen any denials here
      yet.
      
      Addresses the following auditallow messages:
      
      avc: granted { execute } for comm="GELServices-0"
      path="/data/data/com.google.android.googlequicksearchbox/files/velour/dex_cache/Ji1opKyKASKEOKNQUu1QyWw_1.jar/Ji1opKyKASKEOKNQUu1QyWw_1.dex"
      dev="dm-2" ino=1196939 scontext=u:r:priv_app:s0:c512,c768
      tcontext=u:object_r:app_data_file:s0:c512,c768 tclass=file
      
      avc: granted { execute } for comm="CTION_IDLE_MODE"
      path="/data/data/com.google.android.gms/snet/dalvik-cache/snet.dex"
      dev="dm-2" ino=1114262 scontext=u:r:priv_app:s0:c512,c768
      tcontext=u:object_r:app_data_file:s0:c512,c768 tclass=file
      
      avc: granted { execute } for comm="lowpool[3]"
      path="/data/data/com.google.android.gms/files/libAppDataSearchExt_arm64_v8a.so"
      dev="dm-2" ino=1688320 scontext=u:r:priv_app:s0:c512,c768
      tcontext=u:object_r:app_data_file:s0:c512,c768 tclass=file
      
      avc: granted { execute } for comm="Binder:9196_2"
      path="/data/data/com.google.android.gms/app_dg_cache/1FECE961A655634046D6AB5E18FE6F74212FBEA6/lib/libdC14BB7282EA1.so"
      dev="dm-2" ino=1893474 scontext=u:r:priv_app:s0:c512,c768
      tcontext=u:object_r:app_data_file:s0:c512,c768 tclass=file
      
      avc: granted { execute } for comm="Binder:13170_1"
      path="/data/data/com.google.android.gms/app_fb/f.dex" dev="dm-2"
      ino=1810720 scontext=u:r:priv_app:s0:c512,c768
      tcontext=u:object_r:app_data_file:s0:c512,c768 tclass=file
      
      Test: policy compiles.
      Change-Id: I63358697b07c8f620b999e666791f4f385bab776
      57475e5e
    • dcashman's avatar
      Restore checkfc and neverallow checks. · 07791558
      dcashman authored
      Bug: 33388095
      Test: Builds and boots.
      Change-Id: Ief9064a16fc733bed54eb76f509ff5aaf5db4baf
      07791558
    • Treehugger Robot's avatar
    • Daniel Rosenberg's avatar
      Move sdcardfs media_rw_data_file rules to app.te · 2a0053b2
      Daniel Rosenberg authored
      Test: No media_rw_data_file related app denials
      Change-Id: I1a977db09379f9a3e5bc52c597df12f52929ad19
      2a0053b2
    • dcashman's avatar
      Fix build. · 0c8ad1dc
      dcashman authored
      Make all platform tyeps public to start to prevent build breakage in any devices
      that may have device-specific policy using these types.  Future changes will
      need to be carefully made to ensure we properly limit types for use by
      non-platform policy.
      
      Test: Builds
      Change-Id: I7349940d5b5a57357bc7c16f66925dee1d030eb6
      0c8ad1dc
  9. Dec 06, 2016
Loading