Skip to content
Snippets Groups Projects
  1. Mar 18, 2018
  2. Mar 12, 2018
    • Sunny Kapdi's avatar
      Bluetooth A2DP offload: Binder call to audio HAL · 863a4efa
      Sunny Kapdi authored
      Add rule to allow Binder call from Bluetooth process to Bluetooth
      audio HIDL interface running in audio HAL service process.
      
      Bug: 63932139
      Bug: 72242910
      Test: Manual; TestTracker/148125
      Change-Id: I1981a78bece10b8e516f218d3edde8b77943d130
      (cherry picked from commit e8cfac90e8bf14466b6431a21bc5ccd4bf6ca3ea)
      863a4efa
    • Aniket Kumar Lata's avatar
      sepolicy: Read access to audioserver for Bluetooth properties · abda4ac4
      Aniket Kumar Lata authored
      Provide read/write access to audioserver for Bluetooth
      properties used with A2DP offload.
      
      Bug: 63932139
      Bug: 68824150
      Test: Manual; TestTracker/148125
      Change-Id: I40c932d085ac55bc45e6654f966b2c9d244263d0
      (cherry picked from commit 041049bc7a4e29dcca48e2c068b92aa8a8157d90)
      abda4ac4
    • Amit Mahajan's avatar
      Revert "Revert "Move rild from public to vendor."" · 312248ff
      Amit Mahajan authored
      This reverts commit 016f0a58.
      
      Reason for revert: Was temporarily reverted, merging back in with fix.
      
      Bug: 74486619
      Bug: 36427227
      Change-Id: Ide68726a90d5485c2758673079427407aee1e4f2
      312248ff
  3. Mar 11, 2018
  4. Mar 08, 2018
    • Amit Mahajan's avatar
      Move rild from public to vendor. · eeda6c61
      Amit Mahajan authored
      Also change the neverallow exceptions to be for hal_telephony_server
      instead of rild.
      
      Test: Basic telephony sanity, treehugger
      Bug: 36427227
      Change-Id: If892b28416d98ca1f9c241c5fcec70fbae35c82e
      eeda6c61
    • Joel Galenson's avatar
      Ensure taking a bugreport generates no denials. · ba0c279d
      Joel Galenson authored
      This commit adds new SELinux permissions and neverallow rules so that
      taking a bugreport does not produce any denials.
      
      Bug: 73256908
      Test: Captured bugreports on Sailfish and Walleye and verified
      that there were no denials.
      
      Merged-In: If3f2093a2b51934938e3d7e5c42036b2e2bf6de9
      Change-Id: If3f2093a2b51934938e3d7e5c42036b2e2bf6de9
      (cherry picked from commit daf1cdfa5ac7eca95f3b21034174a495a6760e47)
      ba0c279d
    • Jiyong Park's avatar
      /odm is another vendor partition other than /vendor · e64edff1
      Jiyong Park authored
      Sub directories under /odm (or /vendor/odm when there isn't an odm
      partition) are labeled so that artifacts under the sub directories are
      treated the same as their counterpart in the vendor partition.
      
      For example, /odm/app/* is labeled as vendor_app_file just like
      /vendor/app/*.
      
      Bug: 71366495
      Test: m -j
      
      Merged-In: I72a14fd55672cd2867edd88ced9828ea49726694
      Change-Id: I72a14fd55672cd2867edd88ced9828ea49726694
      (cherry picked from commit 2f101551)
      e64edff1
  5. Mar 07, 2018
    • Ruchi Kandoi's avatar
      Add secure_element_device · e0e2342e
      Ruchi Kandoi authored
      Test: eSE initializes at boot
      Bug: 64881253
      Change-Id: Ib2388b7368c790c402c000adddf1488bee492cce
      (cherry picked from commit ea3cf000)
      e0e2342e
    • Kweku Adams's avatar
      Enabling incidentd to get top and ps data. · bcf8b115
      Kweku Adams authored
      Bug: 72177715
      Bug: 72384374
      Test: flash device and make sure incidentd is getting data without SELinux denials
      Change-Id: I684fe014e19c936017a466ec2d6cd2e1f03022c0
      (cherry picked from commit 06ac7dba)
      bcf8b115
    • Joel Galenson's avatar
      Clean up bug_map. · f3f93eaf
      Joel Galenson authored
      Remove a fixed bug from bug_map.
      
      Bug: 62140539
      Test: Built policy.
      Change-Id: I2ce9e48de92975b6e37ca4a3a4c53f9478b006ef
      f3f93eaf
    • Joel Galenson's avatar
      Track platform_app SELinux denial. · 2995e996
      Joel Galenson authored
      This should fix presubmit tests.
      
      Bug: 74331887
      Test: Built policy.
      Change-Id: Ie9ef75a7f9eaebf1103e3d2f3b4521e9abaf2fe7
      2995e996
    • Chenbo Feng's avatar
      Fix sepolicy for bpf object · 6cd70c2f
      Chenbo Feng authored
      With the new patches backported to 4.9 kernels, the bpf file system now
      take the same file open flag as bpf_obj_get. So system server now need
      read permission only for both bpf map and fs_bpf since we do not need
      system server to edit the map. Also, the netd will always pass stdin
      stdout fd to the process forked by it and do allow it will cause the
      fork and execev fail. We just allow it pass the fd to bpfloader for now
      until we have a better option.
      
      Test: bpfloader start successful on devices with 4.9 kernel.
            run cts -m CtsNetTestCases -t android.net.cts.TrafficStatsTest
      Bug: 74096311
      Bug: 30950746
      
      Change-Id: I747a51cb05ae495c155e7625a3021fc77f921e0d
      6cd70c2f
  6. Mar 01, 2018
  7. Feb 28, 2018
    • Jeff Vander Stoep's avatar
      system_server: grant read access to vendor/framework · 9e33565c
      Jeff Vander Stoep authored
      avc: denied { getattr } for path="/vendor/framework"
      scontext=u:r:system_server:s0 tcontext=u:object_r:vendor_framework_file:s0
      tclass=dir
      
      Bug: 68826235
      Test: boot Taimen, verify denials no longer occur.
      Change-Id: Id4b311fd423342c8d6399c3b724417aff9d1cd88
      9e33565c
    • Ajay Panicker's avatar
      Allow audioserver to access Bluetooth Properties · e32d9406
      Ajay Panicker authored
      Now that Bluetooth supports delay reporting, audioserver needs
      access to Bluetooth Properties in order to determine whether the
      feature is enabled or disabled.
      
      Bug: 32755225
      Test: Enable the property and see that there was no error accessing it
      Change-Id: I519d49deb2df4efb3cc2cce9c6d497db18b50c13
      e32d9406
  8. Feb 27, 2018
    • Joel Galenson's avatar
      Clean up bug_map. · 40c112c8
      Joel Galenson authored
      Remove a fixed bug from bug_map.
      
      Bug: 73068008
      Test: Built policy.
      Change-Id: Id0072788953cb6b939a11caace0158da7799f540
      40c112c8
    • Tej Singh's avatar
      Statsd sepolicy for thermal hal · c26ac738
      Tej Singh authored
      Updates statsd sepolicy so it can use the thermal hal.
      
      Test: verified these policies solved sepolicy issues with thermal hal.
      Change-Id: I36839a72494b084d5742c4d83c3ce9814102b974
      c26ac738
  9. Feb 26, 2018
  10. Feb 23, 2018
    • Bookatz's avatar
      Fix benign statsd selinux violations · c9f205b5
      Bookatz authored
      These two selinux policy violations keep showing up from statsd's CTS
      tests, although statsd and the CTS test seemed to function fine despite
      them. Nonetheless, they seem reasonable to add to the list.
      
      Bug: 73548694
      Test: N/A. It didn't seem to be causing any issues in the first place.
      Change-Id: Id36c5229c0d7de83675166caeb07c87b719dc374
      c9f205b5
    • Florian Mayer's avatar
      Allow traced_probes to list the system partition · ef6358bb
      Florian Mayer authored
      Relevant denies:
      
      [    2.560660] type=1400 audit(1519404055.529:9): avc: denied { read }
      for pid=896 comm=traced_probes name=system dev=sda22 ino=17
      scontext=u:r:traced_probes:s0 tcontext=u:object_r:system_file:s0
      tclass=dir permissive=0
      
      Allowing only read then gives:
      [    2.554718] type=1400 audit(1519404863.506:9): avc: denied { open }
      for pid=890 comm="traced_probes" path="/system" dev="sda22" ino=17
      scontext=u:r:traced_probes:s0 tcontext=u:object_r:system_file:s0
      tclass=dir permissive=0
      
      Test: flashed and ran directory listing code.
      Bug: 73625480
      ef6358bb
    • Robert Sesek's avatar
      Remove rules for starting the webview_zygote as a child of init. · 869562e9
      Robert Sesek authored
      The webview_zygote is now launched as a child-zygote process from the
      main zygote process.
      
      Bug: 63749735
      Test: m
      Test: Launch "Third-party licenses" activity from Settings, and it
            renders correctly via the WebView.
      Merged-In: I9c948b58a969d35d5a5add4b6ab62b8f990645d1
      Change-Id: I153476642cf14883b0dfea0d9f5b3b5e30ac1c08
      869562e9
  11. Feb 22, 2018
    • Sandeep Patil's avatar
      Add label for kernel test files and executables · 34e35e9e
      Sandeep Patil authored
      
      This required for kernel to do loopback mounts on filesystem
      images created by the kernel system call tests in LTP.
      
      Add a corresponding neverallow to stop all domains from accessing
      the location at /data/local/tmp/ltp.
      
      Bug: 73220071
      Test: Boot sailfish successfully
      Test: run vts-kernel -m VtsKernelLtp -t syscalls.fchown04
      
      Change-Id: I73f5f14017e22971fc246a05751ba67be4653bca
      Signed-off-by: default avatarSandeep Patil <sspatil@google.com>
      34e35e9e
  12. Feb 21, 2018
    • Robert Sesek's avatar
      Allow zygote to setpgid on webview_zygote. · 63bcf4de
      Robert Sesek authored
      Bug: 73720684
      Bug: 73720684
      Test: m
      Test: BootTest on taimen
      Change-Id: I5a58fd1cce568cc50ba791f445f5c148eb87b474
      63bcf4de
    • Primiano Tucci's avatar
      perfetto: Make producer socket MLS-aware · 5ef6669b
      Primiano Tucci authored
      The previous selinux rules obtained via audit2allow didn't really
      work with the case of apps connecting to the producer socket,
      despite all the allow rules being correctly in place.
      This was failing our CTS tests.
      
      The reason for the failure (see denials pasted below) is due to
      Multi Level Security (for multi-user), which was still preventing
      apps form a different level to connect to the traced producer
      socket and write to the shmem buffers they get passed back.
      This CL tags the objects being accessed as mlstrusted.
      CTS tests pass with this CL.
      
      Denials:
      avc: denied { write } for pid=8545 comm="traced_probes" name="traced_producer" dev="tmpfs" ino=23629 scontext=u:r:untrusted_app_25:s0:c512,c768 tcontext=u:object_r:traced_producer_socket:s0 tclass=sock_file permissive=1
      avc: denied { write } for pid=8545 comm="traced_probes" name="traced_producer" dev="tmpfs" ino=23629 scontext=u:r:untrusted_app_25:s0:c512,c768 tcontext=u:object_r:traced_producer_socket:s0 tclass=sock_file permissive=1
      avc: denied { connectto } for pid=8545 comm="traced_probes" path="/dev/socket/traced_producer" scontext=u:r:untrusted_app_25:s0:c512,c768 tcontext=u:r:traced:s0 tclass=unix_stream_socket permissive=1
      avc: denied { connectto } for pid=8545 comm="traced_probes" path="/dev/socket/traced_producer" scontext=u:r:untrusted_app_25:s0:c512,c768 tcontext=u:r:traced:s0 tclass=unix_stream_socket permissive=1
      avc: denied { write } for pid=8545 comm="traced_probes" path=2F6D656D66643A706572666574746F5F73686D656D202864656C6574656429 dev="tmpfs" ino=104483 scontext=u:r:untrusted_app_25:s0:c512,c768 tcontext=u:object_r:traced_tmpfs:s0 tclass=file permissive=1
      
      Change-Id: I1598bc0b07bf39b8d0420b66caf06a4ca884f383
      Bug: 73340039
      Test: CtsPerfettoTestCases
      5ef6669b
    • Carmen Jackson's avatar
      Allow Traceur app to remove trace files. · fa0bf19b
      Carmen Jackson authored
      Bug: 73660835
      Test: With the other commit on this topic, clearing all trace files via
      the app works properly.
      
      Change-Id: I27a4a5a14d9afe817683f1b046a644648a84badc
      fa0bf19b
  13. Feb 16, 2018
  14. Feb 15, 2018
    • Max Bires's avatar
      Revert "Revert "Ensure only com.android.shell can run in the shell domain."" · 77d41f78
      Max Bires authored
      This reverts commit bf0c2a59.
      
      Bug:68126425
      Test: No apps affected by not being able to run in shell domain
      Change-Id: I8b93eecd023fbb392a98253d721dad75f79b61f4
      77d41f78
    • Joel Galenson's avatar
      Dontaudit denials caused by race with labeling. · f7ec4138
      Joel Galenson authored
      These denials seem to be caused by a race with the process that labels
      the files.  While we work on fixing them, hide the denials.
      
      Bug: 68864350
      Bug: 70180742
      Test: Built policy.
      Change-Id: I58a32e38e6384ca55e865e9575dcfe7c46b2ed3c
      f7ec4138
    • Robert Sesek's avatar
      SELinux changes to accomodate starting the webview_zygote as a child of the zygote. · febdfa4e
      Robert Sesek authored
      In this architecture, the system_server instructs the zygote to fork a
      child-zygote to be the webview_zygote. The system_server tells this new
      zygote to listen for fork requests on a random abstract unix socket of
      its choosing.
      
      A follow-up CL will remove the rules for starting webview_zygote via
      init.
      
      Bug: 63749735
      Test: m
      Test: Launch "Third-party licenses" activity from Settings, and it
            renders correctly via the WebView.
      Merged-In: I864743943c11c18de386010ecd4b616721cb9954
      Change-Id: I1c352e47b66eca3a3fa641daa6ecc3e7a889b54e
      febdfa4e
  15. Feb 14, 2018
    • Robert Sesek's avatar
      SELinux changes to accomodate starting the webview_zygote as a child of the zygote. · bacb19b9
      Robert Sesek authored
      In this architecture, the system_server instructs the zygote to fork a
      child-zygote to be the webview_zygote. The system_server tells this new
      zygote to listen for fork requests on a random abstract unix socket of
      its choosing.
      
      A follow-up CL will remove the rules for starting webview_zygote via
      init.
      
      Bug: 63749735
      Test: m
      Test: Launch "Third-party licenses" activity from Settings, and it
            renders correctly via the WebView.
      Change-Id: I864743943c11c18de386010ecd4b616721cb9954
      bacb19b9
  16. Feb 13, 2018
    • Bookatz's avatar
      Statsd allow shell in selinux policy · 022ab0e7
      Bookatz authored
      CTS tests need to be able to call, from hostside:
      adb shell cmd stats dump-report (and others)
      On a user build, this will fail because of an selinux policy violation
      from shell. This cl fixes this by granting shell permission.
      
      Similarly, Settings needs to communicate with statsd, so
      system_app-statsd binder calls are given permission.
      
      Bug: 72961153
      Bug: 73255014
      Test: run cts-dev -m CtsStatsdHostTestCases -t android.cts.statsd.atom.HostAtomTests
      Test: manual confirmation
      Change-Id: I6589ab4ef5c91a4a7f78eb97b63d9bb43e3d8f02
      022ab0e7
    • Primiano Tucci's avatar
      Allow perfetto traced_probes to access tracefs on user · b4b31f9d
      Primiano Tucci authored
      Allows the traced_probes daemon to access the core ftrace
      functionalities on user builds. Specifically this involves:
      - Whitelisting the per_cpu/ subdirectory to access:
        1) trace_pipe_raw file to allow perfetto to read the raw
           ftrace buffer (rather than the text-based /trace endpoint)
        2) cpuX/stats and cpuX/buffer_size_kb that allow to
           tune the buffer size per-cpu pipe and to get basic
           statistics about the ftrace buffer (#events, overruns)
      - Whitelistiing the full event directories rather than the
        /enable files. This gives also access to the /format files
        for the events that are already enabled on user builds.
        /format files simply describe the memory layout
        of the binary logs. Example: https://ghostbin.com/paste/f8m4k
      
      This still does NOT allow enabling the events labeled as
      "_debug" (mostly events that return activity on inodes).
      We'll deal with that separately as soon as we get a POC
      of inode resolution and a sensible blacklist/whitelist model.
      
      Bug: 70942310
      Change-Id: Ic15cca0a9d7bc0e45aa48097a94eadef44c333f8
      b4b31f9d
  17. Feb 12, 2018
  18. Feb 09, 2018
  19. Feb 08, 2018
    • Joel Galenson's avatar
      Track system_server SELinux denial. · 387729fe
      Joel Galenson authored
      This should fix presubmit tests.
      
      Bug: 73128755
      Test: Built policy.
      Change-Id: Ie389de04360090594e627e629a59a60092dda6ca
      387729fe
    • Jeff Vander Stoep's avatar
      label /data/vendor{_ce,_de} · d25ccabd
      Jeff Vander Stoep authored
      Restrictions introduced in vendor init mean that new devices
      may not no longer exempt vendor init from writing to system_data_file.
      This means we must introduce a new label for /data/vendor which
      vendor_init may write to.
      
      Bug: 73087047
      Test: build and boot Taimen and Marlin. Complete SUW, enroll fingerprint
          No new denials.
      
      Change-Id: I65f904bb28952d4776aab947515947e14befbe34
      d25ccabd
Loading